diff mbox series

[API-NEXT,v1,1/1] api: ipsec: add AH capability

Message ID 1494442806-16915-2-git-send-email-odpbot@yandex.ru
State Superseded
Headers show
Series [API-NEXT,v1,1/1] api: ipsec: add AH capability | expand

Commit Message

Github ODP bot May 10, 2017, 7 p.m. UTC
From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>


RFC4301 marks AH support as MAY instead of MUST. Some platforms might
skip implementing AH. Thus we should provide capability to allow
applications to check if AH is actually implemented or not.

Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

---
/** Email created from pull request 26 (lumag:ipsec-ah-cap)
 ** https://github.com/Linaro/odp/pull/26
 ** Patch: https://github.com/Linaro/odp/pull/26.patch
 ** Base sha: 3ea9c1dac34e0fb4785b0d643056c731daa55e85
 ** Merge commit sha: 1b298f0560ad52ebe47022df83bc185cb4a0e11d
 **/
 include/odp/api/spec/ipsec.h | 3 +++
 1 file changed, 3 insertions(+)

Comments

Balasubramanian Manoharan May 10, 2017, 8 p.m. UTC | #1
Reviewed-by: Balasubramanian Manoharan <bala.manoharan@linaro.org>


On 10 May 2017 at 12:00, Github ODP bot <odpbot@yandex.ru> wrote:
> From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

>

> RFC4301 marks AH support as MAY instead of MUST. Some platforms might

> skip implementing AH. Thus we should provide capability to allow

> applications to check if AH is actually implemented or not.

>

> Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

> ---

> /** Email created from pull request 26 (lumag:ipsec-ah-cap)

>  ** https://github.com/Linaro/odp/pull/26

>  ** Patch: https://github.com/Linaro/odp/pull/26.patch

>  ** Base sha: 3ea9c1dac34e0fb4785b0d643056c731daa55e85

>  ** Merge commit sha: 1b298f0560ad52ebe47022df83bc185cb4a0e11d

>  **/

>  include/odp/api/spec/ipsec.h | 3 +++

>  1 file changed, 3 insertions(+)

>

> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h

> index e83494d..016d232 100644

> --- a/include/odp/api/spec/ipsec.h

> +++ b/include/odp/api/spec/ipsec.h

> @@ -244,6 +244,9 @@ typedef struct odp_ipsec_capability_t {

>         /** Inline IPSEC operation mode (ODP_IPSEC_OP_MODE_INLINE) support */

>         odp_support_t op_mode_inline;

>

> +       /** Synchronous of AH (ODP_IPSEC_AH ) support */

> +       odp_support_t op_proto_ah;

> +

>         /**

>          * Support of pipelined classification (ODP_IPSEC_PIPELINE_CLS) of

>          *  resulting inbound packets

>
Savolainen, Petri (Nokia - FI/Espoo) May 10, 2017, 8:23 p.m. UTC | #2
> -----Original Message-----

> From: lng-odp [mailto:lng-odp-bounces@lists.linaro.org] On Behalf Of

> Github ODP bot

> Sent: Wednesday, May 10, 2017 10:00 PM

> To: lng-odp@lists.linaro.org

> Subject: [lng-odp] [PATCH API-NEXT v1 1/1] api: ipsec: add AH capability

> 

> From: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

> 

> RFC4301 marks AH support as MAY instead of MUST. Some platforms might

> skip implementing AH. Thus we should provide capability to allow

> applications to check if AH is actually implemented or not.

> 

> Signed-off-by: Dmitry Eremin-Solenikov <dmitry.ereminsolenikov@linaro.org>

> ---

> /** Email created from pull request 26 (lumag:ipsec-ah-cap)

>  ** https://github.com/Linaro/odp/pull/26

>  ** Patch: https://github.com/Linaro/odp/pull/26.patch

>  ** Base sha: 3ea9c1dac34e0fb4785b0d643056c731daa55e85

>  ** Merge commit sha: 1b298f0560ad52ebe47022df83bc185cb4a0e11d

>  **/

>  include/odp/api/spec/ipsec.h | 3 +++

>  1 file changed, 3 insertions(+)

> 

> diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h

> index e83494d..016d232 100644

> --- a/include/odp/api/spec/ipsec.h

> +++ b/include/odp/api/spec/ipsec.h

> @@ -244,6 +244,9 @@ typedef struct odp_ipsec_capability_t {

>  	/** Inline IPSEC operation mode (ODP_IPSEC_OP_MODE_INLINE)

> support */

>  	odp_support_t op_mode_inline;

> 

> +	/** Synchronous of AH (ODP_IPSEC_AH ) support */


There's couple of copy-paste errors on these two line.

Only this: "AH protocol (ODP_IPSEC_AH) support"

> +	odp_support_t op_proto_ah;


Variable name should be just "proto_ah"

-Petri


> +

>  	/**

>  	 * Support of pipelined classification (ODP_IPSEC_PIPELINE_CLS)

> of

>  	 *  resulting inbound packets
diff mbox series

Patch

diff --git a/include/odp/api/spec/ipsec.h b/include/odp/api/spec/ipsec.h
index e83494d..016d232 100644
--- a/include/odp/api/spec/ipsec.h
+++ b/include/odp/api/spec/ipsec.h
@@ -244,6 +244,9 @@  typedef struct odp_ipsec_capability_t {
 	/** Inline IPSEC operation mode (ODP_IPSEC_OP_MODE_INLINE) support */
 	odp_support_t op_mode_inline;
 
+	/** Synchronous of AH (ODP_IPSEC_AH ) support */
+	odp_support_t op_proto_ah;
+
 	/**
 	 * Support of pipelined classification (ODP_IPSEC_PIPELINE_CLS) of
 	 *  resulting inbound packets