From patchwork Tue Mar 25 16:55:37 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27071 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id C4C4920539 for ; Tue, 25 Mar 2014 16:58:32 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id j17sf2884726oag.10 for ; Tue, 25 Mar 2014 09:58:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=Ql8AyQitA80LO4fA0kywrjqajqmL7c9q+V/JlHwWHNM=; b=Q91+/cHoZvmDra06Y5PtqVjRjFLRxChM4aAIVafkl2ZdJd+UlcksbJZtnY9kYRC3eK sbwDuj22P9nIoqfLb5TUzOUB0ybyGtf3gjaxSpVirDjvsiMpzW2eb0vzi+OR4GU+qItW 1btxH6I/CdiQFHUMUq6FaYQLTdjxbTyt5vkKDoRypCtHmZKK4KsfaR+e1Dlu2FpSQQhv HRx03dSj8gmJe05TzhQb0ygLYFkV2HDX4EKS2DxJHpkgzm19+gsQiJN67E3p74gCMAmx ZjijC7jXvStPPHIZEzjVuaAgOSSnWaKDMog+yfu3muHGjBLUxIymUFHPhX3YDb2T38XX gGXA== X-Gm-Message-State: ALoCoQkjVzBNhHW+FhQ48SAbxAcE8ZKze9TscTUnP5DhJRDLNbyisBvKnqF7BeKiNApbuAH0y4n7 X-Received: by 10.43.69.210 with SMTP id yd18mr26909855icb.10.1395766712346; Tue, 25 Mar 2014 09:58:32 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.91.120 with SMTP id y111ls330920qgd.0.gmail; Tue, 25 Mar 2014 09:58:32 -0700 (PDT) X-Received: by 10.52.6.162 with SMTP id c2mr14418977vda.6.1395766712261; Tue, 25 Mar 2014 09:58:32 -0700 (PDT) Received: from mail-ve0-f176.google.com (mail-ve0-f176.google.com [209.85.128.176]) by mx.google.com with ESMTPS id xj4si3865372vec.72.2014.03.25.09.58.32 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 25 Mar 2014 09:58:32 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.176; Received: by mail-ve0-f176.google.com with SMTP id cz12so865710veb.21 for ; Tue, 25 Mar 2014 09:58:31 -0700 (PDT) X-Received: by 10.58.248.5 with SMTP id yi5mr485536vec.42.1395766711709; Tue, 25 Mar 2014 09:58:31 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.78.9 with SMTP id i9csp320412vck; Tue, 25 Mar 2014 09:58:30 -0700 (PDT) X-Received: by 10.50.176.162 with SMTP id cj2mr18847710igc.7.1395766672880; Tue, 25 Mar 2014 09:57:52 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id y6si28332424igl.10.2014.03.25.09.57.52 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 25 Mar 2014 09:57:52 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSUeo-00010e-17; Tue, 25 Mar 2014 16:56:58 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WSUej-0000rP-Q9 for xen-devel@lists.xenproject.org; Tue, 25 Mar 2014 16:56:54 +0000 Received: from [85.158.143.35:9936] by server-2.bemta-4.messagelabs.com id E0/37-06539-555B1335; Tue, 25 Mar 2014 16:56:53 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-9.tower-21.messagelabs.com!1395766612!4621441!1 X-Originating-IP: [74.125.83.50] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4385 invoked from network); 25 Mar 2014 16:56:52 -0000 Received: from mail-ee0-f50.google.com (HELO mail-ee0-f50.google.com) (74.125.83.50) by server-9.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 25 Mar 2014 16:56:52 -0000 Received: by mail-ee0-f50.google.com with SMTP id c13so678276eek.23 for ; Tue, 25 Mar 2014 09:56:52 -0700 (PDT) X-Received: by 10.15.60.199 with SMTP id g47mr70890985eex.37.1395766612037; Tue, 25 Mar 2014 09:56:52 -0700 (PDT) Received: from belegaer.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id h47sm33377501eey.13.2014.03.25.09.56.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 Mar 2014 09:56:50 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 25 Mar 2014 16:55:37 +0000 Message-Id: <1395766541-23979-31-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> References: <1395766541-23979-1-git-send-email-julien.grall@linaro.org> Cc: ian.campbell@citrix.com, Julien Grall , tim@xen.org, stefano.stabellini@citrix.com, Daniel De Graaf Subject: [Xen-devel] [PATCH 30/34] xen: Add missing includes on different files X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.176 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: There is a bunch of functions in xen code which are declared without the prototypes defined before. This may lead to runtime issue if the propotype doesn't match the declaration. Add missing includes where the prototype of theses functions are defined. This was spotted by -Wmissing-prototypes, which we can't enable because there is exported function for assembly. I'm not sure if we need to add a prototype for them. Signed-off-by: Julien Grall Cc: Ian Campbell Cc: Stefano Stabellini Cc: Tim Deegan Cc: Konrad Rzeszutek Wilk Cc: Daniel De Graaf Acked-by: Daniel De Graaf --- xen/arch/arm/hvm.c | 1 + xen/arch/arm/mm.c | 1 + xen/arch/arm/shutdown.c | 1 + xen/arch/arm/smp.c | 1 + xen/arch/arm/time.c | 1 + xen/arch/arm/vtimer.c | 1 + xen/common/event_channel.c | 1 + xen/common/grant_table.c | 1 + xen/common/multicall.c | 3 +++ xen/common/sort.c | 1 + xen/common/tmem.c | 1 + xen/drivers/video/arm_hdlcd.c | 1 + xen/xsm/flask/ss/conditional.h | 1 + 13 files changed, 15 insertions(+) diff --git a/xen/arch/arm/hvm.c b/xen/arch/arm/hvm.c index 471c4cd..b695b26 100644 --- a/xen/arch/arm/hvm.c +++ b/xen/arch/arm/hvm.c @@ -4,6 +4,7 @@ #include #include #include +#include #include diff --git a/xen/arch/arm/mm.c b/xen/arch/arm/mm.c index fc58fc6..84b6ccc 100644 --- a/xen/arch/arm/mm.c +++ b/xen/arch/arm/mm.c @@ -39,6 +39,7 @@ #include #include #include +#include struct domain *dom_xen, *dom_io, *dom_cow; diff --git a/xen/arch/arm/shutdown.c b/xen/arch/arm/shutdown.c index adc0529..43eaf47 100644 --- a/xen/arch/arm/shutdown.c +++ b/xen/arch/arm/shutdown.c @@ -4,6 +4,7 @@ #include #include #include +#include #include static void raw_machine_reset(void) diff --git a/xen/arch/arm/smp.c b/xen/arch/arm/smp.c index 30203b8..7bb602d 100644 --- a/xen/arch/arm/smp.c +++ b/xen/arch/arm/smp.c @@ -1,4 +1,5 @@ #include +#include #include #include #include diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 7f4f2b4..3b0feec 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include diff --git a/xen/arch/arm/vtimer.c b/xen/arch/arm/vtimer.c index 83f4c0f..6aeae5d 100644 --- a/xen/arch/arm/vtimer.c +++ b/xen/arch/arm/vtimer.c @@ -25,6 +25,7 @@ #include #include #include +#include "vtimer.h" static void phys_timer_expired(void *data) { diff --git a/xen/common/event_channel.c b/xen/common/event_channel.c index db952af..e94e37e 100644 --- a/xen/common/event_channel.c +++ b/xen/common/event_channel.c @@ -28,6 +28,7 @@ #include #include #include +#include #include #include diff --git a/xen/common/grant_table.c b/xen/common/grant_table.c index 107b000..386cdff 100644 --- a/xen/common/grant_table.c +++ b/xen/common/grant_table.c @@ -37,6 +37,7 @@ #include #include #include +#include #include #include diff --git a/xen/common/multicall.c b/xen/common/multicall.c index e66c798..bb7550b 100644 --- a/xen/common/multicall.c +++ b/xen/common/multicall.c @@ -6,6 +6,9 @@ #include #include #include +#ifndef COMPAT +#include +#endif #include #include #include diff --git a/xen/common/sort.c b/xen/common/sort.c index d96fc2a..7069888 100644 --- a/xen/common/sort.c +++ b/xen/common/sort.c @@ -5,6 +5,7 @@ */ #include +#include static void u32_swap(void *a, void *b, int size) { diff --git a/xen/common/tmem.c b/xen/common/tmem.c index 5155114..865d154 100644 --- a/xen/common/tmem.c +++ b/xen/common/tmem.c @@ -23,6 +23,7 @@ #include #include #include +#include #define TMEM_SPEC_VERSION 1 diff --git a/xen/drivers/video/arm_hdlcd.c b/xen/drivers/video/arm_hdlcd.c index 841d0d0..04a3091 100644 --- a/xen/drivers/video/arm_hdlcd.c +++ b/xen/drivers/video/arm_hdlcd.c @@ -25,6 +25,7 @@ #include #include #include +#include #include "font.h" #include "lfb.h" #include "modelines.h" diff --git a/xen/xsm/flask/ss/conditional.h b/xen/xsm/flask/ss/conditional.h index d389ecf..65af76b 100644 --- a/xen/xsm/flask/ss/conditional.h +++ b/xen/xsm/flask/ss/conditional.h @@ -13,6 +13,7 @@ #include "avtab.h" #include "symtab.h" #include "policydb.h" +#include "../include/conditional.h" #define COND_EXPR_MAXDEPTH 10