From patchwork Thu Apr 3 20:42:05 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 27711 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 3A05420490 for ; Thu, 3 Apr 2014 20:44:27 +0000 (UTC) Received: by mail-wg0-f71.google.com with SMTP id l18sf2401620wgh.10 for ; Thu, 03 Apr 2014 13:44:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive:content-type:content-transfer-encoding; bh=D7TTvBXCPdRYW9qaO8oyTcLVWizAReTr/x7sEhyQZGw=; b=DAfgaDjo4UnixvEBWkUddxC4Abz/SxqVjtpy/ZLPC6Vseo7BxJkNiQ9efLJ65xdLGq Rh4W1+i2vHyGn6rsGfpVYQ7F3fVubzYHMmCw5P+8fUYJgt2124nAlVP85bDcXdJ2K3yM 4nQ/dWcWufKKfeupTWaQOJbkwFMBmEN2qHJrwlykF2Sc8hSt654WWoc8VykwVCrGqxpL yGkJ/ULq9o8dTqPtTayZVL4rt7wxFOTyXYFSOZYmEOZFUVsDzrhUUErzLHl32GzAaI55 H4rSrp+celPJFueIIRILVUlI4y8K6UX4Jcb8T86/ELaWKTkqqsFwCYGF2sikeEwh/gl7 LX4w== X-Gm-Message-State: ALoCoQmCN5rKHXiLbGW7/qgnL2yCn/O01ZbHSmmf842Wa/q1POhbvs2JCwKRB33K5if75GmGVuo7 X-Received: by 10.112.136.162 with SMTP id qb2mr2557222lbb.16.1396557866172; Thu, 03 Apr 2014 13:44:26 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.101 with SMTP id k92ls811369qgf.64.gmail; Thu, 03 Apr 2014 13:44:26 -0700 (PDT) X-Received: by 10.58.181.170 with SMTP id dx10mr1354662vec.25.1396557865993; Thu, 03 Apr 2014 13:44:25 -0700 (PDT) Received: from mail-ve0-f180.google.com (mail-ve0-f180.google.com [209.85.128.180]) by mx.google.com with ESMTPS id sj10si1427239vcb.15.2014.04.03.13.44.25 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 03 Apr 2014 13:44:25 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) client-ip=209.85.128.180; Received: by mail-ve0-f180.google.com with SMTP id jz11so710915veb.25 for ; Thu, 03 Apr 2014 13:44:25 -0700 (PDT) X-Received: by 10.52.23.97 with SMTP id l1mr7933634vdf.11.1396557865880; Thu, 03 Apr 2014 13:44:25 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.12.8 with SMTP id v8csp59809vcv; Thu, 3 Apr 2014 13:44:24 -0700 (PDT) X-Received: by 10.224.79.72 with SMTP id o8mr10033040qak.20.1396557846381; Thu, 03 Apr 2014 13:44:06 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id 100si2658636qgf.37.2014.04.03.13.44.04 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 03 Apr 2014 13:44:06 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of xen-devel-bounces@lists.xen.org designates 50.57.142.19 as permitted sender) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVoTE-0008Hl-Nx; Thu, 03 Apr 2014 20:42:44 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WVoTD-0008Gy-Bp for xen-devel@lists.xenproject.org; Thu, 03 Apr 2014 20:42:43 +0000 Received: from [85.158.143.35:33987] by server-2.bemta-4.messagelabs.com id F2/20-06539-2C7CD335; Thu, 03 Apr 2014 20:42:42 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-8.tower-21.messagelabs.com!1396557761!6854587!1 X-Originating-IP: [209.85.212.170] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.11.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20132 invoked from network); 3 Apr 2014 20:42:41 -0000 Received: from mail-wi0-f170.google.com (HELO mail-wi0-f170.google.com) (209.85.212.170) by server-8.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 3 Apr 2014 20:42:41 -0000 Received: by mail-wi0-f170.google.com with SMTP id bs8so1593898wib.5 for ; Thu, 03 Apr 2014 13:42:40 -0700 (PDT) X-Received: by 10.180.80.37 with SMTP id o5mr1388853wix.60.1396557760897; Thu, 03 Apr 2014 13:42:40 -0700 (PDT) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id t50sm14510572eev.28.2014.04.03.13.42.40 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 03 Apr 2014 13:42:40 -0700 (PDT) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Thu, 3 Apr 2014 21:42:05 +0100 Message-Id: <1396557727-19102-15-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> References: <1396557727-19102-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Keir Fraser , Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH v2 14/16] xen/arm: IRQ: Replace {request, setup}_dt_irq by {request, setup}_irq X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.128.180 is neither permitted nor denied by best guess record for domain of patch+caf_=patchwork-forward=linaro.org@linaro.org) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Now that irq_desc stores the type of the IRQ (e.g level/edge,...), we don't need anymore to use specific IRQ function for ARM. Also replace every call to dt_device_get_irq by platform_get_irq which is a wrapper to this function and setup the IRQ type correctly. Signed-off-by: Julien Grall Cc: Keir Fraser --- Changes in v2: - Patch added --- xen/arch/arm/gic.c | 12 ++++++------ xen/arch/arm/irq.c | 23 +++++++++++------------ xen/arch/arm/time.c | 28 ++++++++++++++-------------- xen/drivers/char/exynos4210-uart.c | 14 +++++++------- xen/drivers/char/ns16550.c | 17 +++-------------- xen/drivers/char/omap-uart.c | 14 +++++++------- xen/drivers/char/pl011.c | 17 +++++++++-------- xen/include/asm-arm/irq.h | 5 ----- 8 files changed, 57 insertions(+), 73 deletions(-) diff --git a/xen/arch/arm/gic.c b/xen/arch/arm/gic.c index ec2994e..97b0153 100644 --- a/xen/arch/arm/gic.c +++ b/xen/arch/arm/gic.c @@ -47,7 +47,7 @@ static struct { paddr_t hbase; /* Address of virtual interface registers */ paddr_t vbase; /* Address of virtual cpu interface registers */ unsigned int lines; /* Number of interrupts (SPIs + PPIs + SGIs) */ - struct dt_irq maintenance; /* IRQ maintenance */ + unsigned int maintenance_irq; /* IRQ maintenance */ unsigned int cpus; spinlock_t lock; } gic; @@ -439,8 +439,8 @@ void __init gic_init(void) if ( res || !gic.vbase || (gic.vbase & ~PAGE_MASK) ) panic("GIC: Cannot find a valid address for the virtual CPU"); - res = dt_device_get_irq(node, 0, &gic.maintenance); - if ( res ) + gic.maintenance_irq = platform_get_irq(node, 0); + if ( !gic.maintenance_irq ) panic("GIC: Cannot find the maintenance IRQ"); /* Set the GIC as the primary interrupt controller */ @@ -455,7 +455,7 @@ void __init gic_init(void) " gic_vcpu_addr=%"PRIpaddr"\n" " gic_maintenance_irq=%u\n", gic.dbase, gic.cbase, gic.hbase, gic.vbase, - gic.maintenance.irq); + gic.maintenance_irq); if ( (gic.dbase & ~PAGE_MASK) || (gic.cbase & ~PAGE_MASK) || (gic.hbase & ~PAGE_MASK) || (gic.vbase & ~PAGE_MASK) ) @@ -892,8 +892,8 @@ void gic_dump_info(struct vcpu *v) void __cpuinit init_maintenance_interrupt(void) { - request_dt_irq(&gic.maintenance, maintenance_interrupt, - "irq-maintenance", NULL); + request_irq(gic.maintenance_irq, maintenance_interrupt, + "irq-maintenance", NULL); } /* diff --git a/xen/arch/arm/irq.c b/xen/arch/arm/irq.c index a56ccf2..49717f8 100644 --- a/xen/arch/arm/irq.c +++ b/xen/arch/arm/irq.c @@ -114,9 +114,9 @@ static inline struct domain *irq_get_domain(struct irq_desc *desc) return desc->action->dev_id; } -int request_dt_irq(const struct dt_irq *irq, - void (*handler)(int, void *, struct cpu_user_regs *), - const char *devname, void *dev_id) +int request_irq(unsigned int irq, + void (*handler)(int, void *, struct cpu_user_regs *), + const char *devname, void *dev_id) { struct irqaction *action; int retval; @@ -127,13 +127,13 @@ int request_dt_irq(const struct dt_irq *irq, * which interrupt is which (messes up the interrupt freeing * logic etc). */ - if (irq->irq >= nr_irqs) + if ( irq >= nr_irqs ) return -EINVAL; - if (!handler) + if ( !handler ) return -EINVAL; action = xmalloc(struct irqaction); - if (!action) + if ( !action ) return -ENOMEM; action->handler = handler; @@ -141,8 +141,8 @@ int request_dt_irq(const struct dt_irq *irq, action->dev_id = dev_id; action->free_on_release = 1; - retval = setup_dt_irq(irq, action); - if (retval) + retval = setup_irq(irq, action); + if ( retval ) xfree(action); return retval; @@ -249,14 +249,14 @@ static int __setup_irq(struct irq_desc *desc, struct irqaction *new) return 0; } -int setup_dt_irq(const struct dt_irq *irq, struct irqaction *new) +int setup_irq(unsigned int irq, struct irqaction *new) { int rc; unsigned long flags; struct irq_desc *desc; bool_t disabled = 0; - desc = irq_to_desc(irq->irq); + desc = irq_to_desc(irq); spin_lock_irqsave(&desc->lock, flags); @@ -266,7 +266,7 @@ int setup_dt_irq(const struct dt_irq *irq, struct irqaction *new) spin_unlock_irqrestore(&desc->lock, flags); printk(XENLOG_ERR "ERROR: IRQ %u is already in use by the domain %u\n", - irq->irq, d->domain_id); + irq, d->domain_id); return -EBUSY; } @@ -286,7 +286,6 @@ int setup_dt_irq(const struct dt_irq *irq, struct irqaction *new) * TODO: Handle case where SPI is setup on different CPU than * the targeted CPU and the priority. */ - desc->arch.type = irq->type; gic_route_irq_to_xen(desc, cpumask_of(smp_processor_id()), GIC_PRI_IRQ); desc->handler->startup(desc); diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index ce96337..c4adfe4 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -48,13 +48,13 @@ uint64_t __read_mostly boot_count; * register-mapped time source in the SoC. */ unsigned long __read_mostly cpu_khz; /* CPU clock frequency in kHz. */ -static struct dt_irq timer_irq[MAX_TIMER_PPI]; +static int timer_irq[MAX_TIMER_PPI]; unsigned int timer_get_irq(enum timer_ppi ppi) { ASSERT(ppi >= TIMER_PHYS_SECURE_PPI && ppi < MAX_TIMER_PPI); - return timer_irq[ppi].irq; + return timer_irq[ppi]; } /*static inline*/ s_time_t ticks_to_ns(uint64_t ticks) @@ -120,15 +120,15 @@ int __init init_xen_time(void) /* Retrieve all IRQs for the timer */ for ( i = TIMER_PHYS_SECURE_PPI; i < MAX_TIMER_PPI; i++ ) { - res = dt_device_get_irq(dev, i, &timer_irq[i]); - if ( res ) + timer_irq[i] = platform_get_irq(dev, i); + if ( !timer_irq[i] ) panic("Timer: Unable to retrieve IRQ %u from the device tree", i); } printk("Generic Timer IRQ: phys=%u hyp=%u virt=%u\n", - timer_irq[TIMER_PHYS_NONSECURE_PPI].irq, - timer_irq[TIMER_HYP_PPI].irq, - timer_irq[TIMER_VIRT_PPI].irq); + timer_irq[TIMER_PHYS_NONSECURE_PPI], + timer_irq[TIMER_HYP_PPI], + timer_irq[TIMER_VIRT_PPI]); res = platform_init_time(); if ( res ) @@ -192,7 +192,7 @@ int reprogram_timer(s_time_t timeout) /* Handle the firing timer */ static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) { - if ( irq == (timer_irq[TIMER_HYP_PPI].irq) && + if ( irq == (timer_irq[TIMER_HYP_PPI]) && READ_SYSREG32(CNTHP_CTL_EL2) & CNTx_CTL_PENDING ) { /* Signal the generic timer code to do its work */ @@ -201,7 +201,7 @@ static void timer_interrupt(int irq, void *dev_id, struct cpu_user_regs *regs) WRITE_SYSREG32(0, CNTHP_CTL_EL2); } - if ( irq == (timer_irq[TIMER_PHYS_NONSECURE_PPI].irq) && + if ( irq == (timer_irq[TIMER_PHYS_NONSECURE_PPI]) && READ_SYSREG32(CNTP_CTL_EL0) & CNTx_CTL_PENDING ) { /* Signal the generic timer code to do its work */ @@ -235,12 +235,12 @@ void __cpuinit init_timer_interrupt(void) WRITE_SYSREG32(0, CNTHP_CTL_EL2); /* Hypervisor's timer disabled */ isb(); - request_dt_irq(&timer_irq[TIMER_HYP_PPI], timer_interrupt, - "hyptimer", NULL); - request_dt_irq(&timer_irq[TIMER_VIRT_PPI], vtimer_interrupt, + request_irq(timer_irq[TIMER_HYP_PPI], timer_interrupt, + "hyptimer", NULL); + request_irq(timer_irq[TIMER_VIRT_PPI], vtimer_interrupt, "virtimer", NULL); - request_dt_irq(&timer_irq[TIMER_PHYS_NONSECURE_PPI], timer_interrupt, - "phytimer", NULL); + request_irq(timer_irq[TIMER_PHYS_NONSECURE_PPI], timer_interrupt, + "phytimer", NULL); } /* Wait a set number of microseconds */ diff --git a/xen/drivers/char/exynos4210-uart.c b/xen/drivers/char/exynos4210-uart.c index 370539c..0f77300 100644 --- a/xen/drivers/char/exynos4210-uart.c +++ b/xen/drivers/char/exynos4210-uart.c @@ -30,7 +30,7 @@ static struct exynos4210_uart { unsigned int baud, clock_hz, data_bits, parity, stop_bits; - struct dt_irq irq; + unsigned int irq; void *regs; struct irqaction irqaction; struct vuart_info vuart; @@ -197,9 +197,9 @@ static void __init exynos4210_uart_init_postirq(struct serial_port *port) uart->irqaction.name = "exynos4210_uart"; uart->irqaction.dev_id = port; - if ( (rc = setup_dt_irq(&uart->irq, &uart->irqaction)) != 0 ) + if ( (rc = setup_irq(uart->irq, &uart->irqaction)) != 0 ) dprintk(XENLOG_ERR, "Failed to allocated exynos4210_uart IRQ %d\n", - uart->irq.irq); + uart->irq); /* Unmask interrupts */ exynos4210_write(uart, UINTM, ~UINTM_ALLI); @@ -272,7 +272,7 @@ static int __init exynos4210_uart_irq(struct serial_port *port) { struct exynos4210_uart *uart = port->uart; - return uart->irq.irq; + return uart->irq; } static const struct vuart_info *exynos4210_vuart_info(struct serial_port *port) @@ -323,11 +323,11 @@ static int __init exynos4210_uart_init(struct dt_device_node *dev, return res; } - res = dt_device_get_irq(dev, 0, &uart->irq); - if ( res ) + uart->irq = platform_get_irq(dev, 0); + if ( !uart->irq ) { printk("exynos4210: Unable to retrieve the IRQ\n"); - return res; + return -EINVAL; } uart->regs = ioremap_nocache(addr, size); diff --git a/xen/drivers/char/ns16550.c b/xen/drivers/char/ns16550.c index cc86921..78e3aab 100644 --- a/xen/drivers/char/ns16550.c +++ b/xen/drivers/char/ns16550.c @@ -76,9 +76,6 @@ static struct ns16550 { u8 bar_idx; bool_t enable_ro; /* Make MMIO devices read only to Dom0 */ #endif -#ifdef HAS_DEVICE_TREE - struct dt_irq dt_irq; -#endif } ns16550_com[2] = { { 0 } }; struct ns16550_config_mmio { @@ -589,13 +586,8 @@ static void __init ns16550_init_postirq(struct serial_port *port) uart->irqaction.handler = ns16550_interrupt; uart->irqaction.name = "ns16550"; uart->irqaction.dev_id = port; -#ifdef HAS_DEVICE_TREE - if ( (rc = setup_dt_irq(&uart->dt_irq, &uart->irqaction)) != 0 ) - printk("ERROR: Failed to allocate ns16550 DT IRQ.\n"); -#else if ( (rc = setup_irq(uart->irq, &uart->irqaction)) != 0 ) printk("ERROR: Failed to allocate ns16550 IRQ %d\n", uart->irq); -#endif } ns16550_setup_postirq(uart); @@ -1147,12 +1139,9 @@ static int __init ns16550_uart_dt_init(struct dt_device_node *dev, if ( uart->reg_width != 1 && uart->reg_width != 4 ) return -EINVAL; - res = dt_device_get_irq(dev, 0, &uart->dt_irq); - if ( res ) - return res; - - /* The common bit of the driver mostly deals with irq not dt_irq. */ - uart->irq = uart->dt_irq.irq; + uart->irq = platform_get_irq(dev, 0); + if ( !uart->irq ) + return -EINVAL; uart->dw_usr_bsy = dt_device_is_compatible(dev, "snps,dw-apb-uart"); diff --git a/xen/drivers/char/omap-uart.c b/xen/drivers/char/omap-uart.c index b8da509..c2d513b 100644 --- a/xen/drivers/char/omap-uart.c +++ b/xen/drivers/char/omap-uart.c @@ -30,7 +30,7 @@ static struct omap_uart { u32 baud, clock_hz, data_bits, parity, stop_bits, fifo_size; - struct dt_irq irq; + unsigned int irq; char __iomem *regs; struct irqaction irqaction; struct vuart_info vuart; @@ -205,10 +205,10 @@ static void __init omap_uart_init_postirq(struct serial_port *port) uart->irqaction.name = "omap_uart"; uart->irqaction.dev_id = port; - if ( setup_dt_irq(&uart->irq, &uart->irqaction) != 0 ) + if ( setup_irq(uart->irq, &uart->irqaction) != 0 ) { dprintk(XENLOG_ERR, "Failed to allocated omap_uart IRQ %d\n", - uart->irq.irq); + uart->irq); return; } @@ -259,7 +259,7 @@ static int __init omap_uart_irq(struct serial_port *port) { struct omap_uart *uart = port->uart; - return ((uart->irq.irq > 0) ? uart->irq.irq : -1); + return ((uart->irq > 0) ? uart->irq : -1); } static const struct vuart_info *omap_vuart_info(struct serial_port *port) @@ -317,11 +317,11 @@ static int __init omap_uart_init(struct dt_device_node *dev, return res; } - res = dt_device_get_irq(dev, 0, &uart->irq); - if ( res ) + uart->irq = platform_get_irq(dev, 0); + if ( !uart->irq ) { printk("omap-uart: Unable to retrieve the IRQ\n"); - return res; + return -EINVAL; } uart->regs = ioremap_nocache(addr, size); diff --git a/xen/drivers/char/pl011.c b/xen/drivers/char/pl011.c index 459e686..acf2bbc 100644 --- a/xen/drivers/char/pl011.c +++ b/xen/drivers/char/pl011.c @@ -32,7 +32,7 @@ static struct pl011 { unsigned int baud, clock_hz, data_bits, parity, stop_bits; - struct dt_irq irq; + unsigned int irq; void __iomem *regs; /* UART with IRQ line: interrupt-driven I/O. */ struct irqaction irqaction; @@ -132,13 +132,13 @@ static void __init pl011_init_postirq(struct serial_port *port) struct pl011 *uart = port->uart; int rc; - if ( uart->irq.irq > 0 ) + if ( uart->irq > 0 ) { uart->irqaction.handler = pl011_interrupt; uart->irqaction.name = "pl011"; uart->irqaction.dev_id = port; - if ( (rc = setup_dt_irq(&uart->irq, &uart->irqaction)) != 0 ) - printk("ERROR: Failed to allocate pl011 IRQ %d\n", uart->irq.irq); + if ( (rc = setup_irq(uart->irq, &uart->irqaction)) != 0 ) + printk("ERROR: Failed to allocate pl011 IRQ %d\n", uart->irq); } /* Clear pending error interrupts */ @@ -186,7 +186,8 @@ static int pl011_getc(struct serial_port *port, char *pc) static int __init pl011_irq(struct serial_port *port) { struct pl011 *uart = port->uart; - return ((uart->irq.irq > 0) ? uart->irq.irq : -1); + + return ((uart->irq > 0) ? uart->irq : -1); } static const struct vuart_info *pl011_vuart(struct serial_port *port) @@ -239,11 +240,11 @@ static int __init pl011_uart_init(struct dt_device_node *dev, return res; } - res = dt_device_get_irq(dev, 0, &uart->irq); - if ( res ) + uart->irq = platform_get_irq(dev, 0); + if ( !uart->irq ) { printk("pl011: Unable to retrieve the IRQ\n"); - return res; + return -EINVAL; } uart->regs = ioremap_nocache(addr, size); diff --git a/xen/include/asm-arm/irq.h b/xen/include/asm-arm/irq.h index 107c13a..ad2cc18 100644 --- a/xen/include/asm-arm/irq.h +++ b/xen/include/asm-arm/irq.h @@ -40,11 +40,6 @@ void do_IRQ(struct cpu_user_regs *regs, unsigned int irq, int is_fiq); void init_IRQ(void); void init_secondary_IRQ(void); -int request_dt_irq(const struct dt_irq *irq, - void (*handler)(int, void *, struct cpu_user_regs *), - const char *devname, void *dev_id); -int setup_dt_irq(const struct dt_irq *irq, struct irqaction *new); - int route_dt_irq_to_guest(struct domain *d, const struct dt_irq *irq, const char *devname); unsigned int platform_get_irq(const struct dt_device_node *device,