From patchwork Fri May 9 15:07:41 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 29909 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-oa0-f71.google.com (mail-oa0-f71.google.com [209.85.219.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id BD674202FE for ; Fri, 9 May 2014 15:09:24 +0000 (UTC) Received: by mail-oa0-f71.google.com with SMTP id m1sf20636740oag.6 for ; Fri, 09 May 2014 08:09:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=n79wwW4e6yfH3CP9s12RS2nme0QeOr1o/iUxwlaZTi4=; b=QX4EPAvE2nEUU7mnXXZeDyabbNgVSuzzmzEFXWqQ3X3tLpIqGLmWxRxnKNi788TfpC ZvmE7s9QVYAkirdXjPiw3GKUnYSOfixomsPs8ozLbLFm8G+zX08OJPmfP4C2kTHXfiq/ a2/MlzYRjEmsvxIDrYWdm8SDnGtyek9lsqVlZzUTMiD34LGgtSWmW0UBlwJLt57zDjKK KiOt1Cl1WkFjZk2eSygBlDAf7FtMKO6/5A+NBhf/a6VuXisovZdRYZMnJOJOAxgqTo6M RhJh+Ajw+Vtw5idyCzVMq5YEiPehWDSOSShgyqZHaEYhpmFVAxazslazI96kZZoSdKVV KzGg== X-Gm-Message-State: ALoCoQlqWKbzK22CQsl3fjW7S39kw1/urHTljk5+FuZLybcVUAW5yg4oXqTxvaGwgyXGqRoPRux0 X-Received: by 10.182.241.9 with SMTP id we9mr5431176obc.22.1399648164281; Fri, 09 May 2014 08:09:24 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.109.200 with SMTP id l66ls356153qgf.33.gmail; Fri, 09 May 2014 08:09:24 -0700 (PDT) X-Received: by 10.58.160.134 with SMTP id xk6mr961400veb.64.1399648164055; Fri, 09 May 2014 08:09:24 -0700 (PDT) Received: from mail-vc0-f173.google.com (mail-vc0-f173.google.com [209.85.220.173]) by mx.google.com with ESMTPS id j20si769111vcx.127.2014.05.09.08.09.24 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 09 May 2014 08:09:24 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) client-ip=209.85.220.173; Received: by mail-vc0-f173.google.com with SMTP id il7so5394289vcb.18 for ; Fri, 09 May 2014 08:09:24 -0700 (PDT) X-Received: by 10.52.2.229 with SMTP id 5mr7441256vdx.24.1399648163967; Fri, 09 May 2014 08:09:23 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.220.221.72 with SMTP id ib8csp88474vcb; Fri, 9 May 2014 08:09:23 -0700 (PDT) X-Received: by 10.220.69.72 with SMTP id y8mr8865475vci.21.1399648163506; Fri, 09 May 2014 08:09:23 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id qr10si766525vcb.189.2014.05.09.08.09.22 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 09 May 2014 08:09:23 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WimOq-0007I3-Kp; Fri, 09 May 2014 15:07:48 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WimOo-0007HT-Vq for xen-devel@lists.xen.org; Fri, 09 May 2014 15:07:47 +0000 Received: from [193.109.254.147:33793] by server-14.bemta-14.messagelabs.com id A8/7A-08195-24FEC635; Fri, 09 May 2014 15:07:46 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-16.tower-27.messagelabs.com!1399648064!3799604!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 860 invoked from network); 9 May 2014 15:07:45 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-16.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 9 May 2014 15:07:45 -0000 X-IronPort-AV: E=Sophos; i="4.97,1018,1389744000"; d="scan'208"; a="128521060" Received: from accessns.citrite.net (HELO FTLPEX01CL01.citrite.net) ([10.9.154.239]) by FTLPIPO02.CITRIX.COM with ESMTP; 09 May 2014 15:07:44 +0000 Received: from kazak.uk.xensource.com (10.80.2.80) by FTLPEX01CL01.citrite.net (10.13.107.78) with Microsoft SMTP Server id 14.3.181.6; Fri, 9 May 2014 11:07:42 -0400 Message-ID: <1399648061.561.47.camel@kazak.uk.xensource.com> From: Ian Campbell To: Stefano Stabellini Date: Fri, 9 May 2014 16:07:41 +0100 In-Reply-To: References: <1397739444-31407-1-git-send-email-ian.campbell@citrix.com> <1397739457-25541-1-git-send-email-ian.campbell@citrix.com> <1398340990.18537.342.camel@kazak.uk.xensource.com> <1398677229.29700.11.camel@kazak.uk.xensource.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.1-1 MIME-Version: 1.0 X-Originating-IP: [10.80.2.80] X-DLP: MIA1 Cc: julien.grall@linaro.org, tim@xen.org, xen-devel@lists.xen.org, David Vrabel , Boris Ostrovsky Subject: Re: [Xen-devel] [PATCH linux v3] arm: xen: implement multicall hypercall support. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Fri, 2014-05-09 at 15:56 +0100, Stefano Stabellini wrote: > On Mon, 28 Apr 2014, Ian Campbell wrote: > > On Fri, 2014-04-25 at 18:17 +0100, Stefano Stabellini wrote: > > > > > diff --git a/arch/arm64/xen/hypercall.S b/arch/arm64/xen/hypercall.S > > > > > index 531342e..8bbe940 100644 > > > > > --- a/arch/arm64/xen/hypercall.S > > > > > +++ b/arch/arm64/xen/hypercall.S > > > > > @@ -80,6 +80,7 @@ HYPERCALL2(memory_op); > > > > > HYPERCALL2(physdev_op); > > > > > HYPERCALL3(vcpu_op); > > > > > HYPERCALL1(tmem_op); > > > > > +HYPERCALL2(multicall); > > > > > > > > > > ENTRY(privcmd_call) > > > > > mov x16, x0 > > > > > > You need to add an EXPORT_SYMBOL_GPL for it in arch/arm/xen/enlighten.c. > > > > HYPERVISOR_multicall is not currently exported for x86 either. I think > > we should go with this existing patch and sort out the exports > > consistently across arch/* in a followup. > > HYPERVISOR_multicall doesn't need to be exported on x86 because it is > defined as a static inline function. Oh, of course. Here is the fix. Feel free to fold this into the existing commit if you prefer. 8<------------------------- >From 40542140ca071039b2c448e53d7536a3b3134028 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Fri, 9 May 2014 16:06:21 +0100 Subject: [PATCH] arm: xen: export HYPERVISOR_multicall to modules. "arm: xen: implement multicall hypercall support." forgot to do this. Signed-off-by: Ian Campbell --- arch/arm/xen/enlighten.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/xen/enlighten.c b/arch/arm/xen/enlighten.c index b96723e..488ecdb 100644 --- a/arch/arm/xen/enlighten.c +++ b/arch/arm/xen/enlighten.c @@ -350,4 +350,5 @@ EXPORT_SYMBOL_GPL(HYPERVISOR_memory_op); EXPORT_SYMBOL_GPL(HYPERVISOR_physdev_op); EXPORT_SYMBOL_GPL(HYPERVISOR_vcpu_op); EXPORT_SYMBOL_GPL(HYPERVISOR_tmem_op); +EXPORT_SYMBOL_GPL(HYPERVISOR_multicall); EXPORT_SYMBOL_GPL(privcmd_call);