From patchwork Tue Jun 17 15:26:45 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 32077 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ig0-f199.google.com (mail-ig0-f199.google.com [209.85.213.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id A526F206A0 for ; Tue, 17 Jun 2014 15:28:45 +0000 (UTC) Received: by mail-ig0-f199.google.com with SMTP id h18sf16458048igc.2 for ; Tue, 17 Jun 2014 08:28:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=JoHVwnIz9F8KTd03mV++Ev5+mKCJy1C8A/IxNJZgh9Q=; b=QrNeecP9RihMUSyNFaTDaUI4IsLGk9K7GnorTGlwokSe41G8ygF4edSexx2+orf3TQ Zp1tnVkeIEJwvCDdnLRR2X0OA7H4DOn4iytrfWJDVLYpfrfx1pXStI53jKYT1Xa8llGW +aJLA0UQQlIvYOIpMVDtaubCLQ8E8lZJT8wIKpRTowqavo/u59p735cfgTyDluIXji8N GUUQ8aULyQddpkssIEP3hmAG+jR923AwMucnMB4zCnJ0qUWFl/R1ciYJ95yh1i2Ck+Hw gonGBLjo4A8LM+zPjOs3tQFNWvrgeMOapPuBtNywoSu17B5Fg3AOCC+N+WpMKemWPLzA 4mVg== X-Gm-Message-State: ALoCoQki7PSClKM5a334wi9wLHr8rTUMk+zdYkqXL1Z2HPfCd/Wi9ruWQouqvVezuOQ7Mr0gitVT X-Received: by 10.42.36.10 with SMTP id s10mr547813icd.5.1403018925019; Tue, 17 Jun 2014 08:28:45 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.145 with SMTP id f17ls4680089qgd.95.gmail; Tue, 17 Jun 2014 08:28:44 -0700 (PDT) X-Received: by 10.58.67.198 with SMTP id p6mr991787vet.65.1403018924928; Tue, 17 Jun 2014 08:28:44 -0700 (PDT) Received: from mail-ve0-f173.google.com (mail-ve0-f173.google.com [209.85.128.173]) by mx.google.com with ESMTPS id tr2si5591203vdc.101.2014.06.17.08.28.44 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 17 Jun 2014 08:28:44 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.173 as permitted sender) client-ip=209.85.128.173; Received: by mail-ve0-f173.google.com with SMTP id db11so7839358veb.32 for ; Tue, 17 Jun 2014 08:28:44 -0700 (PDT) X-Received: by 10.220.163.3 with SMTP id y3mr22633182vcx.7.1403018924844; Tue, 17 Jun 2014 08:28:44 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.54.6 with SMTP id vs6csp218029vcb; Tue, 17 Jun 2014 08:28:44 -0700 (PDT) X-Received: by 10.42.80.8 with SMTP id t8mr28433955ick.56.1403018924279; Tue, 17 Jun 2014 08:28:44 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id o8si26196463ick.58.2014.06.17.08.28.43 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 17 Jun 2014 08:28:44 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwvHl-0006Go-4R; Tue, 17 Jun 2014 15:26:57 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1WwvHj-0006EQ-I9 for xen-devel@lists.xen.org; Tue, 17 Jun 2014 15:26:55 +0000 Received: from [193.109.254.147:17066] by server-9.bemta-14.messagelabs.com id EA/7B-03644-E3E50A35; Tue, 17 Jun 2014 15:26:54 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-15.tower-27.messagelabs.com!1403018810!11891033!3 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 4834 invoked from network); 17 Jun 2014 15:26:54 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 17 Jun 2014 15:26:54 -0000 X-IronPort-AV: E=Sophos;i="5.01,494,1400025600"; d="scan'208";a="144521863" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP; 17 Jun 2014 15:26:51 +0000 Received: from ukmail1.uk.xensource.com (10.80.16.128) by smtprelay.citrix.com (10.13.107.79) with Microsoft SMTP Server id 14.3.181.6; Tue, 17 Jun 2014 11:26:50 -0400 Received: from kazak.uk.xensource.com ([10.80.2.80] helo=kazak.uk.xensource.com.) by ukmail1.uk.xensource.com with esmtp (Exim 4.69) (envelope-from ) id 1WwvHe-00010t-5Y; Tue, 17 Jun 2014 16:26:50 +0100 From: Ian Campbell To: Date: Tue, 17 Jun 2014 16:26:45 +0100 Message-ID: <1403018809-25509-5-git-send-email-ian.campbell@citrix.com> X-Mailer: git-send-email 1.9.0 In-Reply-To: <1403018758.25074.5.camel@kazak.uk.xensource.com> References: <1403018758.25074.5.camel@kazak.uk.xensource.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: Ian Campbell , xen-devel@lists.xen.org Subject: [Xen-devel] [PATCH RFC OSSTEST 5/9] TestSupport: guest_create takes a $ho. X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.128.173 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Add looks up the toolstack from it. This is now consistent with guest_destroy. Signed-off-by: Ian Campbell --- Osstest/TestSupport.pm | 5 +++-- ts-debian-hvm-install | 7 ++----- ts-redhat-install | 7 ++----- 3 files changed, 7 insertions(+), 12 deletions(-) diff --git a/Osstest/TestSupport.pm b/Osstest/TestSupport.pm index 11a036f..1444629 100644 --- a/Osstest/TestSupport.pm +++ b/Osstest/TestSupport.pm @@ -1278,8 +1278,9 @@ sub guest_destroy ($$) { } sub guest_create ($$) { - my ($gho,$toolstack) = @_; - target_cmd_root($gho->{Host}, "$toolstack create $gho->{CfgPath}", 100); + my ($ho,$gho) = @_; + my $ts= toolstack($ho); + target_cmd_root($ho, $ts->{Command}." create $gho->{CfgPath}", 100); } diff --git a/ts-debian-hvm-install b/ts-debian-hvm-install index 0148eef..f274630 100755 --- a/ts-debian-hvm-install +++ b/ts-debian-hvm-install @@ -41,9 +41,6 @@ our $disk_mb= 10000; our $guesthost= "$gn.guest.osstest"; our $gho; -our $toolstack= toolstack($ho)->{Command}; - - sub preseed () { my $preseed_file = preseed_base('wheezy','',()); @@ -183,7 +180,7 @@ logm("Host has $host_freemem_mb MB free memory, setting guest memory size to $ra if (!$stage) { prep(); - guest_create($gho,$toolstack); + guest_create($ho,$gho); } else { $gho= selectguest($gn,$gho); } @@ -193,6 +190,6 @@ if ($stage<2) { } guest_editconfig_nocd($gho,$emptyiso); -guest_create($gho,$toolstack); +guest_create($ho,$gho); guest_await_dhcp_tcp($gho,300); guest_check_up($gho); diff --git a/ts-redhat-install b/ts-redhat-install index a0b1fab..0b4ee17 100755 --- a/ts-redhat-install +++ b/ts-redhat-install @@ -37,9 +37,6 @@ our $disk_mb= 50000; our $guesthost= "$gn.guest.osstest"; our $gho; -our $xl= toolstack($ho)->{Command}; - - sub kickstart () { my $cryptpw= '$6$anjRJmBbJcrNJGWN$rqvGUhu8ITjvErdIA5C//w2R6b/6wAjHbaF7XF8u3lZg1XI3StthPIE6UII08scOFwASMOepCGpgtsYeCpjqb.'; my $authkeys= authorized_keys(); @@ -152,7 +149,7 @@ sub prep () { if (!$stage) { prep(); - guest_create($gho,$xl); + guest_create($ho,$gho); } else { $gho= selectguest($gn,$gho); } @@ -162,6 +159,6 @@ if ($stage<2) { } guest_editconfig_nocd($gho,$emptyiso); -guest_create($gho,$xl); +guest_create($ho,$gho); guest_await_dhcp_tcp($gho,300); guest_check_up($gho);