From patchwork Fri Jul 11 13:43:47 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 33492 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-ob0-f197.google.com (mail-ob0-f197.google.com [209.85.214.197]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 9AE19203C0 for ; Fri, 11 Jul 2014 13:45:46 +0000 (UTC) Received: by mail-ob0-f197.google.com with SMTP id uz6sf5448767obc.4 for ; Fri, 11 Jul 2014 06:45:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=jMOHNbXhRXnlFX2WpfQfAbNaIZ2mQcwv4hQIm68kHTU=; b=TynAmEnRbfSnnzlfHEn7b1sf+MMP+MPZqKvfN3O7KBTqG9vpzk11AN/WJ+0Y/az6RN M3CN1CkTfzHH/XD2X9aSKHmvJvP/Z5Ndw27iltV3eyPIVOo4EnpqvhEQBxcsjgeuHzoO +uGchpIs71b3Rkr6u0KUwGel1w4IzwK88QstLeggoQF51o6UfbNtfEU7pqbTXlBHJbcz tseLdmnyhry6GGcaqAJ4goRu5iEP1KT78NvXDld59MHMobx5EReDzy8Ily/buWv7INR1 7WoobvrR1dKkHMCpTi6Ebpfjp+1yO34sPEmGyf0JcVXeJBhvQaKy4rCxfLyEPxj39uop 9Shg== X-Gm-Message-State: ALoCoQmE9dGccj6fxlczp3wG4WKRUSz3rIO57xn1a/FmbH5XSgxBQCl6LNskcvpg3hNCzlSqgsiH X-Received: by 10.182.68.16 with SMTP id r16mr25143273obt.26.1405086346183; Fri, 11 Jul 2014 06:45:46 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.140.81.106 with SMTP id e97ls378232qgd.43.gmail; Fri, 11 Jul 2014 06:45:46 -0700 (PDT) X-Received: by 10.52.170.211 with SMTP id ao19mr178144vdc.89.1405086346091; Fri, 11 Jul 2014 06:45:46 -0700 (PDT) Received: from mail-vc0-f175.google.com (mail-vc0-f175.google.com [209.85.220.175]) by mx.google.com with ESMTPS id l3si1526030vdv.50.2014.07.11.06.45.46 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 11 Jul 2014 06:45:46 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.175 as permitted sender) client-ip=209.85.220.175; Received: by mail-vc0-f175.google.com with SMTP id hy4so2055105vcb.20 for ; Fri, 11 Jul 2014 06:45:46 -0700 (PDT) X-Received: by 10.52.144.235 with SMTP id sp11mr27057965vdb.25.1405086345431; Fri, 11 Jul 2014 06:45:45 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.221.37.5 with SMTP id tc5csp36500vcb; Fri, 11 Jul 2014 06:45:45 -0700 (PDT) X-Received: by 10.50.126.7 with SMTP id mu7mr4704808igb.20.1405086344762; Fri, 11 Jul 2014 06:45:44 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id ih4si3545012igb.48.2014.07.11.06.45.43 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 11 Jul 2014 06:45:44 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X5b7D-00059m-Q3; Fri, 11 Jul 2014 13:43:55 +0000 Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1X5b7B-00059Z-Fe for xen-devel@lists.xensource.com; Fri, 11 Jul 2014 13:43:54 +0000 Received: from [85.158.137.68:26041] by server-2.bemta-3.messagelabs.com id F1/DB-14008-81AEFB35; Fri, 11 Jul 2014 13:43:52 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-9.tower-31.messagelabs.com!1405086230!11697376!1 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n X-StarScan-Received: X-StarScan-Version: 6.11.3; banners=-,-,- X-VirusChecked: Checked Received: (qmail 27913 invoked from network); 11 Jul 2014 13:43:51 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-9.tower-31.messagelabs.com with RC4-SHA encrypted SMTP; 11 Jul 2014 13:43:51 -0000 X-IronPort-AV: E=Sophos;i="5.01,643,1400025600"; d="scan'208";a="151763261" Received: from accessns.citrite.net (HELO FTLPEX01CL02.citrite.net) ([10.9.154.239]) by FTLPIPO01.CITRIX.COM with ESMTP; 11 Jul 2014 13:43:51 +0000 Received: from kazak.uk.xensource.com (10.80.2.80) by FTLPEX01CL02.citrite.net (10.13.107.79) with Microsoft SMTP Server id 14.3.181.6; Fri, 11 Jul 2014 09:43:48 -0400 Message-ID: <1405086227.27875.8.camel@kazak.uk.xensource.com> From: Ian Campbell To: Olaf Hering Date: Fri, 11 Jul 2014 14:43:47 +0100 In-Reply-To: <20140711072318.GA21265@aepfle.de> References: <20140711072318.GA21265@aepfle.de> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.2-1 MIME-Version: 1.0 X-Originating-IP: [10.80.2.80] X-DLP: MIA1 Cc: keir@xen.org, Jim Fehlig , xen-devel@lists.xensource.com, "xen.org" , stefano.stabellini@eu.citrix.com Subject: Re: [Xen-devel] [libvirt bisection] complete build-amd64-libvirt X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.220.175 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Fri, 2014-07-11 at 09:23 +0200, Olaf Hering wrote: > On Fri, Jul 11, xen.org wrote: > > > commit 4e7e5e9f7b29ef1c6924116e045a9b2c4bd3ea1a > > Author: Olaf Hering > > Date: Mon Jul 7 17:05:17 2014 +0200 > > > > libxl: add discard support to libxl_device_disk > > This used to work for me. What has changed? > > libxl/libxl_conf.c: In function 'libxlDiskSetDiscard': > libxl/libxl_conf.c:724:19: error: conversion to incomplete type > make[3]: *** [libxl/libvirt_driver_libxl_impl_la-libxl_conf.lo] Error 1 > > 718 static int > 719 libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) > 720 { > 721 if (!x_disk->readwrite) > 722 return 0; > 723 #if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE) > 724 switch ((enum virDomainDiskDiscard)discard) { The enum is declared as typedef enum { .... } virDomainDiskDiscard; So using the enum tag in the cast is wrong. commit 5a2bd4c9171d65a7d2ce836bff5047bccddf10f0 Author: Julio Faracco Date: Sat May 31 21:22:30 2014 -0300 conf: more enum cleanups in "src/conf/domain_conf.h" looks to have converted everything like this. -----8<------------------- >From 2702cbbffd40384571b39bb6da21d76fc7b8ccd6 Mon Sep 17 00:00:00 2001 From: Ian Campbell Date: Fri, 11 Jul 2014 14:38:30 +0100 Subject: [PATCH] libxl: Correct cast to virDomainDiskDiscard enum. This was converted to a typedef in 5a2bd4c9171d "conf: more enum cleanups in "src/conf/domain_conf.h"" causing: libxl/libxl_conf.c: In function 'libxlDiskSetDiscard': libxl/libxl_conf.c:724:19: error: conversion to incomplete type Signed-off-by: Ian Campbell --- src/libxl/libxl_conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/libxl/libxl_conf.c b/src/libxl/libxl_conf.c index 0b4a0b5..f620d47 100644 --- a/src/libxl/libxl_conf.c +++ b/src/libxl/libxl_conf.c @@ -721,7 +721,7 @@ libxlDiskSetDiscard(libxl_device_disk *x_disk, int discard) if (!x_disk->readwrite) return 0; #if defined(LIBXL_HAVE_LIBXL_DEVICE_DISK_DISCARD_ENABLE) - switch ((enum virDomainDiskDiscard)discard) { + switch ((virDomainDiskDiscard)discard) { case VIR_DOMAIN_DISK_DISCARD_DEFAULT: case VIR_DOMAIN_DISK_DISCARD_LAST: break;