From patchwork Tue Nov 4 10:48:44 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ian Campbell X-Patchwork-Id: 40124 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f198.google.com (mail-wi0-f198.google.com [209.85.212.198]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id B7BA9240A6 for ; Tue, 4 Nov 2014 10:50:21 +0000 (UTC) Received: by mail-wi0-f198.google.com with SMTP id n3sf3827482wiv.5 for ; Tue, 04 Nov 2014 02:50:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:message-id:from:to:date:in-reply-to :references:organization:mime-version:cc:subject:precedence:list-id :list-unsubscribe:list-post:list-help:list-subscribe:sender :errors-to:x-original-sender:x-original-authentication-results :mailing-list:list-archive:content-type:content-transfer-encoding; bh=7CwXAkY/KCRU04U8+DY1SMKyLPbso8xwNu3Jv0YKV/0=; b=aXp4ytURa3PUl8Hx2Q7YUiPreMfv0KByx62X5e+Vl7oYLSFzFwwtZvqyzAa5GufAEz gu63aKVR+aO/kGKF8b08L5lpLTkF/t3qvxexwBjan5q/hflWYbBXbk244JJ/tSRgU39O +3h43nImUBdpK8w4p7f7ghD+s1GLcsHek9Vt1dTKk+gv1hIYw3Na4LFOaxCfg16YZCqN 6LZzMwcD4iizqwcPjzJw7m5LdWmpd5vdug0ey8A/lUn4zQuFD/NXL0EDP3O7zuDt0iOg 9ZfqSq/LCrRsbgKSaXpb+JLRFhCkkVz8i7nFO223i4SuiDENgJngzbS/eLKnn7rc2at9 vdmQ== X-Gm-Message-State: ALoCoQnLeVu7Gtr5Tu8uVJ3Svrp0QJBxv3uccFlM46sNXXjqaK4ikUezFcq2axH1380ZMM8HeniM X-Received: by 10.112.97.35 with SMTP id dx3mr245004lbb.20.1415098220846; Tue, 04 Nov 2014 02:50:20 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.28.67 with SMTP id z3ls870397lag.74.gmail; Tue, 04 Nov 2014 02:50:20 -0800 (PST) X-Received: by 10.152.27.1 with SMTP id p1mr52182539lag.55.1415098220675; Tue, 04 Nov 2014 02:50:20 -0800 (PST) Received: from mail-la0-f45.google.com (mail-la0-f45.google.com. [209.85.215.45]) by mx.google.com with ESMTPS id ca5si35265683lad.118.2014.11.04.02.50.20 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 04 Nov 2014 02:50:20 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) client-ip=209.85.215.45; Received: by mail-la0-f45.google.com with SMTP id pn19so634798lab.4 for ; Tue, 04 Nov 2014 02:50:20 -0800 (PST) X-Received: by 10.152.120.199 with SMTP id le7mr35382907lab.67.1415098220589; Tue, 04 Nov 2014 02:50:20 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp95753lbc; Tue, 4 Nov 2014 02:50:19 -0800 (PST) X-Received: by 10.221.20.198 with SMTP id qp6mr25003923vcb.18.1415098219322; Tue, 04 Nov 2014 02:50:19 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id y15si26501vct.59.2014.11.04.02.50.18 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 04 Nov 2014 02:50:19 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XlbfN-0005rC-OJ; Tue, 04 Nov 2014 10:48:49 +0000 Received: from mail6.bemta14.messagelabs.com ([193.109.254.103]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1XlbfN-0005qv-69 for xen-devel@lists.xenproject.org; Tue, 04 Nov 2014 10:48:49 +0000 Received: from [193.109.254.147] by server-3.bemta-14.messagelabs.com id E2/93-02953-01FA8545; Tue, 04 Nov 2014 10:48:48 +0000 X-Env-Sender: Ian.Campbell@citrix.com X-Msg-Ref: server-2.tower-27.messagelabs.com!1415098126!12411930!1 X-Originating-IP: [66.165.176.63] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni42MyA9PiAzMDYwNDg=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.12.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10406 invoked from network); 4 Nov 2014 10:48:47 -0000 Received: from smtp02.citrix.com (HELO SMTP02.CITRIX.COM) (66.165.176.63) by server-2.tower-27.messagelabs.com with RC4-SHA encrypted SMTP; 4 Nov 2014 10:48:47 -0000 X-IronPort-AV: E=Sophos;i="5.07,312,1413244800"; d="scan'208";a="189235144" Message-ID: <1415098124.11486.21.camel@citrix.com> From: Ian Campbell To: Andrew Cooper , Konrad Rzeszutek Wilk Date: Tue, 4 Nov 2014 10:48:44 +0000 In-Reply-To: <5448D1C2.9050700@citrix.com> References: <1413985962-31909-1-git-send-email-dave.scott@citrix.com> <5447BA71.9030405@citrix.com> <1414057369.19198.28.camel@citrix.com> <5448D1C2.9050700@citrix.com> Organization: Citrix Systems, Inc. X-Mailer: Evolution 3.12.7-1 MIME-Version: 1.0 X-DLP: MIA1 Cc: David Scott , wei.liu2@citrix.com, stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com, rob.hoes@citrix.com, euan.harris@citrix.com, xen-devel@lists.xenproject.org Subject: Re: [Xen-devel] [PATCH] libxl: a domain can be dying but not shutdown X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: ian.campbell@citrix.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.45 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: On Thu, 2014-10-23 at 11:00 +0100, Andrew Cooper wrote: > > Did you instead mean this from libxl_types.idl: > > # Valid iff (shutdown||dying). > > # > > # Otherwise set to a value guaranteed not to clash with any valid > > # LIBXL_SHUTDOWN_REASON_* constant. > > ("shutdown_reason", libxl_shutdown_reason), > > ? > > That is the primary comment I was on about. This wasn't tagged for 4.5 but it is a bug fix and the commit log & associated commentary were pretty convincing, so Acked + Applied with the additional hunk below folded in. diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl index ca3f724..f7fc695 100644 --- a/tools/libxl/libxl_types.idl +++ b/tools/libxl/libxl_types.idl @@ -260,7 +260,7 @@ libxl_dominfo = Struct("dominfo",[ ("shutdown", bool), ("dying", bool), - # Valid iff (shutdown||dying). + # Valid iff ->shutdown is true. # # Otherwise set to a value guaranteed not to clash with any valid # LIBXL_SHUTDOWN_REASON_* constant.