From patchwork Tue Nov 18 20:03:51 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 41086 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-lb0-f199.google.com (mail-lb0-f199.google.com [209.85.217.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 5398024035 for ; Tue, 18 Nov 2014 20:05:58 +0000 (UTC) Received: by mail-lb0-f199.google.com with SMTP id n15sf13119146lbi.10 for ; Tue, 18 Nov 2014 12:05:57 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-post:list-help :list-subscribe:mime-version:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive :content-type:content-transfer-encoding; bh=oi8cAYs48pMeax0mGgyohRINFQ323sZ9Tf7wnmQCSX0=; b=ICTpXjppxblURmqqIcI+1LwbzsC6fpZ7OJKJhkh+8Lp9/KncxhpesS8ifUj2BPld5Q cQWkpyRYr1LGJXE4UmaNj6cR7NgoOFuQBaRCUtyw24Jwni6/FRULkUc2EYPGg5Mbgzlw cP9HN4bbzE4MdieM/D3coRZz0hW0euzh6AMoKDZKx5bqblFtJ0etTR4MK4kcXConu1Dx Y5oCza6aZR8Nu5pGr+vkBiSbIlzoMLlRDOLDxIn7BtOVIEXvfD5L5fDtFa1D3PzkCw4v 5HzZFIm0RosugWNFDZL/3CONIH3OH++lYLeDnRiZvCgBlyEueoqhhL+FiYD7aOPNfzOT MODA== X-Gm-Message-State: ALoCoQkiu3YIMl9lglPPhK9/kMOtw364IFpwubseXQx2ciuwOQlYjnq9G5CBCIYte/HF7z2kgUfD X-Received: by 10.181.13.147 with SMTP id ey19mr4366566wid.2.1416341157186; Tue, 18 Nov 2014 12:05:57 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.153.5.6 with SMTP id ci6ls998381lad.30.gmail; Tue, 18 Nov 2014 12:05:56 -0800 (PST) X-Received: by 10.152.207.71 with SMTP id lu7mr1125160lac.81.1416341156885; Tue, 18 Nov 2014 12:05:56 -0800 (PST) Received: from mail-la0-f54.google.com (mail-la0-f54.google.com. [209.85.215.54]) by mx.google.com with ESMTPS id pz8si57032951lbb.36.2014.11.18.12.05.56 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Tue, 18 Nov 2014 12:05:56 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) client-ip=209.85.215.54; Received: by mail-la0-f54.google.com with SMTP id gf13so8482485lab.41 for ; Tue, 18 Nov 2014 12:05:56 -0800 (PST) X-Received: by 10.112.45.102 with SMTP id l6mr1134449lbm.46.1416341156708; Tue, 18 Nov 2014 12:05:56 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.184.201 with SMTP id ew9csp1395666lbc; Tue, 18 Nov 2014 12:05:55 -0800 (PST) X-Received: by 10.52.170.78 with SMTP id ak14mr19045814vdc.60.1416341155222; Tue, 18 Nov 2014 12:05:55 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id s13si27263910vci.17.2014.11.18.12.05.54 for (version=TLSv1 cipher=RC4-SHA bits=128/128); Tue, 18 Nov 2014 12:05:55 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xqp0P-00057r-CB; Tue, 18 Nov 2014 20:04:05 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1Xqp0O-00057m-EV for xen-devel@lists.xenproject.org; Tue, 18 Nov 2014 20:04:04 +0000 Received: from [85.158.139.211] by server-16.bemta-5.messagelabs.com id 9D/BE-29352-336AB645; Tue, 18 Nov 2014 20:04:03 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-4.tower-206.messagelabs.com!1416341042!12115700!1 X-Originating-IP: [209.85.212.176] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.12.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 7583 invoked from network); 18 Nov 2014 20:04:03 -0000 Received: from mail-wi0-f176.google.com (HELO mail-wi0-f176.google.com) (209.85.212.176) by server-4.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 18 Nov 2014 20:04:03 -0000 Received: by mail-wi0-f176.google.com with SMTP id ex7so3142154wid.3 for ; Tue, 18 Nov 2014 12:04:02 -0800 (PST) X-Received: by 10.194.184.199 with SMTP id ew7mr51939056wjc.85.1416341042402; Tue, 18 Nov 2014 12:04:02 -0800 (PST) Received: from belegaer.uk.xensource.com ([185.25.64.249]) by mx.google.com with ESMTPSA id l10sm20816585wif.20.2014.11.18.12.04.00 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 18 Nov 2014 12:04:01 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Tue, 18 Nov 2014 20:03:51 +0000 Message-Id: <1416341031-6204-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 1.7.10.4 Cc: Julien Grall , ian.jackson@eu.citrix.com, ian.campbell@citrix.com, Don Slutz Subject: [Xen-devel] [PATCH for-4.5] scripts/get_maintainer.pl: Correctly CC the maintainers X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.54 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: By default, the script get_maintainer.pl will remove duplicates email as soon as it appends the list of maintainers of a new file, and therefore override the role of the developper. On complex patch (see [1]), this will result to ommitting randomly some maintainers. This could be fixed by not removing the duplicate email in the list. Once the list is created, when it's necessary, the script will drop the "REST" people and remove duplicata. Example: Patch: https://patches.linaro.org/41083/ Before: Daniel De Graaf Ian Jackson Stefano Stabellini Ian Campbell Wei Liu George Dunlap xen-devel@lists.xen.org After: Daniel De Graaf Ian Jackson Stefano Stabellini Ian Campbell Wei Liu Stefano Stabellini Tim Deegan Keir Fraser Jan Beulich George Dunlap xen-devel@lists.xen.org [1] http://lists.xenproject.org/archives/html/xen-devel/2014-11/msg00060.html Signed-off-by: Julien Grall CC: Don Slutz --- I would like to see this patch in Xen 4.5 and backported to Xen 4.4 (first time the script has been introduced). Developpers using this script won't ommitted to cc some maintainers, and it will avoid maintainers complaining about miss CC. The only drawbacks I can see is there is too much people CCed (the patch d67738db was intended to avoid CCing Keir too often). Also, if the maintainers is referenced twice in the file MAINTAINERS with different email, the script won't notice it's duplicated and list 2 times. Though, for this one it could be fixed by modifying the MAINTAINERS file. Is it worth for Xen 4.5? For know, it seems to only happen with Stefano. --- scripts/get_maintainer.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/get_maintainer.pl b/scripts/get_maintainer.pl index df920e2..cc445cd 100755 --- a/scripts/get_maintainer.pl +++ b/scripts/get_maintainer.pl @@ -35,7 +35,7 @@ my $email_git_min_percent = 5; my $email_git_since = "1-year-ago"; my $email_hg_since = "-365"; my $interactive = 0; -my $email_remove_duplicates = 1; +my $email_remove_duplicates = 0; my $email_use_mailmap = 1; my $email_drop_the_rest_supporter_if_supporter_found = 1; my $output_multiline = 1;