From patchwork Fri Jan 16 16:20:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 43254 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id AF4CF240BA for ; Fri, 16 Jan 2015 16:23:10 +0000 (UTC) Received: by mail-wg0-f71.google.com with SMTP id k14sf11612258wgh.2 for ; Fri, 16 Jan 2015 08:23:10 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=xytpMgAfbxnkaYb6SUfYyOrTrhjtmdBqWu+t1Gcq60Y=; b=mg3HEtyMUrqbRnA7t63XiBx2VUoqCOmyMUjCuCDVxF4DEFAsAnlWFemCFzyUcsF+79 N0nm6ibnrEwaB4XquMm1TTXhx0yYevghYc5tsC9WFH1oFjqibaS53CwLbRqKCuKh5u0X tc9zUhCHxZkQ9IAkGD7jGEVztBMgWWzUfIjCdrA+kqK1EXr1VHlVy5VDSXqV3QWndwAR 1lf6Wac8+Hk9fypY081jOQRTCQ18kze9QD99HamJnP5iZ73QaVf8xz9M7yTbTRulOTnH fZMSdS0lXt4me+MZSZRVju02S73aeAjWS5/OHiGxy3t4NYLR6kstT83uzm3D6jfgPtBc dpag== X-Gm-Message-State: ALoCoQmKXdqVzVEtJgs29AONOct887mq1TEGGee7jKCym38UCoE7RhvL9mAOaSLpdaUhzVtAJKQM X-Received: by 10.194.109.129 with SMTP id hs1mr387235wjb.3.1421425389977; Fri, 16 Jan 2015 08:23:09 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.205.98 with SMTP id lf2ls346574lac.16.gmail; Fri, 16 Jan 2015 08:23:09 -0800 (PST) X-Received: by 10.152.7.229 with SMTP id m5mr16709598laa.80.1421425389818; Fri, 16 Jan 2015 08:23:09 -0800 (PST) Received: from mail-lb0-f178.google.com (mail-lb0-f178.google.com. [209.85.217.178]) by mx.google.com with ESMTPS id og3si3492275lbb.6.2015.01.16.08.23.09 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 16 Jan 2015 08:23:09 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) client-ip=209.85.217.178; Received: by mail-lb0-f178.google.com with SMTP id u14so19255593lbd.9 for ; Fri, 16 Jan 2015 08:23:09 -0800 (PST) X-Received: by 10.152.27.8 with SMTP id p8mr9715536lag.69.1421425389692; Fri, 16 Jan 2015 08:23:09 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp361512lbb; Fri, 16 Jan 2015 08:23:08 -0800 (PST) X-Received: by 10.220.124.147 with SMTP id u19mr7997625vcr.48.1421425384916; Fri, 16 Jan 2015 08:23:04 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id h2si1137844vcf.79.2015.01.16.08.23.04 (version=TLSv1 cipher=RC4-SHA bits=128/128); Fri, 16 Jan 2015 08:23:04 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YC9eE-00063Q-8L; Fri, 16 Jan 2015 16:21:22 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YC9eC-00062j-Ce for xen-devel@lists.xenproject.org; Fri, 16 Jan 2015 16:21:20 +0000 Received: from [85.158.139.211] by server-14.bemta-5.messagelabs.com id B6/56-19763-F7A39B45; Fri, 16 Jan 2015 16:21:19 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-14.tower-206.messagelabs.com!1421425279!13090333!1 X-Originating-IP: [74.125.82.179] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.12.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 20980 invoked from network); 16 Jan 2015 16:21:19 -0000 Received: from mail-we0-f179.google.com (HELO mail-we0-f179.google.com) (74.125.82.179) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 16 Jan 2015 16:21:19 -0000 Received: by mail-we0-f179.google.com with SMTP id q59so21096486wes.10 for ; Fri, 16 Jan 2015 08:21:19 -0800 (PST) X-Received: by 10.180.81.7 with SMTP id v7mr7664382wix.74.1421425278950; Fri, 16 Jan 2015 08:21:18 -0800 (PST) Received: from chilopoda.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id dc1sm3562564wib.18.2015.01.16.08.21.17 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Jan 2015 08:21:18 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Fri, 16 Jan 2015 16:20:43 +0000 Message-Id: <1421425248-8727-2-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1421425248-8727-1-git-send-email-julien.grall@linaro.org> References: <1421425248-8727-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH 1/6] arm/setup: Add missing __init to add_boot_module X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.217.178 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: add_boot_module is calling a function which lies in the init section. Furthermore, it's only used during Xen boot. Signed-off-by: Julien Grall --- xen/arch/arm/setup.c | 6 +++--- xen/include/asm-arm/setup.h | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/xen/arch/arm/setup.c b/xen/arch/arm/setup.c index f49569d..5fc27ce0 100644 --- a/xen/arch/arm/setup.c +++ b/xen/arch/arm/setup.c @@ -185,9 +185,9 @@ static void dt_unreserved_regions(paddr_t s, paddr_t e, cb(s, e); } -struct bootmodule *add_boot_module(bootmodule_kind kind, - paddr_t start, paddr_t size, - const char *cmdline) +struct bootmodule __init *add_boot_module(bootmodule_kind kind, + paddr_t start, paddr_t size, + const char *cmdline) { struct bootmodules *mods = &bootinfo.modules; struct bootmodule *mod; diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h index ba5a67d..ed2ba16 100644 --- a/xen/include/asm-arm/setup.h +++ b/xen/include/asm-arm/setup.h @@ -60,10 +60,10 @@ void discard_initial_modules(void); size_t __init boot_fdt_info(const void *fdt, paddr_t paddr); const char __init *boot_fdt_cmdline(const void *fdt); -struct bootmodule *add_boot_module(bootmodule_kind kind, - paddr_t start, paddr_t size, - const char *cmdline); -struct bootmodule *boot_module_find_by_kind(bootmodule_kind kind); +struct bootmodule __init *add_boot_module(bootmodule_kind kind, + paddr_t start, paddr_t size, + const char *cmdline); +struct bootmodule __init *boot_module_find_by_kind(bootmodule_kind kind); const char * __init boot_module_kind_as_string(bootmodule_kind kind); #endif