From patchwork Mon Jan 19 16:29:17 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 43316 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f71.google.com (mail-wg0-f71.google.com [74.125.82.71]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 319A82034D for ; Mon, 19 Jan 2015 16:31:13 +0000 (UTC) Received: by mail-wg0-f71.google.com with SMTP id k14sf17337049wgh.2 for ; Mon, 19 Jan 2015 08:31:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:cc:subject:precedence:list-id:list-unsubscribe:list-post :list-help:list-subscribe:mime-version:content-type :content-transfer-encoding:sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=J7LH3rtt2y9gbdIvLY+kLo6IG1TJafZb6EzgzDH+th8=; b=jpqUEj5NMUWPwU8+WXo47DYAUJQYj2l1vl7CNVIiEdNEYFx4HuJ+TxIsQOGg31ZH5i i06TWU5NLRJID7UoptNWq8uvomq4yDFMbj/WNbXAOe7t3MWVX6rlMGGQe8/BoJAH+BTD /sUPf0gwI/LSoSAd9m4RoVMy9dwpBlIJOqLguwAFiuOOXOmnOL/RJmZrBY+q8r/euwjG 3YOfBNvljOcPuKkjJd1pEapCS8z1hj1PRexlpQpHqxs3EFYEIELI9KXYEeD2e7fdJL9D OmdnNdptARH9IDjhioubILRMfBsmzpoU6wwazPAg0oblM4DGnhwvBwdRtQP01CIDv0Yo 7zUA== X-Gm-Message-State: ALoCoQkcJUapbqLBp3y/J7pK4GFaVu+igIl+BNBquBYq4oS5hrByy0B3OuAR/DT+uHjIp1Sxf+pp X-Received: by 10.180.92.66 with SMTP id ck2mr1994337wib.3.1421685072432; Mon, 19 Jan 2015 08:31:12 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.7.7 with SMTP id f7ls621416laa.100.gmail; Mon, 19 Jan 2015 08:31:12 -0800 (PST) X-Received: by 10.112.166.73 with SMTP id ze9mr32034555lbb.38.1421685072269; Mon, 19 Jan 2015 08:31:12 -0800 (PST) Received: from mail-la0-f52.google.com (mail-la0-f52.google.com. [209.85.215.52]) by mx.google.com with ESMTPS id k12si13845322laa.24.2015.01.19.08.31.12 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 19 Jan 2015 08:31:12 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) client-ip=209.85.215.52; Received: by mail-la0-f52.google.com with SMTP id hs14so29696041lab.11 for ; Mon, 19 Jan 2015 08:31:12 -0800 (PST) X-Received: by 10.152.182.235 with SMTP id eh11mr15020040lac.9.1421685072127; Mon, 19 Jan 2015 08:31:12 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.9.200 with SMTP id c8csp1144427lbb; Mon, 19 Jan 2015 08:31:11 -0800 (PST) X-Received: by 10.220.143.209 with SMTP id w17mr15067714vcu.49.1421685070461; Mon, 19 Jan 2015 08:31:10 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id l9si4725651vcz.56.2015.01.19.08.31.09 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 19 Jan 2015 08:31:10 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDFDL-0006a8-48; Mon, 19 Jan 2015 16:30:07 +0000 Received: from mail6.bemta4.messagelabs.com ([85.158.143.247]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YDFDI-0006Vk-7X for xen-devel@lists.xenproject.org; Mon, 19 Jan 2015 16:30:04 +0000 Received: from [85.158.143.35] by server-3.bemta-4.messagelabs.com id C5/79-15461-B013DB45; Mon, 19 Jan 2015 16:30:03 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-9.tower-21.messagelabs.com!1421685002!22494914!1 X-Originating-IP: [74.125.82.51] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.12.5; banners=-,-,- X-VirusChecked: Checked Received: (qmail 15818 invoked from network); 19 Jan 2015 16:30:02 -0000 Received: from mail-wg0-f51.google.com (HELO mail-wg0-f51.google.com) (74.125.82.51) by server-9.tower-21.messagelabs.com with RC4-SHA encrypted SMTP; 19 Jan 2015 16:30:02 -0000 Received: by mail-wg0-f51.google.com with SMTP id l18so10619882wgh.10 for ; Mon, 19 Jan 2015 08:30:02 -0800 (PST) X-Received: by 10.194.235.165 with SMTP id un5mr62588578wjc.1.1421685002289; Mon, 19 Jan 2015 08:30:02 -0800 (PST) Received: from chilopoda.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id fw6sm14830368wib.1.2015.01.19.08.30.00 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 19 Jan 2015 08:30:00 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 19 Jan 2015 16:29:17 +0000 Message-Id: <1421684957-29884-11-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1421684957-29884-1-git-send-email-julien.grall@linaro.org> References: <1421684957-29884-1-git-send-email-julien.grall@linaro.org> Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH 10/10] xen/arm: vgic-v2: Print the domain/vcpu in each message X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.52 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: Signed-off-by: Julien Grall --- xen/arch/arm/vgic-v2.c | 30 +++++++++++++++++------------- 1 file changed, 17 insertions(+), 13 deletions(-) diff --git a/xen/arch/arm/vgic-v2.c b/xen/arch/arm/vgic-v2.c index 3e5371f..86b4340 100644 --- a/xen/arch/arm/vgic-v2.c +++ b/xen/arch/arm/vgic-v2.c @@ -198,7 +198,7 @@ static int vgic_v2_distr_mmio_read(struct vcpu *v, mmio_info_t *info) case GICD_ICPIDR2: if ( dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled read from ICPIDR2\n"); + gdprintk(XENLOG_ERR, "vGICD: unhandled read from ICPIDR2\n"); return 0; /* Implementation defined -- read as zero */ @@ -215,14 +215,14 @@ static int vgic_v2_distr_mmio_read(struct vcpu *v, mmio_info_t *info) goto read_as_zero; default: - printk("vGICD: unhandled read r%d offset %#08x\n", - dabt.reg, gicd_reg); + gdprintk(XENLOG_ERR, "vGICD: unhandled read r%d offset %#08x\n", + dabt.reg, gicd_reg); return 0; } bad_width: - printk("vGICD: bad read width %d r%d offset %#08x\n", - dabt.size, dabt.reg, gicd_reg); + gdprintk(XENLOG_ERR, "vGICD: bad read width %d r%d offset %#08x\n", + dabt.size, dabt.reg, gicd_reg); domain_crash_synchronous(); return 0; @@ -458,14 +458,16 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info) case GICD_CPENDSGIR ... GICD_CPENDSGIRN: if ( dabt.size != DABT_BYTE && dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ICPENDSGIR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_CPENDSGIR); + gdprintk(XENLOG_ERR, + "vGICD: unhandled %s write %#"PRIregister" to ICPENDSGIR%d\n", + dabt.size ? "word" : "byte", *r, gicd_reg - GICD_CPENDSGIR); return 0; case GICD_SPENDSGIR ... GICD_SPENDSGIRN: if ( dabt.size != DABT_BYTE && dabt.size != DABT_WORD ) goto bad_width; - printk("vGICD: unhandled %s write %#"PRIregister" to ISPENDSGIR%d\n", - dabt.size ? "word" : "byte", *r, gicd_reg - GICD_SPENDSGIR); + gdprintk(XENLOG_ERR, + "vGICD: unhandled %s write %#"PRIregister" to ISPENDSGIR%d\n", + dabt.size ? "word" : "byte", *r, gicd_reg - GICD_SPENDSGIR); return 0; /* Implementation defined -- write ignored */ @@ -490,14 +492,16 @@ static int vgic_v2_distr_mmio_write(struct vcpu *v, mmio_info_t *info) goto write_ignore; default: - printk("vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", - dabt.reg, *r, gicd_reg); + gdprintk(XENLOG_ERR, + "vGICD: unhandled write r%d=%"PRIregister" offset %#08x\n", + dabt.reg, *r, gicd_reg); return 0; } bad_width: - printk("vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", - dabt.size, dabt.reg, *r, gicd_reg); + gdprintk(XENLOG_ERR, + "vGICD: bad write width %d r%d=%"PRIregister" offset %#08x\n", + dabt.size, dabt.reg, *r, gicd_reg); domain_crash_synchronous(); return 0;