From patchwork Mon Mar 2 15:54:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 45298 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wi0-f199.google.com (mail-wi0-f199.google.com [209.85.212.199]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id 167C22149C for ; Mon, 2 Mar 2015 15:58:49 +0000 (UTC) Received: by wibbs8 with SMTP id bs8sf10455114wib.2 for ; Mon, 02 Mar 2015 07:58:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:cc:subject :precedence:list-id:list-unsubscribe:list-post:list-help :list-subscribe:mime-version:content-type:content-transfer-encoding :sender:errors-to:x-original-sender :x-original-authentication-results:mailing-list:list-archive; bh=djGoFzibTPl+t3qePmncoyB8ymSr97p+DZLWt7m0B5I=; b=Wx/b6pBdM1YTRQ8zGppd39jChd0xuph7Ciiz8GblKQfFXem0hUub3VDjZeeUgiqNpl mw41dysGY8JgT5OJYd7r0yl3xaTpbdxLLleKh5MPAEE4Lo1AZixw/oMN9PJTbX19n4wI 7dAlx1tVEW9gpJWcP3cY2SeUNGJ/q6fRuHjH+S35xLKV/iWq0pCne8JVwFDfUFN4vJY7 7Cwvlo0SdKJ4FSirfEAffrGjHED0MfSiEghBqLdotCiCyqQF5Dyf9zxXx6ebcpfs9MAN a5pQIXjcJt53u1SkufIuNw6+9repWYNCVm7vujgfIppuFPJxm1GbzIzN+GVcoUqEdatI sMFw== X-Gm-Message-State: ALoCoQldeMsTjGXIROj/YZYvxX/C9sypL7tMAlDmQo1da/nLmoGWVVZlmMZLUrZNvJosWOobF7B1 X-Received: by 10.180.13.195 with SMTP id j3mr2321816wic.2.1425311928322; Mon, 02 Mar 2015 07:58:48 -0800 (PST) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.179.139 with SMTP id dg11ls464297lac.62.gmail; Mon, 02 Mar 2015 07:58:48 -0800 (PST) X-Received: by 10.112.140.38 with SMTP id rd6mr24668501lbb.116.1425311928152; Mon, 02 Mar 2015 07:58:48 -0800 (PST) Received: from mail-la0-f48.google.com (mail-la0-f48.google.com. [209.85.215.48]) by mx.google.com with ESMTPS id u2si9128653laz.80.2015.03.02.07.58.48 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Mar 2015 07:58:48 -0800 (PST) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) client-ip=209.85.215.48; Received: by labhs14 with SMTP id hs14so31212614lab.1 for ; Mon, 02 Mar 2015 07:58:48 -0800 (PST) X-Received: by 10.152.179.172 with SMTP id dh12mr24248482lac.76.1425311928058; Mon, 02 Mar 2015 07:58:48 -0800 (PST) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.35.133 with SMTP id h5csp5611908lbj; Mon, 2 Mar 2015 07:58:47 -0800 (PST) X-Received: by 10.52.250.6 with SMTP id yy6mr25238222vdc.45.1425311926679; Mon, 02 Mar 2015 07:58:46 -0800 (PST) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id ty6si5538327vcb.49.2015.03.02.07.58.45 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 02 Mar 2015 07:58:46 -0800 (PST) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YSSgs-0005MX-Dn; Mon, 02 Mar 2015 15:55:30 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YSSgr-0005MR-3u for xen-devel@lists.xenproject.org; Mon, 02 Mar 2015 15:55:29 +0000 Received: from [85.158.139.211] by server-4.bemta-5.messagelabs.com id C1/EF-03164-0F784F45; Mon, 02 Mar 2015 15:55:28 +0000 X-Env-Sender: julien.grall@linaro.org X-Msg-Ref: server-14.tower-206.messagelabs.com!1425311727!6977195!1 X-Originating-IP: [74.125.82.50] X-SpamReason: No, hits=0.0 required=7.0 tests= X-StarScan-Received: X-StarScan-Version: 6.13.4; banners=-,-,- X-VirusChecked: Checked Received: (qmail 17443 invoked from network); 2 Mar 2015 15:55:28 -0000 Received: from mail-wg0-f50.google.com (HELO mail-wg0-f50.google.com) (74.125.82.50) by server-14.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 2 Mar 2015 15:55:28 -0000 Received: by wghn12 with SMTP id n12so34405147wgh.1 for ; Mon, 02 Mar 2015 07:55:27 -0800 (PST) X-Received: by 10.180.211.235 with SMTP id nf11mr37700451wic.52.1425311727582; Mon, 02 Mar 2015 07:55:27 -0800 (PST) Received: from chilopoda.uk.xensource.com. ([185.25.64.249]) by mx.google.com with ESMTPSA id fa3sm16569431wib.17.2015.03.02.07.55.26 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 02 Mar 2015 07:55:26 -0800 (PST) From: Julien Grall To: xen-devel@lists.xenproject.org Date: Mon, 2 Mar 2015 15:54:57 +0000 Message-Id: <1425311697-21272-1-git-send-email-julien.grall@linaro.org> X-Mailer: git-send-email 2.1.4 Cc: stefano.stabellini@citrix.com, Julien Grall , tim@xen.org, ian.campbell@citrix.com Subject: [Xen-devel] [PATCH] xen/arm: timer: Don't warn if the timer interrupts are high-level X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , MIME-Version: 1.0 Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: julien.grall@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.48 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: The commit 61d6a84 "xen: arm: Warn if timer interrupts are not level triggered" added a check to ensure the timer interrupts are level. Although, the check is only done on low-level interrupts. This will result to a strange warning on platform using high-level ("WARNING [..] IRQ is not level triggered"). As high-level interrupt is valid, don't warn on both high-level and low-level interrupt. Signed-off-by: Julien Grall --- The Seattle DT is using high-level interrupt. Also I haven't tried to boot the latest Xen on it... --- xen/arch/arm/time.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xen/arch/arm/time.c b/xen/arch/arm/time.c index 8977cce..352e25e 100644 --- a/xen/arch/arm/time.c +++ b/xen/arch/arm/time.c @@ -217,7 +217,7 @@ static void check_timer_irq_cfg(unsigned int irq, const char *which) * The interrupt controller driver will update desc->arch.type with * the actual type which ended up configured in the hardware. */ - if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_LOW ) + if ( desc->arch.type & DT_IRQ_TYPE_LEVEL_MASK ) return; printk(XENLOG_WARNING