From patchwork Thu May 14 17:00:45 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Julien Grall X-Patchwork-Id: 48532 Return-Path: X-Original-To: linaro@patches.linaro.org Delivered-To: linaro@patches.linaro.org Received: from mail-wg0-f69.google.com (mail-wg0-f69.google.com [74.125.82.69]) by ip-10-151-82-157.ec2.internal (Postfix) with ESMTPS id CFA7B21411 for ; Thu, 14 May 2015 17:03:02 +0000 (UTC) Received: by wgtl5 with SMTP id l5sf21421970wgt.1 for ; Thu, 14 May 2015 10:03:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:delivered-to:from:to:date:message-id:in-reply-to :references:mime-version:content-length:cc:subject:precedence :list-id:list-unsubscribe:list-post:list-help:list-subscribe :content-type:content-transfer-encoding:sender:errors-to :x-original-sender:x-original-authentication-results:mailing-list :list-archive; bh=SxP7uRGkXnJT3UQdF34QybAqDj5m9qybHwlkQsV+b/A=; b=fLAVWO9F2P5svpXi/xumTa8Q5YM48fed6Qh9iyN7ui5K/bSmaZKRe+D+8DZgClLlkB x664ECGTPldnmSNwA59cYQOhhTbS08yJyP+BXFofgPU+xlsPwKj83ajdJDZCn+HobfgJ jFGLQvEF1bjr3AANZJ3cAz+pSA2Aa5aUrzL58L3OmtGYxoN7IjcQEcsJsdKwfBXMq/UQ 2E/i1nxFIJl4CyziGwoXkvoY8Ym/t/XDBZnu28oZZ/CtDeJmVSoD4EsbpeSJIsYIXdz/ FNPYDT/CRZuXa8jrrqDQF8q7/X8bxx1bE9bJAcWFnD3TaMu7fYMGCHr+mXNONrs8rTq+ 0qCw== X-Gm-Message-State: ALoCoQkYPauYAL/S58tjbF8kraf94TtWU/u7989JZ2KeFB7tT2CVyucsIX95i3hNjRDu4IKvUcq3 X-Received: by 10.112.142.170 with SMTP id rx10mr3690423lbb.12.1431622982195; Thu, 14 May 2015 10:03:02 -0700 (PDT) X-BeenThere: patchwork-forward@linaro.org Received: by 10.152.5.196 with SMTP id u4ls447656lau.6.gmail; Thu, 14 May 2015 10:03:02 -0700 (PDT) X-Received: by 10.152.120.106 with SMTP id lb10mr439999lab.92.1431622981990; Thu, 14 May 2015 10:03:01 -0700 (PDT) Received: from mail-la0-f51.google.com (mail-la0-f51.google.com. [209.85.215.51]) by mx.google.com with ESMTPS id k7si14930712lbj.50.2015.05.14.10.03.01 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 May 2015 10:03:01 -0700 (PDT) Received-SPF: pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) client-ip=209.85.215.51; Received: by lagv1 with SMTP id v1so76862056lag.3 for ; Thu, 14 May 2015 10:03:01 -0700 (PDT) X-Received: by 10.153.6.36 with SMTP id cr4mr4045002lad.56.1431622981824; Thu, 14 May 2015 10:03:01 -0700 (PDT) X-Forwarded-To: patchwork-forward@linaro.org X-Forwarded-For: patch@linaro.org patchwork-forward@linaro.org Delivered-To: patch@linaro.org Received: by 10.112.108.230 with SMTP id hn6csp1404726lbb; Thu, 14 May 2015 10:03:00 -0700 (PDT) X-Received: by 10.141.18.202 with SMTP id u193mr6904105qhd.16.1431622978604; Thu, 14 May 2015 10:02:58 -0700 (PDT) Received: from lists.xen.org (lists.xen.org. [50.57.142.19]) by mx.google.com with ESMTPS id j110si23654582qge.78.2015.05.14.10.02.57 (version=TLSv1 cipher=RC4-SHA bits=128/128); Thu, 14 May 2015 10:02:58 -0700 (PDT) Received-SPF: none (google.com: xen-devel-bounces@lists.xen.org does not designate permitted sender hosts) client-ip=50.57.142.19; Received: from localhost ([127.0.0.1] helo=lists.xen.org) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YswW4-0000aN-GY; Thu, 14 May 2015 17:01:48 +0000 Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xen.org with esmtp (Exim 4.72) (envelope-from ) id 1YswW2-0000ZK-M1 for xen-devel@lists.xenproject.org; Thu, 14 May 2015 17:01:46 +0000 Received: from [85.158.139.211] by server-11.bemta-5.messagelabs.com id A4/49-02789-9F4D4555; Thu, 14 May 2015 17:01:45 +0000 X-Env-Sender: julien.grall@citrix.com X-Msg-Ref: server-15.tower-206.messagelabs.com!1431622902!11675393!2 X-Originating-IP: [66.165.176.89] X-SpamReason: No, hits=0.0 required=7.0 tests=sa_preprocessor: VHJ1c3RlZCBJUDogNjYuMTY1LjE3Ni44OSA9PiAyMDMwMDc=\n, received_headers: No Received headers X-StarScan-Received: X-StarScan-Version: 6.13.14; banners=-,-,- X-VirusChecked: Checked Received: (qmail 23699 invoked from network); 14 May 2015 17:01:44 -0000 Received: from smtp.citrix.com (HELO SMTP.CITRIX.COM) (66.165.176.89) by server-15.tower-206.messagelabs.com with RC4-SHA encrypted SMTP; 14 May 2015 17:01:44 -0000 X-IronPort-AV: E=Sophos;i="5.13,430,1427760000"; d="scan'208";a="262765059" From: Julien Grall To: Date: Thu, 14 May 2015 18:00:45 +0100 Message-ID: <1431622863-28575-6-git-send-email-julien.grall@citrix.com> X-Mailer: git-send-email 2.1.4 In-Reply-To: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> References: <1431622863-28575-1-git-send-email-julien.grall@citrix.com> MIME-Version: 1.0 X-DLP: MIA2 Cc: ian.campbell@citrix.com, stefano.stabellini@eu.citrix.com, Julien Grall , tim@xen.org, linux-kernel@vger.kernel.org, Julien Grall , David Vrabel , Boris Ostrovsky , linux-arm-kernel@lists.infradead.org, =?UTF-8?q?Roger=20Pau=20Monn=C3=A9?= Subject: [Xen-devel] [RFC 05/23] block/xen-blkfront: Remove invalid comment X-BeenThere: xen-devel@lists.xen.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: List-Unsubscribe: , List-Post: , List-Help: , List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org X-Removed-Original-Auth: Dkim didn't pass. X-Original-Sender: patch@linaro.org X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of patch+caf_=patchwork-forward=linaro.org@linaro.org designates 209.85.215.51 as permitted sender) smtp.mail=patch+caf_=patchwork-forward=linaro.org@linaro.org Mailing-list: list patchwork-forward@linaro.org; contact patchwork-forward+owners@linaro.org X-Google-Group-Id: 836684582541 List-Archive: From: Julien Grall Since commit b764915 "xen-blkfront: use a different scatterlist for each request", biovec has been replaced by scatterlist when copying back the data during a completion request. Signed-off-by: Julien Grall Cc: Konrad Rzeszutek Wilk Cc: Boris Ostrovsky Cc: David Vrabel Cc: Roger Pau Monné --- drivers/block/xen-blkfront.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c index 5c72c25..60cf1d6 100644 --- a/drivers/block/xen-blkfront.c +++ b/drivers/block/xen-blkfront.c @@ -1056,12 +1056,6 @@ static void blkif_completion(struct blk_shadow *s, struct blkfront_info *info, s->req.u.indirect.nr_segments : s->req.u.rw.nr_segments; if (bret->operation == BLKIF_OP_READ && info->feature_persistent) { - /* - * Copy the data received from the backend into the bvec. - * Since bv_offset can be different than 0, and bv_len different - * than PAGE_SIZE, we have to keep track of the current offset, - * to be sure we are copying the data from the right shared page. - */ for_each_sg(s->sg, sg, nseg, i) { BUG_ON(sg->offset + sg->length > PAGE_SIZE); shared_data = kmap_atomic(