| Message ID | 1638547658-22032-1-git-send-email-srivasam@codeaurora.com |
|---|---|
| Headers | show |
| Series | Add support for audio on SC7280 based targets | expand |
On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: > From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > Add bindings for sc7280 lpass cpu driver which supports > audio over i2s based speaker, soundwire based headset, msm dmics > and HDMI Port. > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> > Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > --- > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- > 1 file changed, 62 insertions(+), 8 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg-names: ['lpass-hdmiif', 'lpass-lpaif'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: interrupts: [[0, 160, 1], [0, 268, 1]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: interrupt-names: ['lpass-irq-lpaif', 'lpass-irq-hdmi'] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: iommus: [[4294967295, 4128, 0], [4294967295, 4146, 0]] is too short From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1563323 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.
On Fri, Dec 3, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote: > > On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: > > From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > > > Add bindings for sc7280 lpass cpu driver which supports > > audio over i2s based speaker, soundwire based headset, msm dmics > > and HDMI Port. > > > > Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> > > Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> > > Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> > > --- > > .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- > > 1 file changed, 62 insertions(+), 8 deletions(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short > From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml Are you running the checks before you send out your patches. Because it seems like you keep sending things with the same errors. If there's errors, I'm not going to review this. If you need help getting it to work, then ask. And what's with your email setup? codeaurora.com bounces. Rob
On 12/3/2021 3:38 PM, Rob Herring wrote: > On Fri, Dec 3, 2021 at 5:34 PM Rob Herring <robh@kernel.org> wrote: >> >> On Fri, 03 Dec 2021 21:37:37 +0530, Srinivasa Rao Mandadapu wrote: >>> From: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>> >>> Add bindings for sc7280 lpass cpu driver which supports >>> audio over i2s based speaker, soundwire based headset, msm dmics >>> and HDMI Port. >>> >>> Signed-off-by: Srinivasa Rao Mandadapu <srivasam@codeaurora.org> >>> Co-developed-by: Venkata Prasad Potturu <potturu@codeaurora.org> >>> Signed-off-by: Venkata Prasad Potturu <potturu@codeaurora.org> >>> --- >>> .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 +++++++++++++++++++--- >>> 1 file changed, 62 insertions(+), 8 deletions(-) >>> >> >> My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' >> on your patch (DT_CHECKER_FLAGS is new in v5.13): >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.example.dt.yaml: lpass@62d80000: reg: [[0, 1658351616, 0, 425984], [0, 1659895808, 0, 167936]] is too short >> From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/sound/qcom,lpass-cpu.yaml > > Are you running the checks before you send out your patches. Because > it seems like you keep sending things with the same errors. > > If there's errors, I'm not going to review this. If you need help > getting it to work, then ask. > > And what's with your email setup? codeaurora.com bounces. codeaurora.com is definitely a wrong domain. It should be codeaurora.org instead. > > Rob >
This patch set is to add support for Audio over wcd codec, digital mics, through digital codecs and without ADSP. Changes Since V7: -- Fix indentation errors. -- Bisect patches to avoid interdependency. Changes Since V6: -- Split cdc dma regmap config macros. -- Add write dma reg fields for i2s path. -- Add helper function to distinguish rxtx and va dma ports. -- Optimizing clock and reg name in cpu dt-bindings. -- Update buffer management for cdc dma path. -- Remove Kconfig fields of machine driver. Changes Since V5: -- Include MI2S primary node to snd_soc_dai_driver in lpass-sc7280 platform driver. -- Move dependency patch list to corresponding patch. -- Add support for missing cdc-dma ports. -- Change if/else conditional statements to switch cases. -- Add missing error handlings. -- Typo errors fix. Changes Since V4: -- Remove unused variable in lpass-sc7280 platform driver. Changes Since V3: -- Remove redundant power domain controls. As power domains can be configured from dtsi. Changes Since V2: -- Split lpass sc7280 cpu driver patch and create regmap config patch. -- Create patches based on latest kernel tip. -- Add helper function to get dma control and lpaif handle. -- Remove unused variables. Changes Since V1: -- Typo errors fix -- CPU driver readable/writable apis optimization. -- Add Missing config patch -- Add Common api for repeated dmactl initialization. Srinivasa Rao Mandadapu (10): ASoC: qcom: SC7280: Update config for building codec dma drivers ASoC: qcom: Move lpass_pcm_data structure to lpass header ASoC: qcom: lpass: Add dma fields for codec dma lpass interface ASoC: qcom: Add helper function to get dma control and lpaif handle ASoC: qcom: Add register definition for codec rddma and wrdma ASoC: qcom: Add regmap config support for codec dma driver ASoC: qcom: Add support for codec dma driver ASoC: qcom: Add lpass CPU driver for codec dma control ASoC: dt-bindings: Add SC7280 lpass cpu bindings ASoC: qcom: lpass-sc7280: Add platform driver for lpass audio .../devicetree/bindings/sound/qcom,lpass-cpu.yaml | 70 ++- sound/soc/qcom/Kconfig | 11 + sound/soc/qcom/Makefile | 4 + sound/soc/qcom/lpass-cdc-dma.c | 275 +++++++++ sound/soc/qcom/lpass-cpu.c | 244 +++++++- sound/soc/qcom/lpass-lpaif-reg.h | 127 ++++- sound/soc/qcom/lpass-platform.c | 617 ++++++++++++++++++--- sound/soc/qcom/lpass-sc7280.c | 441 +++++++++++++++ sound/soc/qcom/lpass.h | 162 ++++++ 9 files changed, 1864 insertions(+), 87 deletions(-) create mode 100644 sound/soc/qcom/lpass-cdc-dma.c create mode 100644 sound/soc/qcom/lpass-sc7280.c