mbox series

[v3,0/3] HDA controller PM and codec PM cleanups

Message ID 20201027130038.16463-1-kai.heng.feng@canonical.com
Headers show
Series HDA controller PM and codec PM cleanups | expand

Message

Kai-Heng Feng Oct. 27, 2020, 1 p.m. UTC 
While working on the issue "ALSA: hda: fix jack detection with Realtek
codecs when in D3", I've found using pm_runtime_force_{suspend,resume}()
have surprising behavior, specifically, pm_runtime_need_not_resume()
uses pm_runtime_need_not_resume() to avoid calling resume callback, so
jackpoll was used to really power up the codec.

We can use direct-complete to do the keep the codec suspended throughout
the system PM flow, namely, keep the codec suspended all the way, unless
the codec needs to be woken up after resume.

For HDA controller, PCI core may enable direct-complete for it if
conditions are met. So make runtime and system PM distinctive to always
apply correct wake up setting.

At least point, hopefully all runtime PM issues are solved, let's enable
runtime PM by default again.

v3:
 - Drop "ALSA: hda: Stop mangling PCI IRQ"

Kai-Heng Feng (3):
  ALSA: hda: Refactor codec PM to use direct-complete optimization
  ALSA: hda: Separate runtime and system suspend
  ALSA: hda: Reinstate runtime_allow() for all hda controllers

 sound/pci/hda/hda_codec.c      | 45 +++++++++++++++---------
 sound/pci/hda/hda_controller.h |  3 +-
 sound/pci/hda/hda_intel.c      | 63 +++++++++++++++++++---------------
 3 files changed, 66 insertions(+), 45 deletions(-)