mbox series

[0/3] ASoC: sh: rz-ssi: Trivial changes

Message ID 20220125132457.14984-1-prabhakar.mahadev-lad.rj@bp.renesas.com
Headers show
Series ASoC: sh: rz-ssi: Trivial changes | expand

Message

Prabhakar Mahadev Lad Jan. 25, 2022, 1:24 p.m. UTC 
Hi All,

This patch series has trivial changes for rz-ssi driver. Patches 1
(partial) & 2 are from series [3].

patch 1/3 is just a cosmetic change which was part of patch [0] where it
uses a do-while instead of while-do. Patch 2/3 is from series [1] where a
helper function is added and patch 3/3 is a new patch which removes
duplicate macros.

All the patches apply to [2] (sound -next)

[0] https://patchwork.kernel.org/project/alsa-devel/patch/
20220115012303.29651-2-prabhakar.mahadev-lad.rj@bp.renesas.com/
[1] https://patchwork.kernel.org/project/alsa-devel/patch/
20220115012303.29651-6-prabhakar.mahadev-lad.rj@bp.renesas.com/
[2] https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git/log/
[3] https://patchwork.kernel.org/project/alsa-devel/list/?series=605672

Cheers,
Prabhakar

Lad Prabhakar (3):
  ASoC: sh: rz-ssi: Use a do-while loop in rz_ssi_pio_recv()
  ASoC: sh: rz-ssi: Add rz_ssi_set_substream() helper function
  ASoC: sh: rz-ssi: Remove duplicate macros

 sound/soc/sh/rz-ssi.c | 31 ++++++++++++++++---------------
 1 file changed, 16 insertions(+), 15 deletions(-)

Comments

Biju Das Jan. 25, 2022, 1:48 p.m. UTC | #1 
Hi Prabhakar,

Thanks for the patch

> -----Original Message-----
> From: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Sent: 25 January 2022 13:25
> To: Mark Brown <broonie@kernel.org>; Liam Girdwood <lgirdwood@gmail.com>;
> Jaroslav Kysela <perex@perex.cz>; Takashi Iwai <tiwai@suse.com>; alsa-
> devel@alsa-project.org; Pavel Machek <pavel@denx.de>
> Cc: linux-kernel@vger.kernel.org; linux-renesas-soc@vger.kernel.org; Biju
> Das <biju.das.jz@bp.renesas.com>; Prabhakar <prabhakar.csengg@gmail.com>;
> Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Subject: [PATCH 3/3] ASoC: sh: rz-ssi: Remove duplicate macros
> 
> Remove SSICR_MST and SSICR_CKDV macros which are defined more than once.
> 
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>

Cheers,
Biju

> ---
>  sound/soc/sh/rz-ssi.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/sound/soc/sh/rz-ssi.c b/sound/soc/sh/rz-ssi.c index
> 1a46c9f3c4e5..e8edaed05d4c 100644
> --- a/sound/soc/sh/rz-ssi.c
> +++ b/sound/soc/sh/rz-ssi.c
> @@ -28,8 +28,6 @@
>  /* SSI REGISTER BITS */
>  #define SSICR_DWL(x)		(((x) & 0x7) << 19)
>  #define SSICR_SWL(x)		(((x) & 0x7) << 16)
> -#define SSICR_MST		BIT(14)
> -#define SSICR_CKDV(x)		(((x) & 0xf) << 4)
> 
>  #define SSICR_CKS		BIT(30)
>  #define SSICR_TUIEN		BIT(29)
> --
> 2.17.1