mbox series

[v2,00/18] Clean ups and preparation for IPC abstraction in the SOF driver

Message ID 20220308164344.577647-1-ranjani.sridharan@linux.intel.com
Headers show
Series Clean ups and preparation for IPC abstraction in the SOF driver | expand

Message

Ranjani Sridharan March 8, 2022, 4:43 p.m. UTC
In preparation for adding support for the new IPC version that has been
introduced in the SOF firmware, this patch set includes some clean ups
and necessary modifications to commonly used functions that will be
re-used across different IPC-specific code.

Changes in v2:
- Use guid_t instead of u8 array for uuid and the helper guid_is_null()

Pierre-Louis Bossart (1):
  ASoC: SOF: sof-audio: removed unused function

Rander Wang (1):
  ASoC: SOF: move definition of snd_sof_ipc to header file

Ranjani Sridharan (16):
  ASoC: SOF: remove snd_sof_pipeline_find()
  ASoC: SOF: simplify snd_sof_device_remove()
  ASoC: SOF: set swidget's core for scheduler widget
  ASoC: SOF: topology: remove redundant code
  ASoC: SOF: topology: remove redundant code in sof_link_afe_load()
  ASoC: SOF: topology: Drop the size parameter from struct
    sof_topology_token
  ASoC: SOF: topology: Modify the get_token op for string tokens
  ASoC: SOF: topology: expose some get_token ops
  ASoC: SOF: change comp_dai to a pointer in struct snd_sof_dai
  ASoC: SOF: make struct snd_sof_widget IPC agnostic
  ASoC: SOF: topology: make sof_route_load() IPC agnostic
  ASoC: SOF: Add a tuples array to struct snd_sof_widget
  ASoC: SOF: topology: Modify signature for token parsing functions
  ASoC: SOF: topology: Rename arguments in sof_parse_token_sets()
  ASoC: SOF: topology: Rename arguments in sof_parse_tokens()
  ASoC: SOF: make struct snd_sof_dai IPC agnostic

 include/sound/sof/dai.h       |   5 +
 include/sound/sof/topology.h  |   8 -
 sound/soc/sof/core.c          |  10 +-
 sound/soc/sof/intel/hda-dai.c |  27 ++-
 sound/soc/sof/intel/hda.c     |  39 +++-
 sound/soc/sof/ipc.c           |  12 --
 sound/soc/sof/pcm.c           |  77 +++----
 sound/soc/sof/sof-audio.c     | 108 +++-------
 sound/soc/sof/sof-audio.h     |  30 ++-
 sound/soc/sof/sof-priv.h      |  12 ++
 sound/soc/sof/topology.c      | 392 +++++++++++++++++-----------------
 11 files changed, 354 insertions(+), 366 deletions(-)

Comments

Ranjani Sridharan March 9, 2022, 3:44 p.m. UTC | #1
On Tue, 2022-03-08 at 08:43 -0800, Ranjani Sridharan wrote:
> In preparation for adding support for the new IPC version that has
> been
> introduced in the SOF firmware, this patch set includes some clean
> ups
> and necessary modifications to commonly used functions that will be
> re-used across different IPC-specific code.
> 
> Changes in v2:
> - Use guid_t instead of u8 array for uuid and the helper
> guid_is_null()
Hi Mark,

I see that you have applied the v1 of this series. Please disregard
this series and I will send the changes in v2 as a separate patch.
Also, I noticed that your for-next and for-5.18 branches only contain
12 of the 18 patches in this series. Should I resend the ones that got
missed?

Thanks,
Ranjani
Ranjani Sridharan March 9, 2022, 3:44 p.m. UTC | #2
On Tue, 2022-03-08 at 08:43 -0800, Ranjani Sridharan wrote:
> In preparation for adding support for the new IPC version that has
> been
> introduced in the SOF firmware, this patch set includes some clean
> ups
> and necessary modifications to commonly used functions that will be
> re-used across different IPC-specific code.
> 
> Changes in v2:
> - Use guid_t instead of u8 array for uuid and the helper
> guid_is_null()
Hi Mark,

I see that you have applied the v1 of this series. Please disregard
this series and I will send the changes in v2 as a separate patch.
Also, I noticed that your for-next and for-5.18 branches only contain
12 of the 18 patches in this series. Should I resend the ones that got
missed?

Thanks,
Ranjani
Mark Brown March 9, 2022, 3:49 p.m. UTC | #3
On Wed, Mar 09, 2022 at 07:44:52AM -0800, Ranjani Sridharan wrote:

> I see that you have applied the v1 of this series. Please disregard
> this series and I will send the changes in v2 as a separate patch.
> Also, I noticed that your for-next and for-5.18 branches only contain
> 12 of the 18 patches in this series. Should I resend the ones that got
> missed?

If it's just resends don't bother it's queued already.  I applied the
patches up to the one that got review comments from v1 and have queued
the rest from v2.
Mark Brown March 10, 2022, 11:35 a.m. UTC | #4
On Tue, 8 Mar 2022 08:43:26 -0800, Ranjani Sridharan wrote:
> In preparation for adding support for the new IPC version that has been
> introduced in the SOF firmware, this patch set includes some clean ups
> and necessary modifications to commonly used functions that will be
> re-used across different IPC-specific code.
> 
> Changes in v2:
> - Use guid_t instead of u8 array for uuid and the helper guid_is_null()
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[11/18] ASoC: SOF: make struct snd_sof_widget IPC agnostic
        commit: 7a976552a4f264f777be236c0c83263975512f1a
[12/18] ASoC: SOF: topology: make sof_route_load() IPC agnostic
        commit: 2b4b383f85baa493039a1fd80ca3f428f9504a54
[13/18] ASoC: SOF: Add a tuples array to struct snd_sof_widget
        commit: c7b655ade96a282a4304d68dcb120fcb61f19db2
[14/18] ASoC: SOF: topology: Modify signature for token parsing functions
        commit: 38a9a06794fe052dab57177f0320f44124e6cef9
[15/18] ASoC: SOF: topology: Rename arguments in sof_parse_token_sets()
        commit: e0974a382e7c4e0962edebbd8e0d3185c928ea85
[16/18] ASoC: SOF: topology: Rename arguments in sof_parse_tokens()
        commit: 5f8333f62fcada65a85aac53c6a39eb6c4f0bb4e
[17/18] ASoC: SOF: make struct snd_sof_dai IPC agnostic
        commit: 839e484f9e173309d599e1281eb7221e07f41814
[18/18] ASoC: SOF: move definition of snd_sof_ipc to header file
        commit: f535880b2d32fcb85d99a81483d44c8df23d23cf

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark