| Message ID | 20220323164442.921-1-jiaxin.yu@mediatek.com |
|---|---|
| Headers | show |
| Series | ASoC: mediatek: mt8192: support rt1015p_rt5682s | expand |
On Thu, Mar 24, 2022 at 12:44:39AM +0800, Jiaxin Yu wrote: > + speaker-codec: If it is possible to have 1 or more items, would "speaker-codecs" be a better name? > + type: object > + properties: > + sound-dai: > + minItems: 2 It should be 1. Consider of rt1015p case.
On Thu, Mar 24, 2022 at 12:44:40AM +0800, Jiaxin Yu wrote: > MT8192 platform will use rt1015 or rt105p codec, so through the > snd_soc_of_get_dai_link_codecs() to complete the configuration > of dai_link's codecs. > > Signed-off-by: Jiaxin Yu <jiaxin.yu@mediatek.com> Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org> Except the name: speaker-codec vs. speaker-codecs. Have replied to the DT bindings patch in the same series.
On Thu, 2022-03-24 at 08:54 +0800, Tzung-Bi Shih wrote: > On Thu, Mar 24, 2022 at 12:44:39AM +0800, Jiaxin Yu wrote: > > + speaker-codec: > > If it is possible to have 1 or more items, would "speaker-codecs" be > a better > name? Hi Tzung-Bi, Yes, it is better to use "speaker-codecs", I will change it that in driver patch and bindings patch. Jiaxin.Yu Thanks > > > + type: object > > + properties: > > + sound-dai: > > + minItems: 2 > > It should be 1. Consider of rt1015p case. Yes, I will correct it.
The series reuses mt8192-mt6359-rt10150rt5682.c for supporting machine driver with rt1015p speaker amplifier and rt5682s headset codec. Changes from v5: - "mediatek,headset-codec" and "mediatek,speaker-codec" drop prefix and move to properties from patternProperties. Changes form v4: - split a large patch into three small patches for easy reviewing - correct coding style Changes from v3: - fix build error: too many arguments for format [-Werror-format-extra-args] Changes from v2: - fix build warnings such as "data argument not used by format string" Changes from v1: - uses the snd_soc_of_get_dai_link_codecs to complete the configuration of dai_link's codecs - uses definitions to simplifies card name and compatible name Jiaxin Yu (4): ASoC: dt-bindings: mt8192-mt6359: add new compatible and new properties ASoC: mediatek: mt8192: refactor for I2S3 DAI link of speaker ASoC: mediatek: mt8192: refactor for I2S8/I2S9 DAI links of headset ASoC: mediatek: mt8192: support rt1015p_rt5682s .../sound/mt8192-mt6359-rt1015-rt5682.yaml | 32 +++ sound/soc/mediatek/Kconfig | 1 + .../mt8192/mt8192-mt6359-rt1015-rt5682.c | 201 +++++++++++------- 3 files changed, 156 insertions(+), 78 deletions(-)