mbox series

[v2,0/4] Add support for CLSA0101

Message ID 20220727095924.80884-1-tanureal@opensource.cirrus.com
Headers show
Series Add support for CLSA0101 | expand

Message

Lucas tanure July 27, 2022, 9:59 a.m. UTC 
Add Support for the CLSA0101 laptop, an Intel version of CLSA0100.
This patch has been tested using the CLSA0100, ensuring it
doesn't break the sound for it.
We appreciate it if someone with CLSA0101 could verify that this
the patch works for them.

Changes from V1:
 - Add CLSA0101 id into scan.c, serial-multi-instantiate.c
 and cs35l41_hda_i2c.c

Lucas Tanure (4):
  ALSA: hda: cs35l41: Use the CS35L41 HDA internal define
  ALSA: hda: cs35l41: Support CLSA0101
  ACPI: scan: Add CLSA0101 Laptop Support
  platform/x86: serial-multi-instantiate: Add CLSA0101 Laptop

 drivers/acpi/scan.c                           |  1 +
 .../platform/x86/serial-multi-instantiate.c   |  1 +
 sound/pci/hda/cs35l41_hda.c                   | 67 ++++++++++++-------
 sound/pci/hda/cs35l41_hda_i2c.c               |  3 +
 sound/pci/hda/patch_realtek.c                 | 12 ++++
 5 files changed, 58 insertions(+), 26 deletions(-)

Comments

Cameron Berkenpas July 27, 2022, 3:27 p.m. UTC | #1 
Sound works as expected with this patch.

Sound fails after resume from sleep & hibernate, but as mentioned by 
Lucas in another email, this is currently expected, and will be fixed in 
a patch for a separate issue.

This is arguably better than the old behavior where we only saw right 
channel sound from the left speaker. I say merge it.

Thanks, Lucas!

-Cameron

On 7/27/22 02:59, Lucas Tanure wrote:
> Add Support for the CLSA0101 laptop, an Intel version of CLSA0100.
> This patch has been tested using the CLSA0100, ensuring it
> doesn't break the sound for it.
> We appreciate it if someone with CLSA0101 could verify that this
> the patch works for them.
>
> Changes from V1:
>   - Add CLSA0101 id into scan.c, serial-multi-instantiate.c
>   and cs35l41_hda_i2c.c
>
> Lucas Tanure (4):
>    ALSA: hda: cs35l41: Use the CS35L41 HDA internal define
>    ALSA: hda: cs35l41: Support CLSA0101
>    ACPI: scan: Add CLSA0101 Laptop Support
>    platform/x86: serial-multi-instantiate: Add CLSA0101 Laptop
>
>   drivers/acpi/scan.c                           |  1 +
>   .../platform/x86/serial-multi-instantiate.c   |  1 +
>   sound/pci/hda/cs35l41_hda.c                   | 67 ++++++++++++-------
>   sound/pci/hda/cs35l41_hda_i2c.c               |  3 +
>   sound/pci/hda/patch_realtek.c                 | 12 ++++
>   5 files changed, 58 insertions(+), 26 deletions(-)
>
Takashi Iwai July 28, 2022, 10:34 a.m. UTC | #2 
On Wed, 27 Jul 2022 11:59:20 +0200,
Lucas Tanure wrote:
> 
> Add Support for the CLSA0101 laptop, an Intel version of CLSA0100.
> This patch has been tested using the CLSA0100, ensuring it
> doesn't break the sound for it.
> We appreciate it if someone with CLSA0101 could verify that this
> the patch works for them.
> 
> Changes from V1:
>  - Add CLSA0101 id into scan.c, serial-multi-instantiate.c
>  and cs35l41_hda_i2c.c
> 
> Lucas Tanure (4):
>   ALSA: hda: cs35l41: Use the CS35L41 HDA internal define
>   ALSA: hda: cs35l41: Support CLSA0101
>   ACPI: scan: Add CLSA0101 Laptop Support
>   platform/x86: serial-multi-instantiate: Add CLSA0101 Laptop

Applied all four patches now.  Thanks.


Takashi