mbox series

[v2,00/11] ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450

Message ID 20221115120235.167812-1-krzysztof.kozlowski@linaro.org
Headers show
Series ASoC: dt-bindings: Rework Qualcomm APR/GPR Sound nodes for SM8450 | expand

Message

Krzysztof Kozlowski Nov. 15, 2022, 12:02 p.m. UTC
Changes since v1
================
1. Patch 2: Keep compatibles in qcom,apr.yaml.
2. Patch 3: New patch.

Description
===========
Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought
some changes to APR/GPR services bindings.  These bindings are part of
qcom,apr.yaml:

  apr-or-gpr-device-node <- qcom,apr.yaml
    apr-gpr-service@[0-9] <- qcom,apr.yaml
      service-specific-components <- /schemas/sound/qcom,q6*.yaml

The schema for services (apr-gpr-service@[0-9]) was not complete and is still
quite not specific.  It allows several incorrect combinations, like adding a
clock-controller to a APM device.  Restricting it would complicate the schema
even more.  Bringing new support for sound on Qualcomm SM8450 and SC8280XP SoC
would grow it as well.

Refactor the bindings before extending them for Qualcomm SM8450 SoC.

DTS was sent here:
https://lore.kernel.org/linux-arm-msm/20221115110053.110319-1-krzysztof.kozlowski@linaro.org/T/#t

Best regards,
Krzysztof

---

Cc: quic_srivasam@quicinc.com
Cc: quic_plai@quicinc.com

Krzysztof Kozlowski (11):
  ASoC: dt-bindings: qcom,apr: Add GLINK channel name for SM8450
  ASoC: dt-bindings: qcom,apr: Split services to shared schema
  ASoC: dt-bindings: qcom,apr: Correct and extend example
  ASoC: dt-bindings: qcom,q6afe: Split to separate schema
  ASoC: dt-bindings: qcom,q6apm: Split to separate schema
  ASoC: dt-bindings: qcom,q6adm: Split to separate schema
  ASoC: dt-bindings: qcom,q6asm: Split to separate schema
  ASoC: dt-bindings: qcom,q6prm: Split to separate schema
  ASoC: dt-bindings: qcom,q6core: Split to separate schema
  ASoC: dt-bindings: qcom,q6apm-lpass-dais: Split to separate schema
  ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node

 .../bindings/soc/qcom/qcom,apr-services.yaml  |  54 ++++++
 .../bindings/soc/qcom/qcom,apr.yaml           | 170 ++++++------------
 .../bindings/sound/qcom,q6adm-routing.yaml    |  22 +--
 .../devicetree/bindings/sound/qcom,q6adm.yaml |  51 ++++++
 .../devicetree/bindings/sound/qcom,q6afe.yaml |  68 +++++++
 .../bindings/sound/qcom,q6apm-dai.yaml        |  19 +-
 .../bindings/sound/qcom,q6apm-lpass-dais.yaml |  32 ++++
 .../devicetree/bindings/sound/qcom,q6apm.yaml |  67 +++++++
 .../bindings/sound/qcom,q6asm-dais.yaml       |  48 ++---
 .../devicetree/bindings/sound/qcom,q6asm.yaml |  68 +++++++
 .../bindings/sound/qcom,q6core.yaml           |  39 ++++
 .../sound/qcom,q6dsp-lpass-clocks.yaml        |  40 +----
 .../sound/qcom,q6dsp-lpass-ports.yaml         |  57 +-----
 .../devicetree/bindings/sound/qcom,q6prm.yaml |  50 ++++++
 MAINTAINERS                                   |   2 +-
 15 files changed, 515 insertions(+), 272 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6afe.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm-lpass-dais.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6apm.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6asm.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6core.yaml
 create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6prm.yaml

Comments

Rob Herring Nov. 16, 2022, 2:41 p.m. UTC | #1
On Tue, 15 Nov 2022 13:02:30 +0100, Krzysztof Kozlowski wrote:
> The APR/GPR bindings with services got complicated so move out the Q6ADM
> service to its own binding.  Previously the compatible was documented in
> qcom,apr.yaml.  Move most of the examples from its children to this new
> file.
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> ---
> 
> Cc: quic_srivasam@quicinc.com
> Cc: quic_plai@quicinc.com
> ---
>  .../bindings/sound/qcom,q6adm-routing.yaml    | 22 ++------
>  .../devicetree/bindings/sound/qcom,q6adm.yaml | 51 +++++++++++++++++++
>  2 files changed, 54 insertions(+), 19 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,q6adm.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Mark Brown Nov. 28, 2022, 4:39 p.m. UTC | #2
On Tue, 15 Nov 2022 13:02:24 +0100, Krzysztof Kozlowski wrote:
> Changes since v1
> ================
> 1. Patch 2: Keep compatibles in qcom,apr.yaml.
> 2. Patch 3: New patch.
> 
> Description
> ===========
> Adding sound support for Qualcomm SM8450 SoC (and later for SC8280XP) brought
> some changes to APR/GPR services bindings.  These bindings are part of
> qcom,apr.yaml:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[01/11] ASoC: dt-bindings: qcom,apr: Add GLINK channel name for SM8450
        commit: 0dd3618e06f86bbdacad3a40b25bf79b8917000c
[02/11] ASoC: dt-bindings: qcom,apr: Split services to shared schema
        commit: 41288c30583646e2b4158c75ccdbddc62597e1fa
[03/11] ASoC: dt-bindings: qcom,apr: Correct and extend example
        commit: cd9ba3d065bb94f3c20e36ed400269a285bfa46d
[04/11] ASoC: dt-bindings: qcom,q6afe: Split to separate schema
        commit: 3e9c0c86267377f1404bc55051f476a0456dcced
[05/11] ASoC: dt-bindings: qcom,q6apm: Split to separate schema
        commit: 6180b3252010f7cccdef896faf305456df4c45cf
[06/11] ASoC: dt-bindings: qcom,q6adm: Split to separate schema
        commit: f26a776ea5ea22b5a92b0619af54d202e4027524
[07/11] ASoC: dt-bindings: qcom,q6asm: Split to separate schema
        commit: 83c8fa5e85e556e6aa3e95e7070ef738964ebd17
[08/11] ASoC: dt-bindings: qcom,q6prm: Split to separate schema
        commit: 8009abe0f14052bbfadcdaba7887226b40dfdb51
[09/11] ASoC: dt-bindings: qcom,q6core: Split to separate schema
        commit: 7eea2bed3602a2b2e71146e0110d42f6edf917f5
[10/11] ASoC: dt-bindings: qcom,q6apm-lpass-dais: Split to separate schema
        commit: 8c7ac825481602e356d96db9424b4d4e23a6a1d3
[11/11] ASoC: dt-bindings: qcom,q6apm: Add SM8450 bedais node
        commit: b386acc043f44a730d5117b71b75e818cede21cc

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark