From patchwork Thu Feb 9 08:37:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lucas Tanure X-Patchwork-Id: 652380 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 930C5C05027 for ; Thu, 9 Feb 2023 08:40:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C7E3FDF2; Thu, 9 Feb 2023 09:39:25 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C7E3FDF2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1675932015; bh=i1JlebRdfvjtPYpGWrkORFgqL1KTDHUIWHRch2IPV2g=; h=From:To:Subject:Date:CC:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=fgGOIF9oR51lqQ6tm9ERUG1QwSkmhuAu29+p3nh6+QxRkykp7YCVeb4ML/sGikNoK cM2jsF7+SYAACKuiFajTYm8FmtDuDaeo560AYhHQEm9mUE3zBS5oXwCLKDeJbrNQtB KfNXwYtzWHQ8XZyMz6pF4vOl3ivOU8sU4Yjyobzs= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 6AF86F80544; Thu, 9 Feb 2023 09:38:06 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4C3D9F80534; Thu, 9 Feb 2023 09:37:56 +0100 (CET) Received: from madras.collabora.co.uk (madras.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CB566F80086 for ; Thu, 9 Feb 2023 09:37:32 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CB566F80086 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=collabora.com header.i=@collabora.com header.a=rsa-sha256 header.s=mail header.b=lEuC+l0G Received: from cryzen.lan (cpc87451-finc19-2-0-cust61.4-2.cable.virginm.net [82.11.51.62]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: tanureal) by madras.collabora.co.uk (Postfix) with ESMTPSA id A665066020B9; Thu, 9 Feb 2023 08:37:30 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1675931850; bh=i1JlebRdfvjtPYpGWrkORFgqL1KTDHUIWHRch2IPV2g=; h=From:To:Cc:Subject:Date:From; b=lEuC+l0Gd9iUjwyIouDp2TRfXK4SQadLKVZyPT9EizOYzYc6WFYqLK8KK82fbR+iw KtspcEarrHXGk2eBaJ2SpeB1EUI0IoqSd6FVt80+1KfduyvIsVnCjA9Cqjmo8Pwys7 qpMGoFv564+Txpe4UUvuV9xhPlfM6mOR1nPZGCG0leoZZdArMeWNLktCosmQ5sMEjX L2Soe5EJ5XBQVWejYFs36jYwxm4m66sZF/d9boS2/MhGrE3xJWCUfTFAEdBM0O+BA6 rouR/D2ZwDRKzH7O2DShWNPq42BPoH7etr6Squuq5IZ53R1DOXVQaKRNX4EYkP5n9q A/cPUtIHBqHSg== From: Lucas Tanure To: David Rhodes , Charles Keepax , Liam Girdwood , Krzysztof Kozlowski , Mark Brown , Rob Herring , Jaroslav Kysela , Takashi Iwai Subject: [PATCH v4 0/4] Add CS35L41 shared boost feature Date: Thu, 9 Feb 2023 08:37:22 +0000 Message-Id: <20230209083726.1337150-1-lucas.tanure@collabora.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Message-ID-Hash: CPLPTSGGXHDT2YXII6WQ6IZFUI5ZZGPM X-Message-ID-Hash: CPLPTSGGXHDT2YXII6WQ6IZFUI5ZZGPM X-MailFrom: lucas.tanure@collabora.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: alsa-devel@alsa-project.org, devicetree@vger.kernel.org, patches@opensource.cirrus.com, linux-kernel@vger.kernel.org, kernel@collabora.com, Lucas Tanure X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Valve's Steam Deck uses CS35L41 in shared boost mode, where both speakers share the boost circuit. Add this support in the shared lib, but for now, shared boost is not supported in HDA systems as would require BIOS changes. Based on David Rhodes shared boost patches. Also, fix boost config overwriting in IRQ found in the review and do a small refactor of the code. Changes from V3: - Fix wrong code sent - Fix ISO C90 mixed declarations and code Changes from V2: - Drop External boost without VSPK Documentation - Move Shared boost to use values 2 and 3 - Revert back to reg_sequence but reading the value first and only update the necessary bits - Fix bug found by Intel kernel Test Robot Changes from V1: - Fix Documentation patch subject - New patch for External boost without VSPK Documentation - New patch to fix boost IRQ overwriting issue - New patch to refactor IRQ release error code - reinit_completion on pcm_startup - fix DRE switch overwriting - return IRQ_HANDLED in PLL_LOCK case Lucas Tanure (4): ASoC: cs35l41: Only disable internal boost ASoC: cs35l41: Refactor error release code ALSA: cs35l41: Add shared boost feature ASoC: cs35l41: Document CS35l41 shared boost .../bindings/sound/cirrus,cs35l41.yaml | 10 +- include/sound/cs35l41.h | 13 +- sound/pci/hda/cs35l41_hda.c | 6 +- sound/soc/codecs/cs35l41-lib.c | 73 +++++++++- sound/soc/codecs/cs35l41.c | 125 +++++++++--------- sound/soc/codecs/cs35l41.h | 1 + 6 files changed, 157 insertions(+), 71 deletions(-)