mbox series

[v2,00/11] Improve CS35l41-based audio codec drivers

Message ID 20230907171010.1447274-1-cristian.ciocaltea@collabora.com
Headers show
Series Improve CS35l41-based audio codec drivers | expand

Message

Cristian Ciocaltea Sept. 7, 2023, 5:09 p.m. UTC 
This patch series contains several fixes and improvements to drivers
based on the CS35l41 audio codec.

It has been verified on Valve's Steam Deck, except the HDA related patches.

Changes in v2:
 - Added Acked-by tags from Charles
 - Reworked the shared boost handling per reviews from Charles and David
 - Dropped PATCH 5/9 and moved PATCH 6/9 a bit down the list, as it doesn't
   contain a Fixes tag
 - Reverted usage of devm_pm_runtime_enable() in PATCH 9/9 and replaced with
   a proper runtime PM changes undo in PATCH v2 06/11
 - Added 3 new patches providing some HDA related fixes
 - v1: https://lore.kernel.org/all/20230902210621.1184693-1-cristian.ciocaltea@collabora.com/

Cristian Ciocaltea (11):
  ASoC: cs35l41: Handle mdsync_down reg write errors
  ASoC: cs35l41: Handle mdsync_up reg write errors
  ASoC: cs35l41: Initialize completion object before requesting IRQ
  ASoC: cs35l41: Fix broken shared boost activation
  ASoC: cs35l41: Verify PM runtime resume errors in IRQ handler
  ASoC: cs35l41: Undo runtime PM changes at driver exit time
  ASoC: cs35l41: Make use of dev_err_probe()
  ASoC: cs35l41: Use modern pm_ops
  ALSA: hda: cs35l41: Fix unbalanced pm_runtime_get()
  ALSA: hda: cs35l41: Undo runtime PM changes at driver exit time
  ALSA: hda: cs35l41: Consistently use dev_err_probe()

 include/sound/cs35l41.h        |  4 +-
 sound/pci/hda/cs35l41_hda.c    | 23 +++++----
 sound/soc/codecs/cs35l41-i2c.c | 11 ++--
 sound/soc/codecs/cs35l41-lib.c | 60 +++++++++++++---------
 sound/soc/codecs/cs35l41-spi.c | 11 ++--
 sound/soc/codecs/cs35l41.c     | 93 +++++++++++++++++++---------------
 sound/soc/codecs/cs35l41.h     |  1 -
 7 files changed, 112 insertions(+), 91 deletions(-)

Comments

Cristian Ciocaltea Sept. 7, 2023, 5:27 p.m. UTC | #1 
On 9/7/23 20:21, Mark Brown wrote:
> On Thu, Sep 07, 2023 at 08:09:59PM +0300, Cristian Ciocaltea wrote:
> 
>>  - Added 3 new patches providing some HDA related fixes
> 
> Do these have any interaction with the rest of the series?

Yes, PATCH v2 04/11 changed the signature of cs35l41_global_enable()
function which is also used by HDA - this is how I noticed the
additional issues.