mbox series

[v1,0/2] ALSA: hda: cs35l41: Ignore errors when configuring interrupts to allow laptops with bad ACPI to play audio

Message ID 20240429154853.9393-1-sbinding@opensource.cirrus.com
Headers show
Series ALSA: hda: cs35l41: Ignore errors when configuring interrupts to allow laptops with bad ACPI to play audio | expand

Message

Stefan Binding April 29, 2024, 3:48 p.m. UTC 
Some laptops have a bad _CRS defined for its interrupt.
This errors out inside the driver probe for CS35L41 HDA.
However, there is no fix in software for this bad configuration,
and it is unlikely to get a new BIOS, therefore it is better to
allow the laptop to continue probe, instead of erroring out inside
the probe. The interrupt is only used for Error Detection and
recovery, without the interrupt the driver will continue to function,
but errors will not be detected, and recovery will require a reboot.

Also add support for ASUS ROG 2024 laptops.
These laptops were released without _DSD, so need to be added into
the CS35L41 config table. Quirks for these laptops already exist.

Stefan Binding (2):
  ALSA: hda: cs35l41: Ignore errors when configuring IRQs
  ALSA: hda: cs35l41: Add support for ASUS ROG 2024 Laptops

 sound/pci/hda/cs35l41_hda.c          | 69 +++++++++++++++++++---------
 sound/pci/hda/cs35l41_hda_property.c | 10 ++++
 2 files changed, 57 insertions(+), 22 deletions(-)

Comments

Takashi Iwai April 30, 2024, 7:29 a.m. UTC | #1 
On Mon, 29 Apr 2024 17:48:51 +0200,
Stefan Binding wrote:
> 
> Some laptops have a bad _CRS defined for its interrupt.
> This errors out inside the driver probe for CS35L41 HDA.
> However, there is no fix in software for this bad configuration,
> and it is unlikely to get a new BIOS, therefore it is better to
> allow the laptop to continue probe, instead of erroring out inside
> the probe. The interrupt is only used for Error Detection and
> recovery, without the interrupt the driver will continue to function,
> but errors will not be detected, and recovery will require a reboot.
> 
> Also add support for ASUS ROG 2024 laptops.
> These laptops were released without _DSD, so need to be added into
> the CS35L41 config table. Quirks for these laptops already exist.
> 
> Stefan Binding (2):
>   ALSA: hda: cs35l41: Ignore errors when configuring IRQs
>   ALSA: hda: cs35l41: Add support for ASUS ROG 2024 Laptops

Thanks, applied both patches to for-next branch now.


Takashi