From patchwork Mon Nov 26 17:21:05 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 152059 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp110646ljp; Mon, 26 Nov 2018 09:21:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/XtvVA/3lCqTozb5Oah1M4ioMe2iix2b9jgxGI7Zgt3vBWugueaK6aFOYgX5fCYQCuvGmxZ X-Received: by 2002:adf:ea11:: with SMTP id q17mr23655227wrm.328.1543252877216; Mon, 26 Nov 2018 09:21:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1543252877; cv=none; d=google.com; s=arc-20160816; b=WeEYM5DObUs2r1jN3xzFnZFezbxpd8q3fMQmHl1y5wzDAvTWVgLExFntUj/ATM5rJN n1zRBEHXTAE+nbkO0pR5S67m6FAa+5Tc4WbmrMocXuZMhFdaNPcnbaZuWTGOLHNIw1+T BZpBbpS/mIINurGZfKWWIT4jA2f4GqjZp8KkFkp74ZO2W5rPLQnsDd9/5p4LjhbYvbft Fee5EvCy9+Filbv2Brp5gi7+3j8h08Lm3wwi3UoZLKpuV8UgGCLTC3MvDrK9xu88IawG pAjsCoyvD5S40t2YMtU3JgARF5nnKf7B0e7HJ5jV1F0NgiPz1IMBQeMMDvTdAtDCEd3k 5c3A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to; bh=BiunT02s9dzlMauyel470gxbj1cizVNMryhqX+6bS7c=; b=u76+GCyaqQkm9HI1z3ZiHRs6EPtvrvCnuVGdXuAwLY9JZ2VeKo2Wkn9+xqXCEw8ZGZ nkC+Sx2XPqinaOVFCkn2ZcIxmJostAE+F0/D9of7AH6uReKtpDCzIzpWKUH3kh17rEfd 13duwQ8Rnc3P4ewlxW2IJnEemGrPcertc3ZxN9EVdf1jAIfjPnRHaD8rkiTX16bKMde6 tKXTd+VWD7AmNGgLow1c5QK/M4EZKbX0jydRnR4kCyyTCKI+4w/2DVopVYjtxFDJLNu3 0qgd5CRo6MEoIM+PXBjCKkTxBI6i8WEt3J6CVXdolRAZax+m87aqNCCDBGPbxw0Quqq6 K2YA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=qTdfF3F5; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id h10-v6si775070wri.367.2018.11.26.09.21.17; Mon, 26 Nov 2018 09:21:17 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=qTdfF3F5; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 193BC267ADF; Mon, 26 Nov 2018 18:21:14 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 8FF34267AC9; Mon, 26 Nov 2018 18:21:09 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 38EFD267AE4 for ; Mon, 26 Nov 2018 18:21:07 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Bzizd54X/eSQXjZ4CekUV8xlwaefTJBGaW3y+0mPBZg=; b=qTdfF3F5QOk3 Y3+U1Wj2tCe5NBuVEklhWSP/dCt1hzN7HvU5ncPGZ7fwfhyVags6sjOJLbZzE1gWw98L/XhXACcDg q2OpHlMeI7JIUw2p/3zlBD4ND8n22pkud9F5Q5n1jJnDRhxQ6YnnwxjET0Yv+HTf1Af5biZl8iM75 O9OvE=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=debutante.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpa (Exim 4.89) (envelope-from ) id 1gRKZF-0005Tj-N6; Mon, 26 Nov 2018 17:21:05 +0000 Received: by debutante.sirena.org.uk (Postfix, from userid 1000) id 62712112519F; Mon, 26 Nov 2018 17:21:05 +0000 (GMT) From: Mark Brown To: Dan Carpenter In-Reply-To: <20181126081307.qhbpwnlikquep476@kili.mountain> Message-Id: <20181126172105.62712112519F@debutante.sirena.org.uk> Date: Mon, 26 Nov 2018 17:21:05 +0000 (GMT) Cc: alsa-devel@alsa-project.org, Maruthi Srinivas Bayyavarapu , kernel-janitors@vger.kernel.org, Liam Girdwood , Takashi Iwai , Sanju R Mehta , Mark Brown , Vijendar Mukunda , Alex Deucher Subject: [alsa-devel] Applied "ASoC: amd: Fix a NULL vs IS_ERR() check in probe" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: amd: Fix a NULL vs IS_ERR() check in probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 83b12c2e1d942459f420490d4219fc1ad38c3620 Mon Sep 17 00:00:00 2001 From: Dan Carpenter Date: Mon, 26 Nov 2018 11:13:07 +0300 Subject: [PATCH] ASoC: amd: Fix a NULL vs IS_ERR() check in probe The platform_device_register_full() function doesn't return NULL, it returns error pointers. Fixes: 7894a7e7ea3d ("ASoC: amd: create ACP3x PCM platform device") Signed-off-by: Dan Carpenter Signed-off-by: Mark Brown --- sound/soc/amd/raven/pci-acp3x.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.19.0.rc2 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/amd/raven/pci-acp3x.c b/sound/soc/amd/raven/pci-acp3x.c index c28457fd9b81..facec2472b34 100644 --- a/sound/soc/amd/raven/pci-acp3x.c +++ b/sound/soc/amd/raven/pci-acp3x.c @@ -97,10 +97,10 @@ static int snd_acp3x_probe(struct pci_dev *pci, pdevinfo.size_data = sizeof(irqflags); adata->pdev = platform_device_register_full(&pdevinfo); - if (!adata->pdev) { + if (IS_ERR(adata->pdev)) { dev_err(&pci->dev, "cannot register %s device\n", pdevinfo.name); - ret = -ENODEV; + ret = PTR_ERR(adata->pdev); goto unmap_mmio; } break;