From patchwork Tue Sep 1 13:57:35 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Camel Guo X-Patchwork-Id: 251214 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A7D97C433E7 for ; Tue, 1 Sep 2020 13:59:00 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E69B206F0 for ; Tue, 1 Sep 2020 13:59:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="lszuLDRu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=axis.com header.i=@axis.com header.b="nh0DXFE3" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E69B206F0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=axis.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id AAC5E16EA; Tue, 1 Sep 2020 15:58:08 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz AAC5E16EA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1598968738; bh=jnmTMI2+1+sj8Fq2xbtJYMyqNAL4OmBGX4EENLRmG/U=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=lszuLDRuIcK8h7+jjM8JOGiAZLGhjkA/AyjAqhaIFkj/ARLCFo9XF9l64K83FZT7a vkfOUFufGVXuoeL8ac7rYXlBnZPOIII/93lRpymVHb+rcFvtML7+fXu/xy7TvxuetB 4kZqezmMZ07ejjls3LP0k9negcDTvvNWmzrZimiw= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 593E2F801DA; Tue, 1 Sep 2020 15:58:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 23627F801DA; Tue, 1 Sep 2020 15:58:06 +0200 (CEST) Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id A6A9BF801DA for ; Tue, 1 Sep 2020 15:57:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz A6A9BF801DA Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=axis.com header.i=@axis.com header.b="nh0DXFE3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axis.com; l=1199; q=dns/txt; s=axis-central1; t=1598968681; x=1630504681; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=SlWuRwEsUGOOrcOy4jOz87uO5umOVIDCT/hBp78/e1c=; b=nh0DXFE3aN8aiv7D/e0hIYxk9nOvnNOn+pGY5XSAYZ3ZiIxA2ndvluHK 961mYI1dCjU6WxNxQL8QqqqqHuasgT4fM4p2bTtHp95ZKB7n2KX5H23Gm CIoX+N6O4CVIAxMPmjfTVfkrsDjtc4kqeeZn2ISKhYJ1O4m5UGePUnDO6 gUFsWrBFstWIHrW1cDDR12dsY+ccGAiLLXR8mN0C/lG37jIkORYc1pfct efZp4iOUUFMnq0E/xa++FU1CfEJ+PhzC3ulqKiVaFoLiiVjnOZ4BQkiri z4Y9gpV+0j4Fhk+aYdfh4BoQQrhCbV2QwlyJ5+Nhzqh3bhLs71fsXyxW7 g==; IronPort-SDR: FNOXj4xYEMBEdlzdI3cWvh4yLFmW7LQ/mba46vkxuXEnfZJXXUaKDzHTzbLhxPc/o9KBfJiH4j YYrTnkxSRTdZLmK+yk8IEzParOm9YsDNfuZP92z1rcK0vcHXUKVZ911an2Kd9jg8IAJf3YGvj+ yduPs7lAvQA5fh+lnfUiuBb9UDH/y3GfakqW304En+sycjcXktfCVPF2qIa8Sf8d1gbH3hUBef IcBF4Zj2vP4/6Jjtw7KBpe86JReYGoTPAGwaGe1JDPAPpKL9cJnsFfmiOEIqxML5lZbAxyv/Fc xMY= X-IronPort-AV: E=Sophos;i="5.76,379,1592863200"; d="scan'208";a="12087816" From: Camel Guo To: , , , , Subject: [PATCH v4] ASoC: tlv320adcx140: Fix accessing uninitialized adcx140->dev Date: Tue, 1 Sep 2020 15:57:35 +0200 Message-ID: <20200901135736.32036-1-camel.guo@axis.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Cc: Camel Guo , alsa-devel@alsa-project.org, kernel@axis.com, linux-kernel@vger.kernel.org, Camel Guo X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" From: Camel Guo In adcx140_i2c_probe, adcx140->dev is accessed before its initialization. This commit fixes this bug. Fixes: 689c7655b50c ("ASoC: tlv320adcx140: Add the tlv320adcx140 codec driver family") Acked-by: Dan Murphy Signed-off-by: Camel Guo --- v4: - Add Acked-By from Dan v3: - Add Fixes tag v2: - Fix typo sound/soc/codecs/tlv320adcx140.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/tlv320adcx140.c b/sound/soc/codecs/tlv320adcx140.c index 5cd50d841177..7ae6ec374be3 100644 --- a/sound/soc/codecs/tlv320adcx140.c +++ b/sound/soc/codecs/tlv320adcx140.c @@ -980,6 +980,8 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, if (!adcx140) return -ENOMEM; + adcx140->dev = &i2c->dev; + adcx140->gpio_reset = devm_gpiod_get_optional(adcx140->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(adcx140->gpio_reset)) @@ -1007,7 +1009,7 @@ static int adcx140_i2c_probe(struct i2c_client *i2c, ret); return ret; } - adcx140->dev = &i2c->dev; + i2c_set_clientdata(i2c, adcx140); return devm_snd_soc_register_component(&i2c->dev,