From patchwork Tue Feb 8 08:42:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nikita Yushchenko X-Patchwork-Id: 541843 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7999CC433F5 for ; Tue, 8 Feb 2022 08:44:20 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 871C31767; Tue, 8 Feb 2022 09:43:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 871C31767 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1644309858; bh=d47q9OeNENJ3M7TkHjgzlTEZMDeqeOoOJ/Y0bzXL9d8=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=AjqcV+BrAHElBoEtInhmy23puV7kNhNcE2ULoydIn/ljtQOFb7XOk3UwrXkb/5Od+ fnn9uVZp4x8qlhpHyYW5AFurr1jRxnNadE1z/ret/TuHO2i4/scWcWpxijf6/2ob/6 Pgj++DfGH8kGL2t1Ltjs5NlPOzSE0io6aU/xj8Ng= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id B63C1F80508; Tue, 8 Feb 2022 09:42:52 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9905EF80518; Tue, 8 Feb 2022 09:42:51 +0100 (CET) Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 32F49F800EB for ; Tue, 8 Feb 2022 09:42:44 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 32F49F800EB Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=cogentembedded-com.20210112.gappssmtp.com header.i=@cogentembedded-com.20210112.gappssmtp.com header.b="SfuD4cs0" Received: by mail-lf1-x131.google.com with SMTP id m18so3493646lfq.4 for ; Tue, 08 Feb 2022 00:42:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20210112.gappssmtp.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=zAs8Yatfb5icRPps4ZaWoN14zXIRZ/fIsgdyAPNGOb4=; b=SfuD4cs0uNn4xZ7k3QGNDYawj1deQWy1OQ/+n1lA0GxfdK0Q1uRJB2bg5CtViFAkJ8 icuGxWaJ7CaR8hyZy2JGgU5BKVeUCabeHxN5mCuHSf/f1xHANr+o3XzwBDHbIM6I7EsT UXq6UNMwG5wreMRA8Tj9Bw5jvP4y6S0y09CDEpfXbPEuzmFvyC/Fm0h/aGMj+67HhD2g vhEjZv2aihkNPwK5knvQFdxoxIGS1LUVQKkxiWULZ8qkIj9//0gyXkpSp6BBpyKTkbOS rUuO1rSwTm5r/vnk4Bh4fROhGrycSBPystmyVqUeFfLrszN7qcp2BoDdv6kks9ApsWAd mhRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=zAs8Yatfb5icRPps4ZaWoN14zXIRZ/fIsgdyAPNGOb4=; b=EbtZIKnkuZV5ITDwEyts+QIDJMboDoiA9CNrJWv7UMSb4evFLznked2fqpic8EA29+ NVlSgqub+0228WiGxamJwHWS2Qdz7XikLcnn0XHGZjxEiK840gWpYEGvpgaDhof7QWEt LQSXGQFqjST/q0K8vH61bBu4G/1IUPnXNNDRiQhVqrhmwkRk8+G3YEGRjHeMTXla7Bt+ 07aX7wNKtLGsVb8VDDxaJ+acpMzNDP4ZEei0NF8inavkq5oYY2dJxfieRLC7rNswmO8i s7fQYjjSBUiMmEMgRPGK7RFqBKoMEBMjxHmZv4oGC4GzsqtR/XCC0GpvOWi7q2ywFuNd L8vQ== X-Gm-Message-State: AOAM5310AOaxS84nKO2/j1xnpqmA9bx2+o97xbM8pRZffHokwdwbGeai 3pb6evH7fIL7d1b9uy6GxF/OHg== X-Google-Smtp-Source: ABdhPJyScCD/zHSIZnBLnovm2lIeHylddool/rNUHBAjMxezHHhiSO5YvqwnGzUQRB10qdhFJgQPnA== X-Received: by 2002:ac2:560a:: with SMTP id v10mr2359890lfd.260.1644309761652; Tue, 08 Feb 2022 00:42:41 -0800 (PST) Received: from cobook.home (nikaet.starlink.ru. [94.141.168.29]) by smtp.gmail.com with ESMTPSA id o12sm1830361lfu.96.2022.02.08.00.42.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 00:42:41 -0800 (PST) From: Nikita Yushchenko To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Kuninori Morimoto Subject: [PATCH 1/4] ASoC: pcm3168a: cleanup unintuitive mask usage Date: Tue, 8 Feb 2022 11:42:17 +0300 Message-Id: <20220208084220.1289836-2-nikita.yoush@cogentembedded.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220208084220.1289836-1-nikita.yoush@cogentembedded.com> References: <20220208084220.1289836-1-nikita.yoush@cogentembedded.com> MIME-Version: 1.0 Cc: Nikita Yushchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" When checking if the requested parameters are supported, the driver uses PCM3168A_FMT_DSP_MASK to check for PCM3168A_FMT_DSP_* values. However, formally not only PCM3168A_FMT_DSP_* values match that condition, PCM3168A_FMT_I2S_TDM and PCM3168A_FMT_LEFT_J_TDM also do. The check still gives correct result because those extra values can't be in 'fmt' at the check location. Still, to make the code less cryptic, better to compare 'fmt' with PCM3168A_FMT_DSP_* values explicitly. Signed-off-by: Nikita Yushchenko --- sound/soc/codecs/pcm3168a.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/pcm3168a.c b/sound/soc/codecs/pcm3168a.c index fdf92c8b28e1..987c5845f769 100644 --- a/sound/soc/codecs/pcm3168a.c +++ b/sound/soc/codecs/pcm3168a.c @@ -33,7 +33,6 @@ #define PCM3168A_FMT_DSP_B 0x5 #define PCM3168A_FMT_I2S_TDM 0x6 #define PCM3168A_FMT_LEFT_J_TDM 0x7 -#define PCM3168A_FMT_DSP_MASK 0x4 #define PCM3168A_NUM_SUPPLIES 6 static const char *const pcm3168a_supply_names[PCM3168A_NUM_SUPPLIES] = { @@ -511,7 +510,8 @@ static int pcm3168a_hw_params(struct snd_pcm_substream *substream, fmt = PCM3168A_FMT_RIGHT_J_16; break; case 24: - if (master_mode || (fmt & PCM3168A_FMT_DSP_MASK)) { + if (master_mode || (fmt == PCM3168A_FMT_DSP_A) || + (fmt == PCM3168A_FMT_DSP_B)) { dev_err(component->dev, "24-bit slots not supported in master mode, or slave mode using DSP\n"); return -EINVAL; }