From patchwork Thu Mar 31 21:50:03 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakob Koschel X-Patchwork-Id: 555289 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E0E2BC433FE for ; Thu, 31 Mar 2022 21:54:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 2C9F118DE; Thu, 31 Mar 2022 23:53:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 2C9F118DE DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1648763670; bh=ifpWWypXortg/rGDlOym9wXGA7cugLMS1PqYp1hkuN0=; h=From:To:Subject:Date:In-Reply-To:References:Cc:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=pSGZKIP/wrBAjjIFtaOebmCF66TrfdFWxyHRa1gObe5qZs0F7Qy8djvrWsR6bDX7G V30WKyBy7YgGlWPTWZnImY/g7lD2aQyxklta03E2ZNFzR0shSzkP9MJDSNaiKOpOcV f02VVZV5mTR9EVjUIG3NJn2pkDhITLBzokScscB8= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 3280DF804BB; Thu, 31 Mar 2022 23:53:08 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2EC6CF804AE; Thu, 31 Mar 2022 23:53:02 +0200 (CEST) Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 3D374F800E4 for ; Thu, 31 Mar 2022 23:52:58 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 3D374F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VQSaHJzJ" Received: by mail-ej1-x630.google.com with SMTP id j15so2003719eje.9 for ; Thu, 31 Mar 2022 14:52:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QOImAANTWLBikn8WE3acPmaj6Gy0UFu59bmhhFGIeCA=; b=VQSaHJzJLRFaxfS/H8mgdqxOLx5qp1cgKAzL60yVLDlMeAt8VGhJ9dkvSo8sse5peb boPtfzWnd11zFz27+iSxjTF4FB3YXcvxCT+y5FxIQXjsDIGZGlrAhjAUt9Gojhs/ydoV iRq25wsDAnQkMPcHv0/3gqrPQJqkQqnelapWUf1mTwoNfW/NUCQK1omIjnmbWosXVlbC h5SpKhE16NeouY/7uihnCR6OXqqIZ6MiXayAqcOpsHk8L7jbpyZ/itHHQNd+sB4jvelb 5E3hF9MNJIokJCh19DtkusmD9+MQFxQTeDbp1vVfR/7mDfIN14lven09Sut3cK8Ri4Xm 00IA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QOImAANTWLBikn8WE3acPmaj6Gy0UFu59bmhhFGIeCA=; b=B4cZBEDh+gtv9jOVB3sAgivQsLNGmh7Xm1gfYsNpWTW5eOrVdj2MoWmyGT6CCfCSu/ VuPEG/evQcGuIudYeR0/3iEJ/6y2HAMNLYR8EXWa7HAv0jtgmlFa9ljs43HOVd/GPG/J +CDIRpt3hmaZRrqoPitN3KVAE9OsGWrnWSc+LvuC/qfSzvrliZu57c+64kJbMozAbVMr qckRU9fd/X1/no4xTTOPMF2lA6y6i9YK7r4UV9FRdmIoOculKQ6QhZPTH9XQVl/vbuzi U3PJ4K7HxhkgoSZeGZqh1QR4HLNO0YXuZoLpvOsspXy2PxbgsnjOqhcmkOPKnZat/VNl fjyA== X-Gm-Message-State: AOAM531wNb9lwlO7IrPJeI8hW/Nduj166e69oovh+0iDouoSWe1ehU/z BUnrE1SbMhswKPA9TaLD0Xs= X-Google-Smtp-Source: ABdhPJwhW6AYtGNMAVFbxpGjx9UHVrI4ApY9BLlL1tGNDzt2uyxR6JIV8D6VbtshApQXftpkkWYqOQ== X-Received: by 2002:a17:906:32cf:b0:6d5:83bc:e962 with SMTP id k15-20020a17090632cf00b006d583bce962mr6882166ejk.108.1648763577157; Thu, 31 Mar 2022 14:52:57 -0700 (PDT) Received: from localhost.localdomain (i130160.upc-i.chello.nl. [62.195.130.160]) by smtp.googlemail.com with ESMTPSA id g20-20020aa7c594000000b004194b07bbfasm299980edq.10.2022.03.31.14.52.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 31 Mar 2022 14:52:56 -0700 (PDT) From: Jakob Koschel To: Codrin Ciubotariu Subject: [PATCH 3/3] ASoC: atmel-ssc: replace usage of found with dedicated list iterator variable Date: Thu, 31 Mar 2022 23:50:03 +0200 Message-Id: <20220331215003.882143-3-jakobkoschel@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220331215003.882143-1-jakobkoschel@gmail.com> References: <20220331215003.882143-1-jakobkoschel@gmail.com> MIME-Version: 1.0 Cc: alsa-devel@alsa-project.org, Cezary Rojewski , Jie Yang , Alexandre Belloni , Takashi Iwai , Liam Girdwood , Cristiano Giuffrida , Chunyan Zhang , Pierre-Louis Bossart , "Bos, H.J." , Yang Yingliang , Orson Zhai , Arnd Bergmann , Nicolas Ferre , Brian Johannesmeyer , Mark Brown , Jakob Koschel , linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Baolin Wang , Claudiu Beznea , Mike Rapoport X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" To move the list iterator variable into the list_for_each_entry_*() macro in the future it should be avoided to use the list iterator variable after the loop body. To *never* use the list iterator variable after the loop it was concluded to use a separate iterator variable instead of a found boolean [1]. This removes the need to use a found variable and simply checking if the variable was set, can determine if the break/goto was hit. Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/ [1] Signed-off-by: Jakob Koschel Reviewed-by: Codrin Ciubotariu --- drivers/misc/atmel-ssc.c | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/drivers/misc/atmel-ssc.c b/drivers/misc/atmel-ssc.c index d6cd5537126c..343e25555fbb 100644 --- a/drivers/misc/atmel-ssc.c +++ b/drivers/misc/atmel-ssc.c @@ -25,25 +25,24 @@ static LIST_HEAD(ssc_list); struct ssc_device *ssc_request(unsigned int ssc_num) { - int ssc_valid = 0; - struct ssc_device *ssc; + struct ssc_device *ssc = NULL, *iter; mutex_lock(&user_lock); - list_for_each_entry(ssc, &ssc_list, list) { - if (ssc->pdev->dev.of_node) { - if (of_alias_get_id(ssc->pdev->dev.of_node, "ssc") + list_for_each_entry(iter, &ssc_list, list) { + if (iter->pdev->dev.of_node) { + if (of_alias_get_id(iter->pdev->dev.of_node, "ssc") == ssc_num) { - ssc->pdev->id = ssc_num; - ssc_valid = 1; + iter->pdev->id = ssc_num; + ssc = iter; break; } - } else if (ssc->pdev->id == ssc_num) { - ssc_valid = 1; + } else if (iter->pdev->id == ssc_num) { + ssc = iter; break; } } - if (!ssc_valid) { + if (!ssc) { mutex_unlock(&user_lock); pr_err("ssc: ssc%d platform device is missing\n", ssc_num); return ERR_PTR(-ENODEV);