From patchwork Thu Nov 17 23:21:20 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 625502 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9D00C433FE for ; Thu, 17 Nov 2022 23:22:49 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C97AE16CD; Fri, 18 Nov 2022 00:21:57 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C97AE16CD DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1668727367; bh=6R8tOMoGkJkz15CqL/hdQivBJ1emg39V843lU14YEns=; h=From:To:Subject:Date:Cc:List-Id:List-Unsubscribe:List-Archive: List-Post:List-Help:List-Subscribe:From; b=VGMqWJxF/lJ6UTH+CVt01jMNfPwfTfgnn9hgUYTx/+IEq2U+/bthn/1EN4hp3qop/ 57HfOCCJx5Jc51hsE1ebjH+gF5JKwG0bMSezLbgKBJPoLGdvVxIfsugyTlR27Sc2wa yEShVS16QpytNwDIV+uzXW5/rDLQak1Qpwepjwm4= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 8171FF8015B; Fri, 18 Nov 2022 00:21:57 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3F269F8025A; Fri, 18 Nov 2022 00:21:55 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 9B3B6F800B5 for ; Fri, 18 Nov 2022 00:21:47 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 9B3B6F800B5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="YLd7gK/+" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1668727309; x=1700263309; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=6R8tOMoGkJkz15CqL/hdQivBJ1emg39V843lU14YEns=; b=YLd7gK/+GTAMQjeCJfrGANEarVg720tF3JR9i+9LGbHl+9r0+FjKATpA hgVRTpljx5O9kJWKfR0uIscq+UvV6+RjzoeoGDsPWR9Gk/TZY47cUVW19 ND/txALnOj2ViPAXcYk4r07TpqsEG6eWDPtSf4HT3Ev9IlhPVNBvt/Cvn m8Qaqqd3T/gLac0TOhaN+NoGBaaWPQHj8fgstKMK3DIkURTGwwKngbTJT KuFCpx8XEeY6JMxdwtskf3shtpaTyJePSBk+0qVleXKDUmzNs8CROulFT /FzEG344jTCx6pP0f6Ai0FuapjIzyJ4s4SSYD0D0UuJYDuo/Ht/S6SlCU A==; X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="314153292" X-IronPort-AV: E=Sophos;i="5.96,172,1665471600"; d="scan'208";a="314153292" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 15:21:44 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10534"; a="969064252" X-IronPort-AV: E=Sophos;i="5.96,172,1665471600"; d="scan'208";a="969064252" Received: from ticela-or-133.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.0.242]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Nov 2022 15:21:44 -0800 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Subject: [PATCH] ASoC: SOF: dai: move AMD_HS to end of list to restore backwards-compatibility Date: Thu, 17 Nov 2022 17:21:20 -0600 Message-Id: <20221117232120.112639-1-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Cc: tiwai@suse.de, Basavaraj Hiregoudar , Pierre-Louis Bossart , broonie@kernel.org, V sujith kumar Reddy , Daniel Baluta , AngeloGioacchino Del Regno X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The addition of AMD_HS breaks Mediatek platforms by using an index previously allocated to Mediatek. This is a backwards-compatibility issue and needs to be fixed. All firmware released by AMD needs to be re-generated and re-distributed. Fixes: ed2562c64b4f ("ASoC: SOF: Adding amd HS functionality to the sof core") Link: https://github.com/thesofproject/sof/issues/6615 Link: https://lore.kernel.org/alsa-devel/36a45c7a-820a-7675-d740-c0e83ae2c417@collabora.com/ Reported-by: AngeloGioacchino Del Regno Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Daniel Baluta Reviewed-by: Basavaraj Hiregoudar Reviewed-by: V sujith kumar Reddy Signed-off-by: Pierre-Louis Bossart --- include/sound/sof/dai.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/sound/sof/dai.h b/include/sound/sof/dai.h index 83fd81c82e4c1..9fbd3832bcdc7 100644 --- a/include/sound/sof/dai.h +++ b/include/sound/sof/dai.h @@ -84,8 +84,8 @@ enum sof_ipc_dai_type { SOF_DAI_AMD_BT, /**< AMD ACP BT*/ SOF_DAI_AMD_SP, /**< AMD ACP SP */ SOF_DAI_AMD_DMIC, /**< AMD ACP DMIC */ - SOF_DAI_AMD_HS, /**< Amd HS */ SOF_DAI_MEDIATEK_AFE, /**< Mediatek AFE */ + SOF_DAI_AMD_HS, /**< Amd HS */ }; /* general purpose DAI configuration */