From patchwork Fri May 12 17:46:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 681841 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2D522C77B75 for ; Fri, 12 May 2023 17:49:04 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 13755EA4; Fri, 12 May 2023 19:48:12 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 13755EA4 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1683913742; bh=GPyB5hYoL6NUcQCPdbqVoFTExK4bHxVxYeWygZQmxs0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=jkwAe+SpomSDuyY/0e25bxW2fvK86Jre5fA2Az4N1bITe9XhFfxW+aozYrkxjNMjH NCpZWqQP/m1QjdOZoPSrgToJ+yv6cgyfd5QQS4cdjUsamzWXE6a1lU0IpFDIleDSxW SYwae0pL/rEE6ueExWE9RbXEBBm/JV8HD1T3MErg= Received: by alsa1.perex.cz (Postfix, from userid 50401) id C5025F802E8; Fri, 12 May 2023 19:48:04 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 775ACF8053D; Fri, 12 May 2023 19:48:04 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id B2FC4F80557; Fri, 12 May 2023 19:46:30 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id CDBACF80534 for ; Fri, 12 May 2023 19:46:25 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz CDBACF80534 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=f3ml3dBf DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1683913587; x=1715449587; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=GPyB5hYoL6NUcQCPdbqVoFTExK4bHxVxYeWygZQmxs0=; b=f3ml3dBfgySuAIqKl0yPhUvGyIvVcFckjiYKydTlqrSBRgRwrzSJifm7 GxHgMaQcFFmHQVmqNnJojXw3/3hR29MjRyaXuUZaMdBLpo4U0z7zB1Jce Vuddfp1ar3M/x4R6J+NG3arsQEbkG0mB+ND8nKun2LHqT1akeV6Gdr0BE ME/fzqH4VqhPPCekspMgaxWMxFIRW5C2t/VTcRLzsZs3gIzkKQ8auR9EC skmJaHdAz63y93JIjsczFmklo76qkPWPnMU+rA1zqoM02T7V4sdqKgugZ eFonj8jKx5jUnnlV0h7opMf6fSfDfBJ7iyOG6xTAhhFuAr+6/kGBw5gWl w==; X-IronPort-AV: E=McAfee;i="6600,9927,10708"; a="349688073" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="349688073" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 10:46:24 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10708"; a="812167797" X-IronPort-AV: E=Sophos;i="5.99,269,1677571200"; d="scan'208";a="812167797" Received: from winkelru-mobl.amr.corp.intel.com (HELO pbossart-mobl3.intel.com) ([10.212.144.249]) by fmsmga002-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2023 10:46:23 -0700 From: Pierre-Louis Bossart To: alsa-devel@alsa-project.org Cc: tiwai@suse.de, broonie@kernel.org, vkoul@kernel.org, Pierre-Louis Bossart , Bard Liao , Rander Wang , Ranjani Sridharan Subject: [PATCH 5/6] ASoC: SOF: Intel: hda-mlink: initialize instance_offset member Date: Fri, 12 May 2023 12:46:10 -0500 Message-Id: <20230512174611.84372-6-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230512174611.84372-1-pierre-louis.bossart@linux.intel.com> References: <20230512174611.84372-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: FWKUGUI4SNFRULNPTMQ3R65EBPJXHEPC X-Message-ID-Hash: FWKUGUI4SNFRULNPTMQ3R65EBPJXHEPC X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We defined the values but never initialized it for SoundWire/SSP, fix this miss. A Fixes: tag is not provided as instance_offset was not used so far, so nothing was really broken. This patch is only required for the SoundWire support in the following patch. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao Reviewed-by: Rander Wang Reviewed-by: Ranjani Sridharan --- sound/soc/sof/intel/hda-mlink.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/sof/intel/hda-mlink.c b/sound/soc/sof/intel/hda-mlink.c index c540b1d75451..2d0c5d5914b1 100644 --- a/sound/soc/sof/intel/hda-mlink.c +++ b/sound/soc/sof/intel/hda-mlink.c @@ -140,6 +140,7 @@ static int hdaml_lnk_enum(struct device *dev, struct hdac_ext2_link *h2link, switch (h2link->elid) { case AZX_REG_ML_LEPTR_ID_SDW: + h2link->instance_offset = AZX_REG_SDW_INSTANCE_OFFSET; h2link->shim_offset = AZX_REG_SDW_SHIM_OFFSET; h2link->ip_offset = AZX_REG_SDW_IP_OFFSET; h2link->shim_vs_offset = AZX_REG_SDW_VS_SHIM_OFFSET; @@ -154,6 +155,7 @@ static int hdaml_lnk_enum(struct device *dev, struct hdac_ext2_link *h2link, link_idx, base_offset); break; case AZX_REG_ML_LEPTR_ID_INTEL_SSP: + h2link->instance_offset = AZX_REG_INTEL_SSP_INSTANCE_OFFSET; h2link->shim_offset = AZX_REG_INTEL_SSP_SHIM_OFFSET; h2link->ip_offset = AZX_REG_INTEL_SSP_IP_OFFSET; h2link->shim_vs_offset = AZX_REG_INTEL_SSP_VS_SHIM_OFFSET;