From patchwork Wed Nov 29 21:28:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Linus Walleij X-Patchwork-Id: 748103 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67E76C4167B for ; Wed, 29 Nov 2023 21:32:06 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5A025DED; Wed, 29 Nov 2023 22:31:54 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5A025DED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1701293524; bh=p7OgoyRtcwYF2aovGgzjdn3WOBNxzxmrE8N7rbGS4Ok=; h=From:Date:Subject:References:In-Reply-To:To:Cc:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=N4U+MylpONOZdj825PTXrM861y7jvI8uoIvLMSrKoC2yU84zIr7x1uUn4ScqaxpFW wJk3X8AIZ++nrqyjOsO644QdPuWiQKAZ9oz2nfiDlyLjDcqmrCD7403xd9UyPDgkXR /vgyxQvNYFZOxivgS/7b3u/dgyoAdzp9zBbaRUAI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id BD0B8F806D8; Wed, 29 Nov 2023 22:29:46 +0100 (CET) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 0AB04F806D7; Wed, 29 Nov 2023 22:29:46 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 63CB3F80570; Wed, 29 Nov 2023 22:29:40 +0100 (CET) Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BF913F801D5 for ; Wed, 29 Nov 2023 22:28:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BF913F801D5 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=linaro.org header.i=@linaro.org header.a=rsa-sha256 header.s=google header.b=k501R2Gs Received: by mail-lj1-x22b.google.com with SMTP id 38308e7fff4ca-2c9b7bd6fffso3725451fa.3 for ; Wed, 29 Nov 2023 13:28:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1701293324; x=1701898124; darn=alsa-project.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gxA1zyyyxC7/6y6RpRxRpLmaP1pTY49ZhzDzMcyXsOY=; b=k501R2GsK2iOPcAsjXhIkWSmoLzNSNlhmaTt6ouxWofPzpN9Znr2KlNO9/LKeLSczx 94aBL2JS6x/+j2J7Y4a16nwuj4olVds1sGOG90u0iRC+db/9X46JwwKnHnAbUs2/yQCM KM7348xw4Ohjkixa1Vh+9W2oCK3LR2hgGGVlU/5XBAvysTo/auHshwc3bMtO/y31x9mT GAcv2XRdH8/yYkpZnKz66oCCwyhhblz3ou33TgXLksb9lTwERJsWTMKfP57YFbrznJNz CNd+RpCMwpDFlwYc+pGUhYuERlosbgxj93YrenBNU9DFCNDE3OobttbnWol0asCNAMUA mysA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701293324; x=1701898124; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gxA1zyyyxC7/6y6RpRxRpLmaP1pTY49ZhzDzMcyXsOY=; b=ClSMb2+8SFXgMUgOjzRpqfGOh4L/ZVZ3JKIH1W/ma0HpsvQjcG/mMFB0bM/kCJj6ne OZXrI3Zrc9psVQrUBnuXhWNckw5AAniCoYGLrMqbqaRLNlSjIBHUizNFbiOTT2/3eIZh jyTjVbeW3Gq1OtcfVYazPqxpet55BYYNW2pS98qMV5VV13s95RsHY2WbdxPkplNfpGUP jvVn25lA35HtxOJAjsjtRLWh6kZFRHSHSeDico/mUJC91PrN5IysYRL0uodIMN9k6gk2 k4ZCmio7WHqJF43mox5ZqHOjIC11bPqjNsIhRyibqdeFT15hbfTxfDULfYIC9Kom9qJR YqMg== X-Gm-Message-State: AOJu0Yxg2NTB2GZptPGdoEjGyWAr/0Rw9JLM/sEjK7qGvUQ1k8YVF+hu LQvzdbPlraTKygIUOdHakGiI4w== X-Google-Smtp-Source: AGHT+IH2XK3VmzyApGKH2dJRP5mNU0HGdkujQYH19VxvKR71Nk9rdeM2oIikSY71v9WV2Mt3FvghIA== X-Received: by 2002:a2e:8709:0:b0:2c9:c192:42a8 with SMTP id m9-20020a2e8709000000b002c9c19242a8mr1654073lji.38.1701293324577; Wed, 29 Nov 2023 13:28:44 -0800 (PST) Received: from [127.0.1.1] ([85.235.12.238]) by smtp.gmail.com with ESMTPSA id b5-20020a05651c032500b002bcdbfe36b9sm2106196ljp.111.2023.11.29.13.28.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 13:28:44 -0800 (PST) From: Linus Walleij Date: Wed, 29 Nov 2023 22:28:39 +0100 Subject: [PATCH 03/10] ASoC: cs35l34: Fix GPIO name and drop legacy include MIME-Version: 1.0 Message-Id: <20231129-descriptors-sound-cirrus-v1-3-31aa74425ff8@linaro.org> References: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> In-Reply-To: <20231129-descriptors-sound-cirrus-v1-0-31aa74425ff8@linaro.org> To: Paul Handrigan , James Schulman , David Rhodes , Richard Fitzgerald , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Hartley Sweeten , Alexander Sverdlin , Nikita Shubin Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linus Walleij X-Mailer: b4 0.12.4 Message-ID-Hash: IHAO4VVFLJR752A54HOIY2JZPP3JFVVT X-Message-ID-Hash: IHAO4VVFLJR752A54HOIY2JZPP3JFVVT X-MailFrom: linus.walleij@linaro.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: This driver includes the legacy GPIO APIs and but does not use any symbols from any of them. Drop the includes. Further the driver is requesting "reset-gpios" rather than just "gpios" from the GPIO framework. This is wrong because the gpiolib core will add "-gpios" before processing the request from e.g. device tree. Drop the suffix. The last problem means that the optional RESET GPIO has never been properly retrieved and used even if it existed, but nobody noticed. Fixes: c1124c09e103 ("ASoC: cs35l34: Initial commit of the cs35l34 CODEC driver.") Signed-off-by: Linus Walleij --- sound/soc/codecs/cs35l34.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index e5871736fa29..cca59de66b73 100644 --- a/sound/soc/codecs/cs35l34.c +++ b/sound/soc/codecs/cs35l34.c @@ -20,14 +20,12 @@ #include #include #include -#include #include #include #include #include #include #include -#include #include #include #include @@ -1061,7 +1059,7 @@ static int cs35l34_i2c_probe(struct i2c_client *i2c_client) dev_err(&i2c_client->dev, "Failed to request IRQ: %d\n", ret); cs35l34->reset_gpio = devm_gpiod_get_optional(&i2c_client->dev, - "reset-gpios", GPIOD_OUT_LOW); + "reset", GPIOD_OUT_LOW); if (IS_ERR(cs35l34->reset_gpio)) { ret = PTR_ERR(cs35l34->reset_gpio); goto err_regulator;