From patchwork Tue Apr 2 14:59:59 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 785148 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9EC2CC6FD1F for ; Tue, 2 Apr 2024 15:02:17 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C74642C20; Tue, 2 Apr 2024 17:02:05 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C74642C20 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1712070135; bh=XC/KIBuVWENi+nZcHSHtH5poqdXkQwX6utx5Af8jDo4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=phyQ5REs1LXChWZvGnVRBPxyPONepMhFMqkhF3W6RwWiE5kA4kmoBaLHkN6VpQkFT eiMT13vQcnGH10qjDzmLdX6Z7t5dflu2ZlFlOSw796TE9qtkQpVXI5BkmR6hAN0yA8 6/yLBgJBcqEQ8sLMJAkmlXJ6bhx0sElXEpke77bI= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 9782FF805BD; Tue, 2 Apr 2024 17:01:46 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id DBE64F805C8; Tue, 2 Apr 2024 17:01:45 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2C655F8016E; Tue, 2 Apr 2024 17:01:41 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.15]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 07F9AF8020D for ; Tue, 2 Apr 2024 17:00:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 07F9AF8020D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=VndpswXJ DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712070023; x=1743606023; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=XC/KIBuVWENi+nZcHSHtH5poqdXkQwX6utx5Af8jDo4=; b=VndpswXJGxFyaZJlYnh548HuxDTo7WeJko2LAROkJh+Kf6MukjzY5E5L BDXqzA94SHOzhFW5P7dxK14qMCHb+6Q6Wc8jwRdtjEbmJfFzAbcwyI2SF qcVnvO7XYsOMrpbNriuVYPuy990JBA1UIoxVpI4zNYuEiFi6fy+9TyoIv 2mOy3IBG1b+AlKuQdjWbfl5X2dHoD7gNj7cWsVo8Ud5QzgxYTkbtThOio vhnBJFqqdLVgzRicLCMhRt4O64qdnUB5ONcah88pAyMhHN1xo2/e3/7hp khYvrnO3Xtxp1adouVNxH6sFW6fz/g6NaOmFViAOCe6NSqc/QexCyoizu Q==; X-CSE-ConnectionGUID: KlSojDX2TZSzqW/EIyVa5Q== X-CSE-MsgGUID: dVt8299cSGy9B0TPIk7LOA== X-IronPort-AV: E=McAfee;i="6600,9927,11032"; a="7433835" X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="7433835" Received: from fmviesa003.fm.intel.com ([10.60.135.143]) by fmvoesa109.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 08:00:13 -0700 X-CSE-ConnectionGUID: 7E16P8RbQUSCSgoWUteSSw== X-CSE-MsgGUID: GOPdG6s1RlyM+OvXzqjG8g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,175,1708416000"; d="scan'208";a="22558031" Received: from skhare-mobl5.amr.corp.intel.com (HELO pbossart-mobl6.intel.com) ([10.212.8.83]) by fmviesa003-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Apr 2024 08:00:14 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Pierre-Louis Bossart , Bard Liao Subject: [PATCH 4/4] ASoC: SOF: ipc4-topology: remove shadowed variable Date: Tue, 2 Apr 2024 09:59:59 -0500 Message-Id: <20240402145959.172619-5-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240402145959.172619-1-pierre-louis.bossart@linux.intel.com> References: <20240402145959.172619-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: 2XPAXZISXEOAGZNFGYLYMDUZ2BNNKXX3 X-Message-ID-Hash: 2XPAXZISXEOAGZNFGYLYMDUZ2BNNKXX3 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Cppcheck reports this: sound/soc/sof/ipc4-topology.c:569:23: style: Local variable 'sdev' shadows outer variable [shadowVariable] struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp); ^ sound/soc/sof/ipc4-topology.c:512:22: note: Shadowed declaration struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp); ^ sound/soc/sof/ipc4-topology.c:569:23: note: Shadow variable struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp); ^ Remove shadowed variable. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Bard Liao --- sound/soc/sof/ipc4-topology.c | 1 - 1 file changed, 1 deletion(-) diff --git a/sound/soc/sof/ipc4-topology.c b/sound/soc/sof/ipc4-topology.c index 5cca05842126..427f186ddc11 100644 --- a/sound/soc/sof/ipc4-topology.c +++ b/sound/soc/sof/ipc4-topology.c @@ -586,7 +586,6 @@ static int sof_ipc4_widget_setup_comp_dai(struct snd_sof_widget *swidget) switch (ipc4_copier->dai_type) { case SOF_DAI_INTEL_ALH: { - struct snd_sof_dev *sdev = snd_soc_component_get_drvdata(scomp); struct sof_ipc4_alh_configuration_blob *blob; struct snd_soc_dapm_path *p; struct snd_sof_widget *w;