From patchwork Thu Apr 4 18:54:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 786261 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 76383CD1284 for ; Thu, 4 Apr 2024 18:56:51 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id D5C482CF7; Thu, 4 Apr 2024 20:56:39 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz D5C482CF7 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1712257009; bh=afNioHGncXnRJlF/ZevFtsEpxu9GMprGXgRv6adODQM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=dYpk3eqK8uE4VWIDISXBVJEEnODlczcYppMr1oUyW9F/26St4+SUpwUkMC+gghpgG jItk8oB7wj+H+3kN504WhqMt8LIc7vEd6yN/I7/VdVW6vlVLBgrIK1nhoxcA0j4RsY 3b+aLjRtkOCzitgXjO8PTVG17O31GZd6kOkQEWFE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 371D9F80635; Thu, 4 Apr 2024 20:55:25 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 27B1CF8064C; Thu, 4 Apr 2024 20:55:25 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 1C485F805E1; Thu, 4 Apr 2024 20:55:17 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 51614F8020D for ; Thu, 4 Apr 2024 20:55:03 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 51614F8020D Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=K4iS1xnB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1712256905; x=1743792905; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=afNioHGncXnRJlF/ZevFtsEpxu9GMprGXgRv6adODQM=; b=K4iS1xnBKCmhV99J6JQHSuInfYU9PpooMIK8ktU1MZWraWL89m5Xrw7J s1E9ouuDZtJzzL1GkzWY2rt3Nw99FvfidLSxZYjibVPiAgi3z8jteQI1w oCjd+4wtWqhGmcEuD9wWd199tNKlb1v/gJMBClmGhJ7vo/B8iehtaKGd+ 2mIPL/HBiKLs9J8bwB612X6/rxgCn9xhxcG4/80F0sd2/4FyrkhtXgg41 Xnm0Rat3s8rwr6t0XO7PMv69qKOzj32I57HmQrbpwoM8/bof0jDtzJpG1 bQEoEDz4Fl57blYORresP+VZGsZU9AQaTKgai458jTEnzGjV/KYsyBZK2 g==; X-CSE-ConnectionGUID: fOl7dinUTrWMDIFdMlEv1g== X-CSE-MsgGUID: UFqex+kRT8+NMe4apUzWUQ== X-IronPort-AV: E=McAfee;i="6600,9927,11034"; a="7432810" X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="7432810" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa111.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 11:55:01 -0700 X-CSE-ConnectionGUID: aHo12uyoSGS26cpp5olWEg== X-CSE-MsgGUID: C10+nUKDTGuU152yUCmKqg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,179,1708416000"; d="scan'208";a="23574633" Received: from sparrish-mobl1.amr.corp.intel.com (HELO pbossart-mobl6.intel.com) ([10.212.119.106]) by ORVIESA003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Apr 2024 11:55:00 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, Pierre-Louis Bossart , =?utf-8?q?P?= =?utf-8?q?=C3=A9ter_Ujfalusi?= , Rander Wang , Ranjani Sridharan Subject: [PATCH 4/4] ASoC: SOF: Intel: hda-stream: clarify comment Date: Thu, 4 Apr 2024 13:54:48 -0500 Message-Id: <20240404185448.136157-5-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20240404185448.136157-1-pierre-louis.bossart@linux.intel.com> References: <20240404185448.136157-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: CKYX3X7P2YHSIGY4MD2BN2NHQICN4N5E X-Message-ID-Hash: CKYX3X7P2YHSIGY4MD2BN2NHQICN4N5E X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: The Yoda grammar and multiple negatives are unclear. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Reviewed-by: Rander Wang Reviewed-by: Ranjani Sridharan --- sound/soc/sof/intel/hda-stream.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/sof/intel/hda-stream.c b/sound/soc/sof/intel/hda-stream.c index 76c33795ade4..91b1371745e6 100644 --- a/sound/soc/sof/intel/hda-stream.c +++ b/sound/soc/sof/intel/hda-stream.c @@ -785,7 +785,7 @@ static bool hda_dsp_stream_check(struct hdac_bus *bus, u32 status) continue; } - /* Inform ALSA only in case not do that with IPC */ + /* Inform ALSA only if the IPC position is not used */ if (s->substream && sof_hda->no_ipc_position) { snd_sof_pcm_period_elapsed(s->substream); } else if (s->cstream) {