From patchwork Sat Apr 6 06:48:14 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oswald Buddenhagen X-Patchwork-Id: 786734 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1678FCD128A for ; Sat, 6 Apr 2024 06:53:55 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id BD81F2D1A; Sat, 6 Apr 2024 08:53:43 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz BD81F2D1A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1712386433; bh=b9NU+IoPft5NMYDWxh1oqo91o5gSbghKURjiIckXI1Y=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=q5zxoVcYApRcKTmpfCCtwvetJuEvp6eDxVH1BZN2rGvS6e7XvqZTpZRk6D4Z2pr2C Vv9xT0eq3DAJe4sPyiZ91eT4m9ue5YdN4UPegdmELjCc7+sCh4A7mponuD8mdUqgfH QA/n1EpJmoD/09bpeGUbOl6djRUOg/PdPSNXnmGw= Received: by alsa1.perex.cz (Postfix, from userid 50401) id D5F97F805C8; Sat, 6 Apr 2024 08:53:08 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 50527F805D2; Sat, 6 Apr 2024 08:53:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 33395F80579; Sat, 6 Apr 2024 08:48:59 +0200 (CEST) Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 1F933F8015B for ; Sat, 6 Apr 2024 08:48:34 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 1F933F8015B Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=gmx.de header.i=oswald.buddenhagen@gmx.de header.a=rsa-sha256 header.s=s31663417 header.b=Cf9kQyhi DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.de; s=s31663417; t=1712386113; x=1712990913; i=oswald.buddenhagen@gmx.de; bh=X24AK1KIcPQKPmxtllvKqjXta1IbOjB0Eg3I0W6YMic=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date:In-Reply-To: References; b=Cf9kQyhiYICLXVBDZ03zoVQEmX/CcL5W1Vkirv9HOXq+FVkfEGF5+fwggDZlhHat x4fFu66a209RSZ+okhcNnD/TQ+fmvi1UqAkjgzlmwBdI/KeigKzwTJdrcXKBawuD7 hrUm0gjwIGrQbYTFZ65ppqn3lHb6Lin2bT8i7yGT5PTOAtax6AuBCBUpBCS2Ivoba lrDijGntgGMz6aS01bLqtxginfQW3W6uRvuH//K4V/RiQCZdgtD3oVHOM0O9PsPI+ ue7fqc4yX3ZEe0RuQK+PiDJtVA30XehGTuVLeZariKNVC95WhgwK8yAW5RcZ2f5r9 fjAOuzv2yBQx1cyjfw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from ugly.fritz.box ([89.247.162.118]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N6KUd-1sqQ7D38av-016h7R; Sat, 06 Apr 2024 08:48:33 +0200 Received: by ugly.fritz.box (masqmail 0.3.6-dev, from userid 1000) id 1rszqo-JqW-00; Sat, 06 Apr 2024 08:48:30 +0200 From: Oswald Buddenhagen To: alsa-devel@alsa-project.org Cc: Takashi Iwai , Jaroslav Kysela , Arthur Marsh Subject: [PATCH v3 01/17] ALSA: emux: fix /proc teardown at module unload Date: Sat, 6 Apr 2024 08:48:14 +0200 Message-ID: <20240406064830.1029573-2-oswald.buddenhagen@gmx.de> X-Mailer: git-send-email 2.44.0.701.g2cf7baacf3.dirty In-Reply-To: <20240406064830.1029573-1-oswald.buddenhagen@gmx.de> References: <20240406064830.1029573-1-oswald.buddenhagen@gmx.de> MIME-Version: 1.0 X-Provags-ID: V03:K1:77DVNGq1Kj+ik+SAHMGC58pXPZKQR435JSbnv7VsgAcpkVmvZSE kv6JSmddjoo2PFEOYWlpCngor/gQJmOZeE8dcRLIbsBOACJa4OcOk2li1hdavGejyV+/lOp 3drYI3aejMGH83Xdf1jk7YDu+iyNZoZywNJBtiW48PFcmKxyX8/zKAugBO8xdlLMDetaTkE NiRwnONbXXhMR3KA967Qg== UI-OutboundReport: notjunk:1;M01:P0:F7iMyTDUX1w=;HYH+GvIPzL+enXdgIqgPS+Yfg90 WOHvruMh5QapRc7fBHuXs41ZTNBXzy+rf4Aq1lqJ6bBZRhIUVIHt6a6uHE2/OR2B1lIE9bFu+ kS5UYYj+V/ScrTZRtfBg4ZZ1hVyeE13WcnYN+wHgSl9OF6aczd+b6JNWaC294iscnq46ApT7N 94ryF68KrukP9CGCHQMYplj6SU/aMBIPNCcZvCxCCuG31zXMQaeR5UBXvtH6z9If0NjET0BFA RmrJpv22a4fOEg7QtlF2qYXqfwQ+UD+XQve+GM3ROhx7Rar3IFG9ALZ3UnkhPlF+PJsgBubyd fhapXw3oC0Ku/QOyYP+NAzoBozlCq5y2916si1jCEgdq5Y3TMXJZitRWuf8SSycVH472ePDp3 T4oF2s2CDSB/OborJ1po6vDpJdCHvcFadEWbU/tdfpHtGYjRi5WGvdKWEQb1BFnZz9fjgvmOp 2mCgiuBzzgDKCk9a1bg5aZxQSNoFIOa76nB8sBT7uegg44f2qWGepT6nnQWDdoDNsASTLh4vw g1RAzw26R3s/SyBLwdqCQ1rbzNXAx8Q9adC6zQ3hssg1poEYDWq6LJ0Rj+zVAlTn66k2aDQ+L ATRDtdzyzizBZm7E1YHhImoACxNZfz0JeN/ZpxPiZKntUQeVwJFS3CALMj/BkAMh3s7hZQPC+ Nah764S/0YyPJbXmPwyOGVuxSiw1ZT/Sb7+YQYGWjao4O9RMf6zc/YbeYv4bejP5lp6AAWa68 uGPhICc47o/GOZV5pu78FHO+iDK6nbpPCxYYKoc8YkqyO3nyZx0VAYoFLSxx6IUtg6DNcdnjp ZAcehBLS5QvMYKzN9Jd+AXdXJ6zDMfdJN1uc7ny7leIwM= Message-ID-Hash: YK4MXV6SF4UR2DPCBDIY2ZBCH5QB4SGB X-Message-ID-Hash: YK4MXV6SF4UR2DPCBDIY2ZBCH5QB4SGB X-MailFrom: oswald.buddenhagen@gmx.de X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We forgot to remember the wavetable /proc entry, so we'd fail to free it at module unload. This matters only when only the synth module is unloaded, as unloading the card driver would tear down the sub-entry anyway. Signed-off-by: Oswald Buddenhagen --- sound/synth/emux/emux_proc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/synth/emux/emux_proc.c b/sound/synth/emux/emux_proc.c index 7993e6a01e54..820351f52551 100644 --- a/sound/synth/emux/emux_proc.c +++ b/sound/synth/emux/emux_proc.c @@ -102,6 +102,7 @@ void snd_emux_proc_init(struct snd_emux *emu, struct snd_card *card, int device) entry->content = SNDRV_INFO_CONTENT_TEXT; entry->private_data = emu; entry->c.text.read = snd_emux_proc_info_read; + emu->proc = entry; } void snd_emux_proc_free(struct snd_emux *emu)