From patchwork Tue May 28 19:29:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pierre-Louis Bossart X-Patchwork-Id: 799540 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA75EC25B7C for ; Tue, 28 May 2024 19:30:58 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id C8B0EE0D; Tue, 28 May 2024 21:30:46 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz C8B0EE0D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1716924656; bh=jhpfqMAGii1QKtIKhhNyRYse2i/DMgLOIM+NJMRllAo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=HEOuMiqglCemOiAGe58731tdgDy6aYsSza2iAcODf2YPhvqLbSkkIWxpF4jqNfGwQ vm3qY+keyIJKYl1Bp9cQngK1498Nd+RLZrM9O1QE98A02QhwXnVaYdi9WC6GTVMaem votuif4GCCq/q68F5tpRX48gdFghD7nRnM3g2Yq8= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 07721F805C9; Tue, 28 May 2024 21:30:13 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 4457BF805BD; Tue, 28 May 2024 21:30:13 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 992D3F8047C; Tue, 28 May 2024 21:30:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.10]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 157BFF800E9 for ; Tue, 28 May 2024 21:30:00 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 157BFF800E9 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=nP1WWx3M DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1716924602; x=1748460602; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=jhpfqMAGii1QKtIKhhNyRYse2i/DMgLOIM+NJMRllAo=; b=nP1WWx3ML/gRHD9qH5SkxlLXUM1k8N+8ezDziv3dm0Nmsngg5Csy4t8E /YhBqN5XKSPJnd+rhCr9EYIq5XG0fLOhlcIX97ocbI1t53aZyhz4NLj92 s/LGc4ytnTLW52de9J0UYzK4NiGveIj9PuXhs51jWY2Tds/dLv5FRNEpi Dm76JBEzDPUgLGgEBYpXmvjJUxMKxeOlSz6T1R3p0UsYjUfkNlBn1gAjK LBefsi7uRrVZQZkT0pKm9QOKOlEHaSzFHK1VRaHUPh2EIFe2FmtG1syfa zD+r+5AE02H2gUPCXRnf/qBSWILiiM3CnzfqYwzhQSraNyagRH3NVXCQK w==; X-CSE-ConnectionGUID: tQBDvYvNSzKxuIWQ/DluQw== X-CSE-MsgGUID: NpMH9Ln+Sd6VJyOVjgmtCA== X-IronPort-AV: E=McAfee;i="6600,9927,11085"; a="24711845" X-IronPort-AV: E=Sophos;i="6.08,196,1712646000"; d="scan'208";a="24711845" Received: from orviesa009.jf.intel.com ([10.64.159.149]) by fmvoesa104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 12:29:54 -0700 X-CSE-ConnectionGUID: IMefETndQcyMYWtPaOeU6g== X-CSE-MsgGUID: Qd0KmJVNRCmMoBqsIxJazA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,196,1712646000"; d="scan'208";a="35246720" Received: from unknown (HELO pbossart-mobl6.lan) ([10.125.110.237]) by orviesa009-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 28 May 2024 12:29:53 -0700 From: Pierre-Louis Bossart To: linux-sound@vger.kernel.org Cc: alsa-devel@alsa-project.org, tiwai@suse.de, broonie@kernel.org, rafael@kernel.org, vkoul@kernel.org, andriy.shevchenko@linux.intel.com, Pierre-Louis Bossart , =?utf-8?q?P?= =?utf-8?q?=C3=A9ter_Ujfalusi?= , Bard Liao , Sanyog Kale , linux-kernel@vger.kernel.org (open list) Subject: [PATCH 2/3] soundwire: slave: simplify code with acpi_get_local_u64_address() Date: Tue, 28 May 2024 14:29:34 -0500 Message-ID: <20240528192936.16180-3-pierre-louis.bossart@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240528192936.16180-1-pierre-louis.bossart@linux.intel.com> References: <20240528192936.16180-1-pierre-louis.bossart@linux.intel.com> MIME-Version: 1.0 Message-ID-Hash: TUAVU43MHEFMAW5H2DEF6GJUU6XO6XR6 X-Message-ID-Hash: TUAVU43MHEFMAW5H2DEF6GJUU6XO6XR6 X-MailFrom: pierre-louis.bossart@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Now we have a helper so there's no need to open-code. Signed-off-by: Pierre-Louis Bossart Reviewed-by: Péter Ujfalusi Reviewed-by: Bard Liao Acked-by: Vinod Koul --- drivers/soundwire/slave.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c index 9963b92eb505..f1a4df6cfebd 100644 --- a/drivers/soundwire/slave.c +++ b/drivers/soundwire/slave.c @@ -97,18 +97,13 @@ static bool find_slave(struct sdw_bus *bus, struct acpi_device *adev, struct sdw_slave_id *id) { - u64 addr; unsigned int link_id; - acpi_status status; + u64 addr; + int ret; - status = acpi_evaluate_integer(adev->handle, - METHOD_NAME__ADR, NULL, &addr); - - if (ACPI_FAILURE(status)) { - dev_err(bus->dev, "_ADR resolution failed: %x\n", - status); + ret = acpi_get_local_u64_address(adev->handle, &addr); + if (ret < 0) return false; - } if (bus->ops->override_adr) addr = bus->ops->override_adr(bus, addr);