From patchwork Mon Aug 5 00:38:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 817109 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A1E59C3DA64 for ; Mon, 5 Aug 2024 00:51:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 5BAE24FC6; Mon, 5 Aug 2024 02:49:52 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 5BAE24FC6 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722819002; bh=2XKVwY029ACuwzgxudgKtOh9IfCaKw5UPLRQp32xCwc=; h=From:Subject:To:Cc:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=QJq9+btB9n62N58R935raW39aNgBy0OFUPzsNKr2Z0YCcF1zeTjO6CjnEGMJ7B9lo tNjXRn8xd5MQy/95mLlyAHDPABvQFo/uPNDma5NYMw3zRK+aznuRWOaP77RyxjmgjF /93SABOc6WC+8RbaRNPKF4cT5s3z6MMMZmBKVXgE= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 821E8F80610; Mon, 5 Aug 2024 02:39:45 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id BD5A2F89968; Mon, 5 Aug 2024 02:39:44 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 84ADDF802DB; Mon, 5 Aug 2024 02:38:38 +0200 (CEST) Received: from TYVP286CU001.outbound.protection.outlook.com (mail-japaneastazlp170110002.outbound.protection.outlook.com [IPv6:2a01:111:f403:c405::2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id F1C46F800B0 for ; Mon, 5 Aug 2024 02:38:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz F1C46F800B0 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=HKl14j+f ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=iu4ila11lRul5NeqFxW2Zy2aqhQPdN93eUTZD2Yc+8iO7E6H3oSJo/PJW2uLu0JQ7CdDAn/jiNC5hyuxG3Ln+jdkh76Mzg5b07ai2fH6wEFLJ1/E+4eDLZsR/ifb1FVYcYdNSusyuAIlGtvy6ye8ET21NZ7mmM4PJkk5WH1KJwON0bODjXFI10rruIfddicXn39k6W8J9coFqiZ/uL/LgllWI9kvDhe2akEYGV3h2AGhwNd7S4IxcB69YfrNjc4x+wy4yz2FvkgNtxQ92U8Faplh8KLWCiMC9ay2GMtbiLdGfD/AJZO3SiWY1Ms/sGeRHmkRq1WgTRPX0/NxF7wKXw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EwWBPIrvEEzNINeAu0VYLeEdb6PeE3NTbUPzBWPw94A=; b=t2hNUvzTMLy1ekm3QMMkyGbpOdslrgzjU7yjiiaZJaY92UiQ4JOX2XRWIdwx7r7t1um6rMccY0x9RrpmVEUlHLiGB9EOBuqmP1Ud1tyIX7gNpQlgSSL+HlyTEPLdTqvRuIhmRrzJ9JvisAus0SeS4JKuU88678/e7u4gyjjEXtW+vPxQ9FuyZ2EocI8Pu9B3EyLKqMmx/ODrJ9ArW1tq/0VnO3VjVH+iFe4fTv5BFZjw1G4d3EiXk9gD9OPunQaSzPfR5K1w1hsMQkUQOHbLU10UOLelyV6X9Z9nuyZKx4FseWTwtTMli0f17bK3oaV/v3G47lY6P+YFpSGVzlA5ag== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=EwWBPIrvEEzNINeAu0VYLeEdb6PeE3NTbUPzBWPw94A=; b=HKl14j+fb6mtpduYW4BmunXDMD2+W7hsl/+H6psVGHXKLPFnzBt0pJlfuTfRsXUJKg1EjJQ62mqRKGnRxyr8gaG0BI53ruVekRhP5TbhqPO3FCrToWJwbRxct6BuR/4pYXop+I76FkpFW3YsLwlrGQ2jRrNO7CGTFatOx/NPrf4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by TYCPR01MB9685.jpnprd01.prod.outlook.com (2603:1096:400:221::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.25; Mon, 5 Aug 2024 00:38:32 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11%5]) with mapi id 15.20.7828.023; Mon, 5 Aug 2024 00:38:32 +0000 Message-ID: <87h6bzztvb.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH 041/113] ALSA: firewire: fireface: use snd_pcm_is_playback/capture() User-Agent: Wanderlust/2.15.9 Emacs/29.3 Mule/6.0 To: Mark Brown Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, Linux-ALSA In-Reply-To: <874j7z3j1a.wl-kuninori.morimoto.gx@renesas.com> References: <874j7z3j1a.wl-kuninori.morimoto.gx@renesas.com> Date: Mon, 5 Aug 2024 00:38:32 +0000 X-ClientProxiedBy: TYAPR01CA0109.jpnprd01.prod.outlook.com (2603:1096:404:2a::25) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|TYCPR01MB9685:EE_ X-MS-Office365-Filtering-Correlation-Id: a486d03f-102e-4161-ac40-08dcb4e6ef1e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|52116014|38350700014; X-Microsoft-Antispam-Message-Info: S+yzwpQxdf+ikIyepAdbNs2ZB+MBrP7cvplZO5ZITs1dDv5ZBKhdDuMZm1n4xfug7gBL2m3OsM5qScS2OwacXMiRQnVTOIikA72/vLaxnsEswUkjpCliuXQt8dBh688xmN7rHgLx9UTE+GKWrS204omHy+WXohxxAK4O5BWFXumAwEHCPhRrTwHIKfOKrfF2PmuuZnJDaM4cDrbZ/5MX3glGoDoIk+1x2xj4vFaJuX0mOtylB/W/PAGXfNKj9IQKurN3Bd6ziL4d4WlSCy65weObn+umIImzJxkRBjkRWcc2tKJ+q167t92Yz6lrdhkFCA3A6/CIecNXonOX+IwkowTKtCVIn5qn645BnL5xldEx+b2w/4wgP9sP/P1GAOu8iq1e3k1Mpv7UM5EFwq6T/yoQcCkVE4SS3ucKqOV/ZmA+IQqiSiGrKyxddj1vB6tku9f1iqOdIxcPJhH/qspHjV8rEVzbvzL/tRdocCQo9BYLlX3jmyS2bk8NwT8VMt6pesUEY/UpdckfLxwY61Yd6sKIXQYneo/EknZjMfGVulZYge55eJeeVYSLsSugfdnppvJujV++ADY1u7sXIA1oMtd4Z3MKoglqVmWHD7mVe+ONJyOUgOqlTquRe2Pj+S3p56mvfCAGzDvijtQHr5RjkykZioOhlSKn+tMa2B+OMXLh/6AHNIkLSepV5p5RnGXImO/eQDoH9jzUi4XUobhl18dhpD6BcDUDlr2uG/NwIiRFOsbbzqTyztle+/A19VaYgkuWCtRkyvzBIYGnFYTnKKp696GOH5p48xVB9Yrd6thuUe/5ib7cI/RPRK1/bSEGLSMSLDr8nhPkKFdAWm4FYUs6CbkvljvqYDac8OvpYnrL0Hv+aSf+Cx3+94mocXwQl5/se6ZDtX/gvBqQEXTtaJyVULi0j7tJTOFO7vpjWnxEQyzmnVMksgtotZq8Fv920i7QVKpWFs79YrtQTo9AiBpKPEXO4IRUgd3eIvYCNvhSCpFTtuujmHl3xaKP4ckJUXFxC0ErVUGf4yjue8OOI6zq2JMQnEfAKyMhyw2bofxYxJfN2BwO+boqxsvNomSSRJh4Vwd3x8ZH+rDKcs4K7Sou++N1OiF8ZYreIiVAQfZHridcuh3mh0r+RAkFrVsBxqtA2oUyRwOOq7WXQhkW8ISpUDlEjNhwof+OkL8aXqrRqnjWwNw/W2X3o4905utr6YmOPqoJi7UdMER3RJt+6dolKSWunjLj1wGdvSUmqGuocmudrurOYN44jBf124Ivj95+NJctTXjWF/BVtN+GBy4DfTGUbMIWhvfQbmrPoJiJtYgVD364pqQxiaN+v5rwgaem602L7b/D5u+tkXEweWUHLSinwCAbjVZzHpzzrNq53QsHPQ8uo8us6c4D5VkxgYk70g8IvZ+a4rJOCzggoQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB10914.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: bPhW7M1e5+px/mMX0VVKu0pH7FqtTROuJkYlHwjvBEC5bO5qeHClRZYtbRDsu6mmwAR/0/4dnTZwq+pytVhQU4daCfYRmbMx6wNk8rsT9JKIs4uutj2tN9z18gC8bqluoHocQE9KKTf7DfMGxvX0YptikJ/5/ggR7MzMOIcwktXoNgBHYOX6iYT3YlZv4thbqnXjy3fFvSuUc8VFteugHnhnPMQRzBjmGUl8PUp6QeL+kiIulmYGB5av92O87fRnhxPRXZ3mcH9AHc6xIokMVyOZ9aY9nZ5KhLfwvOwahv0Ll7Or8nue96haoe9K7GqzAPi8sOs/B537cZcZqDqTRBfr8myS38iaR/Ed3zHwx05Aa6pklWS8bIRaFmCEKPNDOos/mSfk97M8EHDSbw0F4T0O5EXt4h64QDaa7gka8L/ByYLMDbMJO8Ux199wUK4Od8Q6OkGdE7oVrysBHM8uoIdsbaYm29UZO/r812e/mALeztecka0rVVcqMKrJDprDxf5O4BJl+Y6l4GdQkO58NfgOl21c3dOJEiIEi9I4dd0fUS5WOtOnUrPnLLmryQuott8b9NNdrRlQWLBg2JPVvY0L2Buq5/C2E1OBtP9TJXIoHcoEI3olsddefUiDlW/zekl1nJgg9ok1NdSAJs+/YG5E4CL7bBaqdK5lM7lKF3bTqQlFohyW/HmlRiagMUTQl668UmHzUkc+MF9RbNIeM0f9/I+h6BpU4mSN7p8QfqD2EG0HFPCC3nHS30AG2en4y0nAbfeynT9DYtWOLjvrinOG+gAKFajYGPXTbKYArL0U1gxE2lQECmAfxGSBWL30zyjCOxW2hc6LFwYniCcY4654jcsdkJW2vagLA+WAldXbqI7AXt5N2rCEp2+OOEyAEAqYP1sD2vFWV6UBGmWXQCWCWUnwg0F/Jw8tHmP8TYftUFgf+WjXLfaNpMm0RZXWYIvpIMviTGw5/9BTzx+RbE5b5beDMBHWI6Ziea/T3YNgzsVAps3cb/5JDW6E3inchoUHQy2xRK172eI5yIuLFqd/cXmQXsJBEHQKRdK6wrDK56Q9IIn4ej1Nbn7TvUpo6uIVx9pq+IZg6yV88ZSLJnHsJ2LWPNF7WyBkbCA32YU8WaB3x0ctRlxPa9Voio2qu3UgMU54CmdMDf2YqQbBkQYV8LEVxWoYhjssx/fsLbmrRGcUCBMTDNR0+hmoEnnEmb+v1rZ833uED3uAw6bU755WqLZlFtJjE5ZQIuE1CPAONFIKDcpZf0bOqlA9Vk7O9gaQBhzbI+/P1GMu0K15NmQveqpqwU9c4v1tX7LMEgIPGbfokejA2cJguK8daZwuTNDE9M2vndO7iuUQRJ2HZFVrgk1HFVfo4foWHRNDj3+OT8m5uYvwgy9pQEot56YkSu7+/Iy52ZT/WnD2zIpXkHb/j+/hr06R1DvbbrebuA9y7P2jU8d/ZbTR/sAVop6Rd9zAOLNAS/qOQ/qXUvdgi1G8cGn78IAI5iA6GfRNLKJHFiaihVikw2SjgVgxSB1m0l9IPCJnyAdaAr9NTjGUYLv27k72KcWv/T3CRlgs6qXRceeuo2VfFZnfF/jLUjO37eY/WPEn1wGuFX+5D6WL9CiGaOIlel+Dh8kZGlJBl9U= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: a486d03f-102e-4161-ac40-08dcb4e6ef1e X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2024 00:38:32.7772 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: a6UWD34KXrof7i4h2te2k5EThdw5WyQtr7TuDR/hIaSTEu41WUclyQG8vs54Ma2+LKYZTnyTORDTPLQ07b+Qd9wx5BSu9ue2gdMja2/bv63xqKpLZyMEm0ibpW0dXNPF X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9685 Message-ID-Hash: VCETJAAYERA6LVGIHLGMQZHLQM2MT6FZ X-Message-ID-Hash: VCETJAAYERA6LVGIHLGMQZHLQM2MT6FZ X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We can use snd_pcm_is_playback/capture(). Let's use it. Signed-off-by: Kuninori Morimoto --- sound/firewire/fireface/ff-pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/fireface/ff-pcm.c b/sound/firewire/fireface/ff-pcm.c index ec915671a79b3..d17abff5bb1e0 100644 --- a/sound/firewire/fireface/ff-pcm.c +++ b/sound/firewire/fireface/ff-pcm.c @@ -109,7 +109,7 @@ static int pcm_init_hw_params(struct snd_ff *ff, const unsigned int *pcm_channels; int err; - if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) { + if (snd_pcm_is_capture(substream)) { runtime->hw.formats = SNDRV_PCM_FMTBIT_S32; s = &ff->tx_stream; pcm_channels = ff->spec->pcm_capture_channels;