From patchwork Mon Aug 5 00:38:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kuninori Morimoto X-Patchwork-Id: 816790 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (unknown [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 52266C3DA64 for ; Mon, 5 Aug 2024 00:51:34 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 1798C4FD5; Mon, 5 Aug 2024 02:49:56 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 1798C4FD5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1722819006; bh=1UujL1eLs4rK5a5BAs7CgUYbrOlYm6we5h3bR3Tkk84=; h=From:Subject:To:Cc:In-Reply-To:References:Date:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=WYuog1KL1JY9a8hLrjucQDBkavDc34+47M8YjPGA33BLd6E8Bp1Q2cFyo87pmC6qD CRr3aAXOqL/jihrGzglXSu9kpgAla9gGc21VB6jXFWqPgvgIJRfupTp/LWYCZdN8Q6 Z0c13f123N1BOwikQlKsbT3+4fNHzKcmsvL++02g= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 4BC3CF8996D; Mon, 5 Aug 2024 02:39:40 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 5CC57F89919; Mon, 5 Aug 2024 02:39:40 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 42C7BF802DB; Mon, 5 Aug 2024 02:38:25 +0200 (CEST) Received: from OS0P286CU011.outbound.protection.outlook.com (mail-japanwestazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c406::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 7A5F1F800BF for ; Mon, 5 Aug 2024 02:38:22 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 7A5F1F800BF Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key, unprotected) header.d=renesas.com header.i=@renesas.com header.a=rsa-sha256 header.s=selector1 header.b=aIFXTCai ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=TNUaQ+NDW/a1wabIIZsVE5m5E38H8+g2tfwT9tgg8f7wIGORZGgDHxeJ+dxGBzzOasX1m5bB04VBo3VPS487l3KHVcYmpZzbWsjEEGD1vG22y2uvNSYY65lCbqw1UFylhn+GIME2GQL1IjlzD0mtaauaJJ03F5mAB2gcW1OxPzRHVHi+p68RMN2JJTQ5BLZ9amMRYQSZ/5kRRfVahnkgH5vcMzkeyozNMrMMJ5MnleHNpxp1P5PKxrm9nalsoqGbTKTRycpDg+1v2t4eBIBlYatqu4G/1LSt61wE9XJEKQ/9QzQlNpzd+aXKDGDjB5/0G/G2UhdsGOEFyjjCJ+L5fQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=x79X8snJ4NKIkcwVBLfwQ3bh8abPmmro7Rwu7naeTIo=; b=g9UoX7O0UnRae7prdziXC4RDPg+Vi7nMUZMorTF3iLF6FJNtUQ+1trLxAn6wUGcSmLhMnuM2UUDy+xItPA4MlTZrTSVWHNCaSYOVb7ycknAEsr7qnuCfHaXyV7+Kzy9pIh5Pl+6gX0J3r32LcvOsQfamhZ2vsffQAnqtcKXlGTTvUfrjoFHL2mtxEbM2BBgaQfPd9PqU1/PpN4g+zTxmFn6valhYtcLkTqa55qbRxixOBKTpFtt3brFffoep8oP00YdyO20Ju6sLkDDpUQWGbJY1Yszq32ROTOb3BIOrNARF3Ohp9+M+mXA70EW/udCyA4zZ6iCcLZoLDRaUAUvbog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=renesas.com; dmarc=pass action=none header.from=renesas.com; dkim=pass header.d=renesas.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=renesas.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=x79X8snJ4NKIkcwVBLfwQ3bh8abPmmro7Rwu7naeTIo=; b=aIFXTCainh8RBb4fGpVQ1wiv13M450VxussYrN1fo3aHVZL1sT5xLtmY/+JbqUzdUwGJTBSYOdpQTzRKfVxyT3yaEqpK448OjjIFW2iNKKcZLggX14XoosNSXeZ8Lp8ke9OlNTNMPp6L6tu/Ejny0lniA7yL/obACKeqULp96bA= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=renesas.com; Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) by TYCPR01MB9685.jpnprd01.prod.outlook.com (2603:1096:400:221::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.25; Mon, 5 Aug 2024 00:38:19 +0000 Received: from TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11]) by TYCPR01MB10914.jpnprd01.prod.outlook.com ([fe80::c568:1028:2fd1:6e11%5]) with mapi id 15.20.7828.023; Mon, 5 Aug 2024 00:38:19 +0000 Message-ID: <87le1bztvp.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto Subject: [PATCH 038/113] ALSA: firewire: bebob: use snd_pcm_is_playback/capture() User-Agent: Wanderlust/2.15.9 Emacs/29.3 Mule/6.0 To: Mark Brown Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, Linux-ALSA In-Reply-To: <874j7z3j1a.wl-kuninori.morimoto.gx@renesas.com> References: <874j7z3j1a.wl-kuninori.morimoto.gx@renesas.com> Date: Mon, 5 Aug 2024 00:38:19 +0000 X-ClientProxiedBy: TYCP286CA0335.JPNP286.PROD.OUTLOOK.COM (2603:1096:400:38e::13) To TYCPR01MB10914.jpnprd01.prod.outlook.com (2603:1096:400:3a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYCPR01MB10914:EE_|TYCPR01MB9685:EE_ X-MS-Office365-Filtering-Correlation-Id: af0ca22e-5cff-4a8f-e5d6-08dcb4e6e713 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|52116014|38350700014; X-Microsoft-Antispam-Message-Info: IMKe6tOdRzFWQibq464USUUb8tA1s5Gfy6ATx+Ir3c5SxIQYjDxQicSdpMc9V5JAztR1CQuUBcEXd6Y6L2F9/yM7icuxV8VJHSR4Vd+DByAHKaws4zeff2bt+3IDdsiz9xO6DN0Ar5lggzH8v37AIrIs5673Mk775iBel2k0mTg5Xjst+mdOaFFnt/dFFDQPH+GuVEhTXoK+ebp3MEdGTgFCAl8ZHZhfk5QskYh5T8UmXvdAyqCaefnCDQi4iuxLtMzz3TgFcnqscpRRZmGfGCIuZOG7kl8NVjz3OHkaTlBGZCfIkyYpo8Gjg5ry6vbCabi4fMnPD/CA+rBAQiCA3LnaFLCCBmH5k2otE9EaUJngirx835Hi5UtW7gEq9W2deLcXo4CQnCj1sDmy2EfEQ0JAGqo6mAlW99JGQ7974PkpOcUbDisZNMBbBKoWpK7JKogN2eD+H5A5SPjSTRniLay7Jo0mpqkntidp4tGiTL9X3MYycp/Z6w44iklJvT0f7yZ+D5a4nTrCLubwB892HMuhohuudU9PXky56zmf2dDOIasxbo8fdk+WDsrG40AMgvYzlFPn7XWXWAvJVbL8ZmfNO3O8Iqrvq2Ar3+WgHX0+VR/GxX2wP3TYDb9P4pP/iN+W0E0HnNGQtf/4VWigs3zCmi0D/brz1Jq0H8qBNVW2Nn6BVvrHlJM7stDH+EFbm7XbeB+SVdBvnoZpJZib4H7+UuvHpxMqATE+eRpJu41bmOwInchGCUVgzVg8CxqUaRuzV/2J4veHUx38odsMF1lWy8CcwagxOuoeILkYOIHvwTvxOob3B5vnPzIu5YtNqIW5bpJzVedIV7CYLNFaX932IyqEZvK3vleKIh++tJmHsbnKVp8NjEUEWaLVKSJ/wE7JeBU5UXTQ8lL6jk2AZAD91Kuybz+AihjnnlzMUpBspuEsXs4EUJH2AMAgWjWNTXJxuHidj0/Eu313DiO4vVpy0nnGz/9Kqq1EAUZI9NSEdG1NQr5sbVzMJ3ebCrKO9+pWNJW5Y7CMChCtqD46Gb4C2SclOQI3O3w/IqaeSr1Vz1neKzMrjhEDIhe9DNC5/eY6P0GlUGQuXe9pTz7VPNJOX6sjjLniTMQI0EpIL2gJofmp9r/pdrw98u8zOnvCWWL0ysUS8r403B7VZyQpDzyMAz2sq5X6kfE+9l23xg04SjM+w/n4fNDoYz63U3gya1Y0zzsbx5BgSIWRskkGPyDQHNOJyBcDueYCEENtLso5d8yMNfspcGaNHSZOESKjSldKX7xgwnB/GpywGzfFPMt0BAjJsNu+q5s5HZK95Gs7Z+aKAVTA6TZuEdTyNIbg772fOY0YM3Xclop/s73LZUFWfGOKzcyoyAQQg1Zk9O6ttZQaXnQsCC4+zCRQ9Ha1w3cXz1AY9Evu16uQ5u8GUA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:TYCPR01MB10914.jpnprd01.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(52116014)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: uAsp68PVC4paDCg1Q0FkvAhS7S5rXyo0PZJnYyhr8Nl8+2BV7LieT2EO7cb4MTWZBzNeQT7CJ98NvjBQG2w1TkxlovYeCIXUR9E/DZuB3gNth0huMpOdC9P7A+sBdVadBd1AwaP/vfrbgB9j/X3QwAHkBHNjmYffyl28L87FGURIjh45SGHnulZA7Llxjk0bXbqfJL2xlf1+RR7zaLRYiNVllkLFvIFUuWWeVyzDL/T6RCGR7QEQSjHyiuKZbQbwC3ppPe/8GyvB35jqCesbfCDpm3n4LcnSqwui59DSfwtLjhaKdHSPP0n/7yMmQlkqcH8PdA3kSFIVXmprnJ0/yoTq+2Py3ZSxa05PvkvfEnf6DUvmmVB6xdNKDsBUmGZU1kYbb6hsmWIc8Bas1Psfa9dV5x7i0BvJayKIU/eKqg3ngg35B4YyRJyrhSpKc1CxV/3R5xIbxxgDJTqrUAIuDeinGGWfyqqe8qfZ3slzQgUgO0KiLjMbM1/AB1GOJ3eH4wfoPni3OKG56tu/JrZBr5XYGqb8fuo2o1bX4oMYulKy+VM8Gca5mq9mElbYFxRfC9QyI8wUKitHgrAXGmqQP1GatVhDuMN6mjL2euLObbuIgiW0hPdpb2bXXP9qiJV1bnZvrsfhayxo3YNljzCiPfdLuBZXIy1l/V5O0gudvjXxMT9Q3NEyDv9+XhTMqmVuiYnnr7MEQj2G3fa4ZYTybt/1IIKs7+4Y1R5Bb2zDdVmnBVCug87fmVwklLV05et5dkz36UCXtsM7+LuNbZFod3oLzpIimmdEtPHGp8LJfxy3NsCbO1LCvfCFVL1gNpvhqgDvIR1elx4EHLx4AF/2i6YIaim+BdNawa5jRkdAO0gk4f3+OJUhGLTj83C8rB6MTwjfcpv7orHaGI8VjJUW2yNh0yVZbn4aNCTPgBx2Li0IJqBjThgkVvh8PIGihczHTWb0goJ32coroTtjanxj1rNne4iXmGNRij6+STp0Iboi/CcdXSsPxTvY+wlh9TSisWO7wbEBxlxnfea7XT0BWBpHXfh+8euggvkgmaKwp0z/zfntf5p4QVdqIVO3YDYchWpK7eA/9h2K8mIl6Axm2MvjaQl9axacnN85Lc1QhBZqSyh4ahKAFOWUVtS7jzEnTSipo5mOdVvDxizIw4hSMEvwMHM+ZYSoPXwXoLZh5u35gjcGkwf0mhUvaY6qvkzRcuMj6MACcliwR/wPjp1Rrw2FAKezLyuNR+y/1LT+3ZbQruTnFZFSM6rQQwPOKdStgSgfrOQtsuETwFaTlZW8qk7j3BUnCybWN7jSbU0mTxIpKl3gPORGahIG6SiwonNZwFYU5QUN2AFsVVGwBqJiXKRQM1tkUVJ6F5DpGnaC2wbmpS8KoILpv/FTgSehvgQrGOBp7cfSo69i0cYdrmZtQwOZPsa+KvfP4+8w02U6uiyMLCPvFhwRjRa3vK9wIMj/3YmW1oVANacPeBE86DHTlwJ/2LVq9rAbnANC4RNymgLLQEBK9nqYskt3/oCB3ULoeeZawfc+Pi9oXgZQGtWrbcTcG1reoCwDaEdTM+904Rb+xHQG7gZApz2+GE2oEazeRybIHdtWecs9UiTtjjXeCp1rXWDSmixMwAQQ9wKBbZ4= X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-Network-Message-Id: af0ca22e-5cff-4a8f-e5d6-08dcb4e6e713 X-MS-Exchange-CrossTenant-AuthSource: TYCPR01MB10914.jpnprd01.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Aug 2024 00:38:19.2788 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: B+5RQmJFyywznd1FJlvHqCYZHeCHKPR5w+aP4pBbeBGFfk6EANdGmT/DMLIK7jW0GBY52SGU15a1haw3RsIVHVzAIV1kjz6aS+CtKl+TpipGRxUPCJSBH2Tk3/fciKVC X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYCPR01MB9685 Message-ID-Hash: MREHUUWD5NABU6ILWZGCJ4TWJPZBHHUG X-Message-ID-Hash: MREHUUWD5NABU6ILWZGCJ4TWJPZBHHUG X-MailFrom: kuninori.morimoto.gx@renesas.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.9 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: We can use snd_pcm_is_playback/capture(). Let's use it. Signed-off-by: Kuninori Morimoto --- sound/firewire/bebob/bebob_pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/firewire/bebob/bebob_pcm.c b/sound/firewire/bebob/bebob_pcm.c index ce49eef0fcbaa..882aab28dd96d 100644 --- a/sound/firewire/bebob/bebob_pcm.c +++ b/sound/firewire/bebob/bebob_pcm.c @@ -100,7 +100,7 @@ pcm_init_hw_params(struct snd_bebob *bebob, struct snd_bebob_stream_formation *formations; int err; - if (substream->stream == SNDRV_PCM_STREAM_CAPTURE) { + if (snd_pcm_is_capture(substream)) { runtime->hw.formats = AM824_IN_PCM_FORMAT_BITS; s = &bebob->tx_stream; formations = bebob->tx_stream_formations;