From patchwork Mon May 15 08:02:27 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 104374 Delivered-To: patch@linaro.org Received: by 10.140.96.100 with SMTP id j91csp1430342qge; Mon, 15 May 2017 01:03:48 -0700 (PDT) X-Received: by 10.28.133.70 with SMTP id h67mr2695245wmd.136.1494835428399; Mon, 15 May 2017 01:03:48 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1494835428; cv=none; d=google.com; s=arc-20160816; b=r9pNwhqNZzxw/TB2Sq6vupvlpxDhL9Tl6xIKIJRF/2dl6E6XhBpghsQVrGWHvxVO68 VRfn9USAKQVwNMrMdlchxcEsk0WnVKYTVyOORVvitCNY7TJyJzxAbWL+ou1n3rw095FZ YLsuMHlXQQEYPnT0x08hJCupgtAhAwoticeNKdhic99+dkeNkNGC7rB+RNDAd37nUVWE UU9oowRw7Fm0D6SS5KidjyIE+/ySsGB0niPTCGaTzGR97WmtNE1J0Mtz60dl/djbnfoj vFTN86r5hqG0DTV0oPDOdbFx5Ltpa4Q7w86JM/tlhxKvyQTsLSQaI/Rk5vBVfGLJFI3M e+Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :delivered-to:arc-authentication-results; bh=lrlQmZIPHv7ZJa/oggbmi5P9xe7KO/wRnipkyRfIP3o=; b=qcFRxlEaJcXyQuzxR8Q+FEuS6p9/Kh8e83/PG2P0UiHmkWV63e3cpaZd+MvkR+6z2a gcUDS//N7fSBuWMGUzgCpEKLhVaAoATxpLwfk1Vv6+S9PAIxHcmYhAZ91Zc9jLGyFWkd mIi8L9sMOoCmumAYFR8yBkNA9fmDTN5dcpmxS/2DqFxiz9y6IU44btbfkOk9lkFpOciJ eR5Td5V1pknqFvD/G0zzk7P/DVplgJkBGIEjEdlUKDCFZq2DDLvDUl4+7giyRd8V527z 0/FFvhC/jcaWWeqw5BJqraqObwP94qGRINSoQWke5CL9A1Np4CswB5hP2B5MM2rGj0rL PuMA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id k20si9001433wmc.3.2017.05.15.01.03.48; Mon, 15 May 2017 01:03:48 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 2B2932672B1; Mon, 15 May 2017 10:03:07 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 655A6267325; Mon, 15 May 2017 10:03:05 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, RP_MATCHES_RCVD, SPF_PASS, URIBL_BLOCKED autolearn=disabled version=3.4.0 Received: from mezzanine.sirena.org.uk (mezzanine.sirena.org.uk [106.187.55.193]) by alsa0.perex.cz (Postfix) with ESMTP id 9062C2672B1 for ; Mon, 15 May 2017 10:02:38 +0200 (CEST) Received: from [2001:470:1f1d:6b5:7e7a:91ff:fede:4a45] (helo=finisterre) by mezzanine.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1dAAxb-0001iD-Vh; Mon, 15 May 2017 08:02:34 +0000 Received: from broonie by finisterre with local (Exim 4.89) (envelope-from ) id 1dAAxY-0002P1-09; Mon, 15 May 2017 17:02:28 +0900 From: Mark Brown To: Takashi Sakamoto In-Reply-To: <20170502133303.19622-5-o-takashi@sakamocchi.jp> Message-Id: Date: Mon, 15 May 2017 17:02:27 +0900 X-SA-Exim-Connect-IP: 2001:470:1f1d:6b5:7e7a:91ff:fede:4a45 X-SA-Exim-Mail-From: broonie@sirena.org.uk X-SA-Exim-Version: 4.2.1 (built Mon, 26 Dec 2011 16:24:06 +0000) X-SA-Exim-Scanned: No (on mezzanine.sirena.org.uk); Unknown failure Cc: Vinod Koul , tiwai@suse.de, alsa-devel@alsa-project.org, broonie@kernel.org, Sebastien Guiriec Subject: [alsa-devel] Applied "ASoC: intel: atom: localize variable without external linkage" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: intel: atom: localize variable without external linkage has been applied to the asoc tree at git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 65db85fba1df213ff80d6f3cbafee244c58f6ec3 Mon Sep 17 00:00:00 2001 From: Takashi Sakamoto Date: Tue, 2 May 2017 22:33:03 +0900 Subject: [PATCH] ASoC: intel: atom: localize variable without external linkage A driver for Intel SST driver for old atom platform includes a variable which has no external linkage. These functions should have static qualifier. This commit adds the qualifier to localize the variable. This issue is detected by sparse: sst.c:261:1: warning: symbol 'dev_attr_firmware_version' was not declared. Should it be static? Cc: Sebastien Guiriec Cc: Vinod Koul Signed-off-by: Takashi Sakamoto Signed-off-by: Mark Brown --- sound/soc/intel/atom/sst/sst.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/atom/sst/sst.c b/sound/soc/intel/atom/sst/sst.c index f9ba71315e33..d97556a3772c 100644 --- a/sound/soc/intel/atom/sst/sst.c +++ b/sound/soc/intel/atom/sst/sst.c @@ -258,7 +258,7 @@ static ssize_t firmware_version_show(struct device *dev, } -DEVICE_ATTR_RO(firmware_version); +static DEVICE_ATTR_RO(firmware_version); static const struct attribute *sst_fw_version_attrs[] = { &dev_attr_firmware_version.attr,