From patchwork Mon Nov 27 18:53:28 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 119779 Delivered-To: patch@linaro.org Received: by 10.80.225.132 with SMTP id k4csp2104111edl; Mon, 27 Nov 2017 10:58:13 -0800 (PST) X-Google-Smtp-Source: AGs4zMay+ANfhbzg/HIfxye54vkhaiXdcUm5ZOSVPMDNy7I3uDnGoTGypVbEvkLwzBIH557U3n86 X-Received: by 10.28.215.194 with SMTP id o185mr17144256wmg.105.1511809093135; Mon, 27 Nov 2017 10:58:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1511809093; cv=none; d=google.com; s=arc-20160816; b=kQ3BfAnomPQWxwV3hukNM81T9Qpee2nwalU5SX0cYsZj5RJucrvhQQP618bFMynwYN CnGWtjsKfwQT5llTmNPPpZVwbzdCC7auPENzcvQiWyDHl5HmVppl9G/GU0a2SZQgkhmK 7jYmXIhEfsQYkMID0j/rUatPJGCmSjdQOKMde4OBrcvIslD9LqFrHj/m+ny/FMaNYw7f Q53FZhibKbZ9SxUbQ7geRQRJ4i4t9w3QajrDibq5k9KFSjXbwDMPza54Ww2HLISwibyC effpauNQmSi8Uz0KRTZwRBpEaVUxLLoMcfsiWc+73ShEtmTig9P3OTbARj4c0qZBUzKK 9Y0Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=5nnP18zxE1jYESAvWzIOgh19tRlXDOs2OUo9J807UHA=; b=scpmQXavI8dv26nW72LBdUJyyNxvFNT4585do+izeOcrr8u4usjOfyB6ryLOgUBI7y bFPtXeA+eisSA64j9I26AY05AF6TrUCqE7tsrgJE21EeFUGyQ/+7rg/cOe/fd/DUVsiH KTtsHCzcME03SdS6Le8xewg4vkoBPWcIbdiqg2BslJQBuVsvBauZlYAxgBLMd8TPoOru /rmzr2nJqJzJmZLP2rlMN0StLoXgFPip8V279biWm0MT2lQxXA9a8Oloevn87Foo9rkh UZ2Tk7sGQWFBE+YzXfxldmpuUQBt51UnUsmlJqJUdqXFvxXXlzS2QB6m085yyN2TOQ62 5fYA== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ZqSaMHkY; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id i11si21989795wrf.152.2017.11.27.10.58.12; Mon, 27 Nov 2017 10:58:13 -0800 (PST) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ZqSaMHkY; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id CD2FE26762A; Mon, 27 Nov 2017 19:54:36 +0100 (CET) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 229062676E5; Mon, 27 Nov 2017 19:54:36 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, SPF_PASS, T_RP_MATCHES_RCVD autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id 0CCB426762A for ; Mon, 27 Nov 2017 19:53:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=Ycl/9agT6TICu6gJYbeDuoqDagsp3WUiDkN7opSQiqE=; b=ZqSaMHkYOa3l WJJe0MVHYPNiqnXFhP5H3+zTJFLI7MrUjmBUBPvGdp0/5j9oLTDlbAuDB9svdPuVRJn40dAkRliHi vHoCxFaAAUCIKk4H/r0Qp53ZtUgunLui+batArBFsbqI+SwswCjrM9vqpdVKYLEhFxN5rXmFLcSv7 jimLE=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1eJOX2-00073O-Hh; Mon, 27 Nov 2017 18:53:28 +0000 Received: from broonie by debutante with local (Exim 4.89) (envelope-from ) id 1eJOX2-0007In-4g; Mon, 27 Nov 2017 18:53:28 +0000 From: Mark Brown To: Benson Leung In-Reply-To: Message-Id: Date: Mon, 27 Nov 2017 18:53:28 +0000 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: qcom: apq8016-sbc: Map BTN_0 to KEY_PLAYPAUSE" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: qcom: apq8016-sbc: Map BTN_0 to KEY_PLAYPAUSE has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 5f6d1df8ced6bb52453149f96d9b7005058641b6 Mon Sep 17 00:00:00 2001 From: Benson Leung Date: Wed, 22 Nov 2017 12:56:43 -0800 Subject: [PATCH] ASoC: qcom: apq8016-sbc: Map BTN_0 to KEY_PLAYPAUSE The Android 3.5mm Headset jack specification mentions that BTN_0 should be mapped to KEY_MEDIA, but this is less logical than KEY_PLAYPAUSE, which has much broader userspace support. For example, the Chrome OS userspace now supports KEY_PLAYPAUSE to toggle play/pause of videos and audio, but does not handle KEY_MEDIA. Furthermore, Android itself now supports KEY_PLAYPAUSE equivalently, as the new USB headset spec requires KEY_PLAYPAUSE for BTN_0. https://source.android.com/devices/accessories/headset/usb-headset-spec Signed-off-by: Benson Leung Signed-off-by: Mark Brown --- sound/soc/qcom/apq8016_sbc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.15.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/qcom/apq8016_sbc.c b/sound/soc/qcom/apq8016_sbc.c index d49adc822a11..03851fedd1e2 100644 --- a/sound/soc/qcom/apq8016_sbc.c +++ b/sound/soc/qcom/apq8016_sbc.c @@ -92,7 +92,7 @@ static int apq8016_sbc_dai_init(struct snd_soc_pcm_runtime *rtd) jack = pdata->jack.jack; - snd_jack_set_key(jack, SND_JACK_BTN_0, KEY_MEDIA); + snd_jack_set_key(jack, SND_JACK_BTN_0, KEY_PLAYPAUSE); snd_jack_set_key(jack, SND_JACK_BTN_1, KEY_VOICECOMMAND); snd_jack_set_key(jack, SND_JACK_BTN_2, KEY_VOLUMEUP); snd_jack_set_key(jack, SND_JACK_BTN_3, KEY_VOLUMEDOWN);