From patchwork Fri Apr 13 10:56:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 133355 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp596897ljb; Fri, 13 Apr 2018 03:56:44 -0700 (PDT) X-Google-Smtp-Source: AIpwx4/XhvJw4VhInw3ySGnNBrgzC7+tvtjQ4vOkYYgTpzBay/2FnRddR9ENgm4OHtZsl/AgXLVt X-Received: by 10.223.134.103 with SMTP id 36mr3506766wrw.23.1523617004108; Fri, 13 Apr 2018 03:56:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523617004; cv=none; d=google.com; s=arc-20160816; b=NcULxabMTJ2Uix+uOyz1LdQlLf5dNyX1o4D68pzUJQabaRXV1lKntUzIWy/CAdBYn4 xxyTthASfwOxbp/pGxHOf9MGcpIC0Yd/3OKEvbfL7FvfvWH/KZYCbWUO6uPveHvnQrOx zLysiZNLEZxQffas0SWzGSzWu9xO15vQIZBHo+0tkkIbUooQ9vOy81LUpeBEzRKVJUWG E3qVzDAKgCmx0zuLiCuDEUAs6SwZ+g4J+35BrODSxkkyBd1xLfhb1LAodkw8TwlWWMGo bO6/6TZJOTMrPEDcLxf/ZH4YkUWjsWO5xj1/XjgSTuZaLIFm2OEU4cJr3TUXTrQscTXK b4KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=6H6fgL85o8JZXvlzxj6qp19Y10LRwGS1q6RLuS5rBzg=; b=Y3YijMBYUifonpKHtlioC4n2Cyr9cZbL/a0RH8XtWctOTIH/3X9Iv0ej1Z8TC0sF0m sUQLsfD3WDD1Hz9Vj1dcx2i70Qenbwi8bx3S4w2EdhDSvS8H4BYKW96P1PrJ9wr88U5R pDbv2ffH+4sya6aSHAW/aYMVM1cjEXUz6+KZuk7Or12zMi47oUQMNEUfPMFDmcPDcgmG TK/0861SCUSkE9Ody2JR/upyOz80yRllP9TQvrNcVF50OTcqnGi8vD7QZllknIkdeo2I 0LI1jJy+88D9Y/XtOHI2HZF0V+xHL8nclq+9dWI3faOd2JHVGFuke21jZutt2c3QjAUq 6ZLQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=oz+5/nc6; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id q16si4089656wrg.367.2018.04.13.03.56.43; Fri, 13 Apr 2018 03:56:44 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=oz+5/nc6; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 44E672673B2; Fri, 13 Apr 2018 12:56:18 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id BCAED2673FE; Fri, 13 Apr 2018 12:56:15 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id DF2FF2673EF for ; Fri, 13 Apr 2018 12:56:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=oxcXhO14BA5PZ42emytvtAlhLuvPoAr50z/OEuaqJIE=; b=oz+5/nc6tg0U CX22J0b0l6kgZulA65Mk5ukmw7oWVyoP+hlePFiNZ55QTgKhaE8QC/TvsBTX0GGfsBBg/HVKiEr57 WhWYyxUAZz+n7+eAaDatZNFlHvovgsRyJinvu0jfecJC6Ct9n+CF8WWMh0C9x/v6JU2sHVH8biAkN RSkxU=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f6wND-000879-E8; Fri, 13 Apr 2018 10:56:07 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f6wNC-0007B3-Vv; Fri, 13 Apr 2018 11:56:06 +0100 From: Mark Brown To: Jia-Ju Bai In-Reply-To: Message-Id: Date: Fri, 13 Apr 2018 11:56:06 +0100 Cc: alsa-devel@alsa-project.org, Mark Brown Subject: [alsa-devel] Applied "ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From f5c74c2918e51be14bc9c11c76fa118e354f4789 Mon Sep 17 00:00:00 2001 From: Jia-Ju Bai Date: Mon, 9 Apr 2018 18:47:37 +0800 Subject: [PATCH] ASoC: intel: bytcr_rt5640: Replace GFP_ATOMIC with GFP_KERNEL in snd_byt_rt5640_mc_probe snd_byt_rt5640_mc_probe() is never called in atomic context. This function is only set as ".probe" in "struct platform_driver". Despite never getting called from atomic context, snd_byt_rt5640_mc_probe() calls devm_kzalloc() with GFP_ATOMIC, which waits busily for allocation. GFP_ATOMIC is not necessary and can be replaced with GFP_KERNEL, to avoid busy waiting and improve the possibility of sucessful allocation. This is found by a static analysis tool named DCNS written by myself. Signed-off-by: Jia-Ju Bai Signed-off-by: Mark Brown --- sound/soc/intel/boards/bytcr_rt5640.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/boards/bytcr_rt5640.c b/sound/soc/intel/boards/bytcr_rt5640.c index a8d8bff788e7..ad5fcd5a1762 100644 --- a/sound/soc/intel/boards/bytcr_rt5640.c +++ b/sound/soc/intel/boards/bytcr_rt5640.c @@ -744,7 +744,7 @@ static int snd_byt_rt5640_mc_probe(struct platform_device *pdev) int i; is_bytcr = false; - priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_ATOMIC); + priv = devm_kzalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM;