From patchwork Mon Apr 16 11:59:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 133454 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp3480993ljb; Mon, 16 Apr 2018 04:59:36 -0700 (PDT) X-Google-Smtp-Source: AIpwx4+sSABg4CHWeQUCg+ih5JApXh7XvRbaLiq3dCNoQv9N5wKislMmILzasGpZqt+1UN8YYrZd X-Received: by 10.28.229.212 with SMTP id c203mr5095230wmh.2.1523879976720; Mon, 16 Apr 2018 04:59:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523879976; cv=none; d=google.com; s=arc-20160816; b=sCnBzlUNEwU1R4dfNyeq1J3UXIG/aCZWmZo4ED5LSOpo/QommHfY5nmN8Stcmf/n2k 85yCH0DuWHeGmjES+uOiIw0SZJQdLKrx+8NWkQQFrW6eS8+jyU5Aby1QLFHXNnDwq3xA eoMph7C2SzM9xvlUYDLD9qUa7xsFggaI1F2nOub7NjcKNf5C1w4adF4i9r24vvfBK2z8 TTfvT/IAsN3FHYey/xbAK25m/hz1Iw5W+5vceaF0tC4gkfLwqIyl4TSAX3TOoh+sr9GQ AAfmL2/71clz+GcdQYw4crU9WmU9jqwOAnUewK/v5X3NyUK8i043ZzJQSenWFDXlFLkI I7dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=ECDb5Vz2XdGbjpH0+hjziNWBGFh5MMjls6DMAyLv+GU=; b=VWaMGMS8+yF1lVoPGKwRhZ3pJcFnjPDQOBmEkRmor3dmHf/Dm/M7lVeZQa1Nh3GWJe w0nlLZUK7jfNSoEfQwfcqeVlgjVIsNuC6w9/eQnn6AvsS0oume+MpzNsNJW9GfEdTm44 HGl1ScXxa9T4MscaTpa4SXorb9NpBu2wZVvY0+up9yLCh0RAVMAyR0Js64j8Y/lLKXKN aseAXXhF3agdjGvwW+u/CnGCs8jdqz05j73+uOrmX0i071KMhArvmVitZQAUC6UAXapp EzgyEF37QjzC3O1mx8Yeg+hAt+dEZZCY3VO7xVBjqidMmbyYSU3OnYzfAvrXiHKvqXFW z2gQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BRhY/O0W; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id z73si5848979wmc.207.2018.04.16.04.59.36; Mon, 16 Apr 2018 04:59:36 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=BRhY/O0W; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id 537582673CF; Mon, 16 Apr 2018 13:59:35 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id CC25E2673D8; Mon, 16 Apr 2018 13:59:32 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id D20CB2673C7 for ; Mon, 16 Apr 2018 13:59:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=arhs7mqvCDcrCTPk9eoD80XF8iMyxlAkMPJa0XW3Nr8=; b=BRhY/O0WIdHh Ti2n1Uphj5IATJf4yaykxdTOK5qk53xOr8HxvjbvrxJWCFERbGcqZAcXrhO3p6CpEBgqWb8i1HSnP aBfmVxIGD7QvMvDuoylULfe3gCIEA0J6l2GUOvUXXP0DAVlItVg3ZnGChDfbrO5x2lcAIyAoD8Ubv dYz+Q=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f82n7-0005eG-Nb; Mon, 16 Apr 2018 11:59:25 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f82n7-0008V0-8G; Mon, 16 Apr 2018 12:59:25 +0100 From: Mark Brown To: Danny Smith In-Reply-To: <20180409131336.21990-2-robert.rosengren@axis.com> Message-Id: Date: Mon, 16 Apr 2018 12:59:25 +0100 Cc: alsa-devel@alsa-project.org, Lars-Peter Clausen , Liam Girdwood , Mark Brown , Robert Rosengren , Robert Rosengren Subject: [alsa-devel] Applied "ASoC: adau17x1: Do not reload dsp-fw if samplerate has not changed" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: adau17x1: Do not reload dsp-fw if samplerate has not changed has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 728815e3feec751769b3a9fe406fbc529de7cdc0 Mon Sep 17 00:00:00 2001 From: Danny Smith Date: Mon, 9 Apr 2018 15:13:36 +0200 Subject: [PATCH] ASoC: adau17x1: Do not reload dsp-fw if samplerate has not changed Reloading fw causes an audiable popping sound, we can avoid this by not reloading if the samplerate is the same as before. Signed-off-by: Danny Smith Signed-off-by: Robert Rosengren Acked-by: Lars-Peter Clausen Signed-off-by: Mark Brown --- sound/soc/codecs/adau17x1.c | 9 +++++++++ 1 file changed, 9 insertions(+) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/codecs/adau17x1.c b/sound/soc/codecs/adau17x1.c index 12bf24c26818..ae41edd1c406 100644 --- a/sound/soc/codecs/adau17x1.c +++ b/sound/soc/codecs/adau17x1.c @@ -843,6 +843,15 @@ int adau17x1_setup_firmware(struct snd_soc_component *component, struct adau *adau = snd_soc_component_get_drvdata(component); struct snd_soc_dapm_context *dapm = snd_soc_component_get_dapm(component); + /* Check if sample rate is the same as before. If it is there is no + * point in performing the below steps as the call to + * sigmadsp_setup(...) will return directly when it finds the sample + * rate to be the same as before. By checking this we can prevent an + * audiable popping noise which occours when toggling DSP_RUN. + */ + if (adau->sigmadsp->current_samplerate == rate) + return 0; + snd_soc_dapm_mutex_lock(dapm); ret = regmap_read(adau->regmap, ADAU17X1_DSP_SAMPLING_RATE, &dspsr);