From patchwork Tue Apr 17 11:28:53 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mark Brown X-Patchwork-Id: 133539 Delivered-To: patch@linaro.org Received: by 10.46.84.18 with SMTP id i18csp4599796ljb; Tue, 17 Apr 2018 04:29:20 -0700 (PDT) X-Google-Smtp-Source: AIpwx49llCK/mRZdDUCTTu0LJvoxwCjBn5hGT56lRSjnkok0RXaHnq3SUlzngcw+D2xMvCxtj5Ad X-Received: by 10.28.161.4 with SMTP id k4mr753092wme.106.1523964560768; Tue, 17 Apr 2018 04:29:20 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1523964560; cv=none; d=google.com; s=arc-20160816; b=HrWFj071F8CWcXSOZ4O35qNJHprrtqaUv2oy9cJwtUgWFTiFOnBW3WQt/FJ/YRTCA0 27EdMKtVCBpyoAKKmf1cxDe2hq9rVZOBK+75fNDirNNYMMSMztZAUw2bCMIiEFo+A9PS CcmFjCjiwOheE0Q85uWtQYGMUG/BieUF9bqvE50QextJMcoJ7tEBozN1hYpnnU5hXi+Z Ztl2AU6acrIALIOO0irDd9cBRdniXdvnAzPsVi5W+sokH4NSst50j88TGvUI1HTdT7W8 /bIyXuBipVg9teNKsetkCGsKH2qQ66taDUlfbg+Rmzf/LqCgRIm+YYQ6bjDPIQlMiwO6 JObQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:content-transfer-encoding:mime-version :list-subscribe:list-help:list-post:list-archive:list-unsubscribe :list-id:precedence:subject:cc:date:message-id:in-reply-to:to:from :dkim-signature:delivered-to:arc-authentication-results; bh=aC98Ns4cCKPgUYPU09e+Uo5f2uEv++ZYUX6O7tFQMiA=; b=uCMtouQanI2ofWa0qssPM+APpjChPzocKwmxdVNUYzFSW36c1vdA97HesQI3mnb248 ds+ggqdnj/La+0MVXfkRgclEYCD1eKlWLsPNH6VTY45cbobyALBf0Fq9TuRoOWbbbphP fbrnWOLZavTXmrgxs3TR0Y0JRuwsiPb5VCb82EBk10Q0SVPD5pUAW9g4uNUtoz7kIfno hSNgaG4uaua5pL1NEJF0bTEHwW2NUiActmfHou7ZckaVWpgdlOcvq0RB8wpbKgSTb3oy 2ktmyciYfGmVoZ8qGdLSoWxi/p/nQd/jqvESFMVdlzQxRBeWvYwxwcAzxt8TIqzdjRKw whcg== ARC-Authentication-Results: i=1; mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ln3d+M86; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Return-Path: Received: from alsa0.perex.cz (alsa0.perex.cz. [77.48.224.243]) by mx.google.com with ESMTP id o18si10761467wrc.368.2018.04.17.04.29.20; Tue, 17 Apr 2018 04:29:20 -0700 (PDT) Received-SPF: pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) client-ip=77.48.224.243; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@sirena.org.uk header.s=20170815-heliosphere header.b=ln3d+M86; spf=pass (google.com: domain of alsa-devel-bounces@alsa-project.org designates 77.48.224.243 as permitted sender) smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa0.perex.cz (localhost [127.0.0.1]) by alsa0.perex.cz (Postfix) with ESMTP id E910426762C; Tue, 17 Apr 2018 13:29:02 +0200 (CEST) X-Original-To: alsa-devel@alsa-project.org Delivered-To: alsa-devel@alsa-project.org Received: by alsa0.perex.cz (Postfix, from userid 1000) id 6F11226762A; Tue, 17 Apr 2018 13:29:00 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mail1.perex.cz X-Spam-Level: X-Spam-Status: No, score=0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, RCVD_IN_DNSWL_NONE, SPF_PASS autolearn=disabled version=3.4.0 Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) by alsa0.perex.cz (Postfix) with ESMTP id E26AF2675FF for ; Tue, 17 Apr 2018 13:28:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=mqqql6yJKtDGzTJopYtNkdlxEBhNIesR5jK2hiHZkPY=; b=ln3d+M865VFX aiSUUJHPXlIlK4cVYIotBzs4NzHuJFFCuiBFenKwA4EVAh2eARXa72o76Pqjuo5it9Of/ls1ywXIa eqjwgp8U4zU5xi+Q6R+IW2LWW3xCFXNrilJy4jsAuSen4ekXt2IogKnbvCmRm+1t9Ad2lJmMoMK6W udKGI=; Received: from debutante.sirena.org.uk ([2001:470:1f1d:6b5::3] helo=debutante) by heliosphere.sirena.org.uk with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1f8On7-0007cX-Oq; Tue, 17 Apr 2018 11:28:53 +0000 Received: from broonie by debutante with local (Exim 4.90_1) (envelope-from ) id 1f8On7-0000Mm-BA; Tue, 17 Apr 2018 12:28:53 +0100 From: Mark Brown To: Divya Prakash In-Reply-To: <1522651550-27236-3-git-send-email-sriramx.periyasamy@intel.com> Message-Id: Date: Tue, 17 Apr 2018 12:28:53 +0100 Cc: alsa-devel@alsa-project.org, Takashi Iwai , Sriram Periyasamy , Liam Girdwood , Patches Audio , Mark Brown , Vinod Koul Subject: [alsa-devel] Applied "ASoC: Intel: Skylake: Reset DSP pipe in skl_pcm_hw_free" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org The patch ASoC: Intel: Skylake: Reset DSP pipe in skl_pcm_hw_free has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 179c2e86328c3d7e07f87f9c45a216cda626e9ee Mon Sep 17 00:00:00 2001 From: Divya Prakash Date: Mon, 2 Apr 2018 12:15:49 +0530 Subject: [PATCH] ASoC: Intel: Skylake: Reset DSP pipe in skl_pcm_hw_free Currently during destroy pipeline the gateway is disabled before DMA completion. This leads to improper draining of data and subsequently causing issues on HD-Audio DMA. Hence added a new pipe reset IPC in skl_pcm_hw_free in which the Gateway Enable(GEN bit) is reset to 0 after DMA completion in skl_pcm_trigger. Signed-off-by: Divya Prakash Signed-off-by: Sriram Periyasamy Signed-off-by: Mark Brown --- sound/soc/intel/skylake/skl-pcm.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) -- 2.17.0 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org http://mailman.alsa-project.org/mailman/listinfo/alsa-devel diff --git a/sound/soc/intel/skylake/skl-pcm.c b/sound/soc/intel/skylake/skl-pcm.c index 15cb8ac3e374..fe25515debec 100644 --- a/sound/soc/intel/skylake/skl-pcm.c +++ b/sound/soc/intel/skylake/skl-pcm.c @@ -366,9 +366,21 @@ static int skl_pcm_hw_free(struct snd_pcm_substream *substream, { struct hdac_ext_bus *ebus = dev_get_drvdata(dai->dev); struct hdac_ext_stream *stream = get_hdac_ext_stream(substream); + struct skl *skl = get_skl_ctx(dai->dev); + struct skl_module_cfg *mconfig; + int ret; dev_dbg(dai->dev, "%s: %s\n", __func__, dai->name); + mconfig = skl_tplg_fe_get_cpr_module(dai, substream->stream); + + if (mconfig) { + ret = skl_reset_pipe(skl->skl_sst, mconfig->pipe); + if (ret < 0) + dev_err(dai->dev, "%s:Reset failed ret =%d", + __func__, ret); + } + snd_hdac_stream_cleanup(hdac_stream(stream)); hdac_stream(stream)->prepared = 0;