From patchwork Fri Jun 6 19:05:45 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Viacheslav Dubeyko X-Patchwork-Id: 894477 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 52CC61E25E1 for ; Fri, 6 Jun 2025 19:05:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749236754; cv=none; b=t+HKKWXqqtlPIYFdcXPYwwe73aOm1nI5N31Njw7lIpqUE4rojimqCN/Bd2nxWjL290jB0+iuqIrHU19khj7ojXe2li+eGMSkPWTrqOWITc+wgKgXMH+faLqyM2Uq+4TCvYhBoKA3kTyho1CRfVlnNC2SKWovp4A4CnubsdIN3To= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749236754; c=relaxed/simple; bh=fjA174NXcYra/qNR5ZeunrR6PJxgyVAijSUtlp0nPjM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=skdR/l+MiUXBFo+t0pdVD3STKdT1eGR3So18bIgRrogPf1PmvHTOmJd1ZK8lIkUXtDtbv/mod0v7ylLd93hm5vDZ4OeVZ8/iHJwVHDMYKTKN6pk+HmcUJ7uLBeFUjKq7wfnhuRQWDflzHgnWfPyLg4j8hdAycrQhXf6S9sHYLZQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com; spf=pass smtp.mailfrom=dubeyko.com; dkim=pass (2048-bit key) header.d=dubeyko-com.20230601.gappssmtp.com header.i=@dubeyko-com.20230601.gappssmtp.com header.b=I4pn4krY; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=dubeyko.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20230601.gappssmtp.com header.i=@dubeyko-com.20230601.gappssmtp.com header.b="I4pn4krY" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-4066a0d0256so1641464b6e.3 for ; Fri, 06 Jun 2025 12:05:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20230601.gappssmtp.com; s=20230601; t=1749236751; x=1749841551; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZB9ynOz6tzj5Zv03g68DqX1Y48gJ3m+cXZRrMsWB/Hk=; b=I4pn4krYKMWDA34DHWI2AMNLzHlo4TA6sgKuIVEPQ2OdoYG5n7N9vbZPSjpHF7TFgF TZw6ibZUgHM8qO2vTaM+iXFqMMtY/cORc8V9b8WqA73lnGJVD69A5s2JZePgVTINg9KX MKSGAk0ku0/DpSQ6ZGQFQLbhjb/11tp9s7u3sqOwQX9CDeyyjU4eppfL3sAYaVsf7cbO PssZ/JLi6KJ9ileNVqjr9snQBMoe8FqN+YnLQ0zg92CoHRONCa+QUNlqanN1dflXqtCU 1x/ufZL0RZHIJHTWSr2AdwkJIe4KkYckic0PsMi9ypLRTYKKjYvox7Oo1JibvWA2ccAo iqoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749236751; x=1749841551; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=ZB9ynOz6tzj5Zv03g68DqX1Y48gJ3m+cXZRrMsWB/Hk=; b=Ep/wPk8yFjvmPzQOULxUUyifI6ad9K0erp4tk5uhHKt/+j/fPS24JCdMdG0lzWAo88 heNQaBpKuUWlDgiK5x18KCAvPLCAStdNry8XAYbEBUqvGUQbhgwaw4AziwW9ixZ/xvz9 KdUm0dDtJUcPn3tsi+6/8pV9CiMsfFCOSw1n0HxtnVqmEc0lXS3HomBR+5Jmq9kV3luT s5XMhgUolTyqJHFIXZbec3Y0II5x4DooYZSWOPbztQpEJhpOVMHv4Eqvmm4blcEfbrqi /rehfrgyiuS5cxSKjjdLFJb8ztcK785Kgom6xnc1iFe+bF2FUQqki/PC1a8krWyR6bd2 Jy2Q== X-Gm-Message-State: AOJu0YzZJ4ItSz6jGztTRAqgV5qU27Bw39cmzLcwr83CzFXaepHSlgE7 JNCziY4ATNwcczPuaaqnSUZUlT6DFKj8FEAb3r0+MvepJ4sohC553MTGn2PwEplbEVAnHV6FKTp lT/M00ok= X-Gm-Gg: ASbGncucjqkCGPDldtRGYHaQb7vQLFm93pZ4rd55dndZpELrAcNSjdoz4FZIBz4txQI TCAElYW6TKfroymsqHiAU7s3KWpaAWNsvThZMnwErqWR3usjLboNhZMHrbfATTpz7KUyw0McZVJ vPQZKOoouzXVl6iToGWrNTvPsAt2GGXaWaFtlu99MgkKKnn6h/WdJ9/t7voI7DQAfXFQLsCcAqI Up+UkzXOvnI0lI0Ic40rptII7e4qk6v6Cf4Pd+s+HcCqNd6u3rtHH8iIohwomPdicLHDrHbcvkC jNlw6kQUVgSVOxcGZs9bZGrzlsMi3zOYOXutc6LJzkf9YNx3kfqyy7FIo0YcGXgt0TLvdYC/RWL h5Zja X-Google-Smtp-Source: AGHT+IEtfRFjm8MHKUaNn5CMUbZcMb5BICcItdOhd4cO9UvJEofKS92V4U0N7MVOIpb3NgYFd96s0Q== X-Received: by 2002:a05:6808:6f8d:b0:407:59ac:d73f with SMTP id 5614622812f47-409051f2c1fmr3218153b6e.21.1749236750747; Fri, 06 Jun 2025 12:05:50 -0700 (PDT) Received: from system76-pc.attlocal.net ([2600:1700:6476:1430:fe8a:b218:375c:b2ed]) by smtp.gmail.com with ESMTPSA id 5614622812f47-409069638a7sm448598b6e.22.2025.06.06.12.05.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Jun 2025 12:05:49 -0700 (PDT) From: Viacheslav Dubeyko To: ceph-devel@vger.kernel.org Cc: idryomov@gmail.com, linux-fsdevel@vger.kernel.org, pdonnell@redhat.com, amarkuze@redhat.com, Slava.Dubeyko@ibm.com, slava@dubeyko.com Subject: [PATCH] ceph: fix overflowed constant issue in ceph_do_objects_copy() Date: Fri, 6 Jun 2025 12:05:45 -0700 Message-ID: <20250606190545.438240-1-slava@dubeyko.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: ceph-devel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Viacheslav Dubeyko The Coverity Scan service has detected overflowed constant issue in ceph_do_objects_copy() [1]. The CID 1624308 defect contains explanation: "The overflowed value due to arithmetic on constants is too small or unexpectedly negative, causing incorrect computations. Expression bytes, which is equal to -95, where ret is known to be equal to -95, underflows the type that receives it, an unsigned integer 64 bits wide. In ceph_do_objects_copy: Integer overflow occurs in arithmetic on constant operands (CWE-190)". The patch changes the type of bytes variable from size_t to ssize_t with the goal of to be capable to receive negative values. [1] https://scan5.scan.coverity.com/#/project-view/64304/10063?selectedIssue=1624308 Signed-off-by: Viacheslav Dubeyko --- fs/ceph/file.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/fs/ceph/file.c b/fs/ceph/file.c index 851d70200c6b..e46ff9cb25c5 100644 --- a/fs/ceph/file.c +++ b/fs/ceph/file.c @@ -2883,7 +2883,7 @@ static ssize_t ceph_do_objects_copy(struct ceph_inode_info *src_ci, u64 *src_off struct ceph_object_id src_oid, dst_oid; struct ceph_osd_client *osdc; struct ceph_osd_request *req; - size_t bytes = 0; + ssize_t bytes = 0; u64 src_objnum, src_objoff, dst_objnum, dst_objoff; u32 src_objlen, dst_objlen; u32 object_size = src_ci->i_layout.object_size; @@ -2933,7 +2933,7 @@ static ssize_t ceph_do_objects_copy(struct ceph_inode_info *src_ci, u64 *src_off "OSDs don't support copy-from2; disabling copy offload\n"); } doutc(cl, "returned %d\n", ret); - if (!bytes) + if (bytes <= 0) bytes = ret; goto out; }