From patchwork Mon Oct 24 13:40:26 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shawn Guo X-Patchwork-Id: 4796 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id AC34423E06 for ; Mon, 24 Oct 2011 13:29:50 +0000 (UTC) Received: from mail-dy0-f52.google.com (mail-dy0-f52.google.com [209.85.220.52]) by fiordland.canonical.com (Postfix) with ESMTP id 9AA9AA187C6 for ; Mon, 24 Oct 2011 13:29:50 +0000 (UTC) Received: by dyf39 with SMTP id 39so88299dyf.11 for ; Mon, 24 Oct 2011 06:29:50 -0700 (PDT) Received: by 10.223.85.139 with SMTP id o11mr43695561fal.0.1319462990207; Mon, 24 Oct 2011 06:29:50 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.152.1.71 with SMTP id 7cs65956lak; Mon, 24 Oct 2011 06:29:49 -0700 (PDT) Received: by 10.236.116.66 with SMTP id f42mr34387165yhh.111.1319462988832; Mon, 24 Oct 2011 06:29:48 -0700 (PDT) Received: from TX2EHSOBE006.bigfish.com (tx2ehsobe003.messaging.microsoft.com. [65.55.88.13]) by mx.google.com with ESMTPS id d30si5866626yhl.21.2011.10.24.06.29.48 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 24 Oct 2011 06:29:48 -0700 (PDT) Received-SPF: neutral (google.com: 65.55.88.13 is neither permitted nor denied by best guess record for domain of r65073@freescale.com) client-ip=65.55.88.13; Authentication-Results: mx.google.com; spf=neutral (google.com: 65.55.88.13 is neither permitted nor denied by best guess record for domain of r65073@freescale.com) smtp.mail=r65073@freescale.com Received: from mail159-tx2-R.bigfish.com (10.9.14.241) by TX2EHSOBE006.bigfish.com (10.9.40.26) with Microsoft SMTP Server id 14.1.225.22; Mon, 24 Oct 2011 13:29:43 +0000 Received: from mail159-tx2 (localhost.localdomain [127.0.0.1]) by mail159-tx2-R.bigfish.com (Postfix) with ESMTP id 91A181940363; Mon, 24 Oct 2011 13:29:45 +0000 (UTC) X-SpamScore: -1 X-BigFish: VS-1(zz1432N98dKa1fflb922lzz1202hzzz2dh2a8h668h839h944h61h) X-Spam-TCS-SCL: 0:0 X-Forefront-Antispam-Report: CIP:70.37.183.190; KIP:(null); UIP:(null); IPVD:NLI; H:mail.freescale.net; RD:none; EFVD:NLI X-FB-SS: 0, Received: from mail159-tx2 (localhost.localdomain [127.0.0.1]) by mail159-tx2 (MessageSwitch) id 1319462968760458_8821; Mon, 24 Oct 2011 13:29:28 +0000 (UTC) Received: from TX2EHSMHS029.bigfish.com (unknown [10.9.14.240]) by mail159-tx2.bigfish.com (Postfix) with ESMTP id A5585E90051; Mon, 24 Oct 2011 13:29:28 +0000 (UTC) Received: from mail.freescale.net (70.37.183.190) by TX2EHSMHS029.bigfish.com (10.9.99.129) with Microsoft SMTP Server (TLS) id 14.1.225.22; Mon, 24 Oct 2011 13:29:23 +0000 Received: from az33smr02.freescale.net (10.64.34.200) by 039-SN1MMR1-003.039d.mgd.msft.net (10.84.1.16) with Microsoft SMTP Server id 14.1.339.2; Mon, 24 Oct 2011 08:29:26 -0500 Received: from S2100-06.ap.freescale.net (S2100-06.ap.freescale.net [10.192.242.125]) by az33smr02.freescale.net (8.13.1/8.13.0) with ESMTP id p9ODTLiW006656; Mon, 24 Oct 2011 08:29:22 -0500 (CDT) Date: Mon, 24 Oct 2011 21:40:26 +0800 From: Shawn Guo To: Mark Brown CC: Grant Likely , Rajendra Nayak , , , , , , , Subject: Re: [PATCH v2 3/5] regulator: helper routine to extract regulator_init_data Message-ID: <20111024134025.GE1755@S2100-06.ap.freescale.net> References: <20111018132032.GD30703@S2100-06.ap.freescale.net> <4E9EB61C.1040207@ti.com> <20111019144215.GA32007@S2100-06.ap.freescale.net> <4E9FAF42.5060200@ti.com> <20111020061408.GE32007@S2100-06.ap.freescale.net> <4EA00F7C.1080005@ti.com> <20111021082309.GA337@S2100-06.ap.freescale.net> <20111024092411.GE8708@ponder.secretlab.ca> <20111024130429.GD1755@S2100-06.ap.freescale.net> <20111024130636.GB26033@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20111024130636.GB26033@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: freescale.com On Mon, Oct 24, 2011 at 03:06:37PM +0200, Mark Brown wrote: > On Mon, Oct 24, 2011 at 09:04:31PM +0800, Shawn Guo wrote: > > > If we can attach the device_node of 'regulators' node to dev->of_node > > when calling regulator_register(regulator_desc, dev, ...) from > > regulator driver, the regulator core will be able to find all nodes under > > 'regulators' using for_each_child_of_node(dev->of_node, child). > > Please provide concrete examples of the bindings you're talking about, > the really important thing here is how sane the bindings look and I've > really got no idea what any of what you're talking about will look like > or if they make sense. > The only thing different from what I attached last time is the compatible string added to 'regulators' node. ecspi@70010000 { /* ECSPI1 */ fsl,spi-num-chipselects = <2>; cs-gpios = <&gpio3 24 0>, /* GPIO4_24 */ <&gpio3 25 0>; /* GPIO4_25 */ status = "okay"; pmic: mc13892@0 { #address-cells = <1>; #size-cells = <0>; compatible = "fsl,mc13892"; spi-max-frequency = <6000000>; reg = <0>; mc13xxx-irq-gpios = <&gpio0 8 0>; /* GPIO1_8 */ regulators { compatible = "fsl,mc13892-regulator"; sw1reg: mc13892_sw1 { regulator-min-uV = <600000>; regulator-max-uV = <1375000>; regulator-change-voltage; regulator-boot-on; regulator-always-on; }; sw2reg: mc13892_sw2 { regulator-min-uV = <900000>; regulator-max-uV = <1850000>; regulator-change-voltage; regulator-boot-on; regulator-always-on; }; ...... }; leds { ...... }; buttons { ...... }; }; flash: at45db321d@1 { ...... }; }; > > hesitate to hack this into mfd_add_devices(), so I would like to add > > compatible string "fsl,mc13892-regulators" to node 'regulators' and > > find the node using of_find_compatible_node(dev->parent, NULL, > > "fsl,mc13892-regulators"). > > It's not immediately obvious to me that having a binding for the > regulators separately makes sense, it's not a usefully distinct device. > Fair point. Actually, I also hate to have the finding of node 'regulators' plugged into regulator driver. What about following change to address Grant's concern on global device tree search? diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c index 8fe132d..29dcf90 100644 --- a/drivers/regulator/core.c +++ b/drivers/regulator/core.c @@ -2673,7 +2673,8 @@ struct regulator_dev *regulator_register(struct regulator_desc *regulator_desc, BLOCKING_INIT_NOTIFIER_HEAD(&rdev->notifier); /* find device_node and attach it */ - rdev->dev.of_node = of_find_node_by_name(NULL, regulator_desc->name); + rdev->dev.of_node = of_find_node_by_name(dev->parent->of_node, + regulator_desc->name); /* register with sysfs */ rdev->dev.class = ®ulator_class;