From patchwork Tue Mar 10 17:49:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Phil Yang X-Patchwork-Id: 184358 Delivered-To: patch@linaro.org Received: by 2002:a92:1f12:0:0:0:0:0 with SMTP id i18csp985253ile; Tue, 10 Mar 2020 10:51:11 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv4+Id3zp/HPeBGz2UmFBGnCCZL/W+9StTC6vQRIA5sNDHyUGyaLC8i47pbMMzPuTPEWy5Z X-Received: by 2002:a05:6402:78c:: with SMTP id d12mr22236231edy.203.1583862671768; Tue, 10 Mar 2020 10:51:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1583862671; cv=none; d=google.com; s=arc-20160816; b=J0vX3T0egZOTZVN1k9WrEmAdJ0DiGfeLPhjttp03TF4MI67OzWRSVu8TLJRQy16dHy Xrh+KYHdI397XRzQhYtuvzvEHpDlmogGYljiRfuA8cov1F5y4cFGxx1CU1u8lQerpek1 m6JZO4EZK7tMhcow5tMAFlvWJV2NJMaTA+BCbpJkXnqcdlynJf/ssNImj2N3Ps+uGqrz u/czYQRRNmDYdsTDsobbLIZWa17mO1OO9xjYHQrQXc1LQwRLlfFn75TKlGHEnaWfatsT 3jdLPdtqlGdaRRr/ae3NTDAkpKpLq36iipQD3Co2rNXeYOOVW/n7UMhHyuzUPqfK2yBD 1NfA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=ge3jErxjbLqAoZevpnqfMQ5lOkHWiJOjTfHnpjsVb2Y=; b=dU1YMvCmJ2NLL4t0JfDbghBRZqLMxGXxV7ZRHXhBwKCAYl+7WvPpmLM84FianxfrRv H+KIW5AfOnAGKm9M+dp9yY9BYyu6yKyrWWhMB1Kh45xERVD6dYO2Iu9aIRyyMHob8uCU UyYOCUHxFT7N7YoJOnfIzHMMLMWhhJf8+/MpddxzAUMIhTivblbuRfYRFGJiRPNgfJng PTz/BPbV0Ct8a9NiHQwxjTz6awmRtQX55twtW1WqVCXq/QyAApmGCIls7MQA+91bS9PT y2E/vOuNHg3tqcKP8BRiZAcPZ7d+82939HsVWIvi6IreHyo8tII5BlDe4W0iXwuvXgO0 NT/A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id j14si3839162edl.42.2020.03.10.10.51.11; Tue, 10 Mar 2020 10:51:11 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78AC61C0BC; Tue, 10 Mar 2020 18:50:24 +0100 (CET) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id CFA3F1C0B7; Tue, 10 Mar 2020 18:50:22 +0100 (CET) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 624DA1FB; Tue, 10 Mar 2020 10:50:22 -0700 (PDT) Received: from phil-VirtualBox.arm.com (A010647.Arm.com [10.170.243.28]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 964293F534; Tue, 10 Mar 2020 10:50:18 -0700 (PDT) From: Phil Yang To: thomas@monjalon.net, harry.van.haaren@intel.com, konstantin.ananyev@intel.com, stephen@networkplumber.org, maxime.coquelin@redhat.com, dev@dpdk.org Cc: david.marchand@redhat.com, jerinj@marvell.com, hemant.agrawal@nxp.com, Honnappa.Nagarahalli@arm.com, gavin.hu@arm.com, ruifeng.wang@arm.com, joyce.kong@arm.com, nd@arm.com, Honnappa Nagarahalli , stable@dpdk.org Date: Wed, 11 Mar 2020 01:49:08 +0800 Message-Id: <1583862551-2049-8-git-send-email-phil.yang@arm.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1583862551-2049-1-git-send-email-phil.yang@arm.com> References: <1583862551-2049-1-git-send-email-phil.yang@arm.com> Subject: [dpdk-dev] [PATCH 07/10] service: avoid race condition for MT unsafe service X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Honnappa Nagarahalli There has possible that a MT unsafe service might get configured to run on another core while the service is running currently. This might result in the MT unsafe service running on multiple cores simultaneously. Use 'execute_lock' always when the service is MT unsafe. Fixes: e9139a32f6e8 ("service: add function to run on app lcore") Cc: stable@dpdk.org Signed-off-by: Honnappa Nagarahalli Reviewed-by: Phil Yang --- lib/librte_eal/common/rte_service.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) -- 2.7.4 diff --git a/lib/librte_eal/common/rte_service.c b/lib/librte_eal/common/rte_service.c index 6990dc2..b37fc56 100644 --- a/lib/librte_eal/common/rte_service.c +++ b/lib/librte_eal/common/rte_service.c @@ -50,6 +50,10 @@ struct rte_service_spec_impl { uint8_t internal_flags; /* per service statistics */ + /* Indicates how many cores the service is mapped to run on. + * It does not indicate the number of cores the service is running + * on currently. + */ rte_atomic32_t num_mapped_cores; uint64_t calls; uint64_t cycles_spent; @@ -367,12 +371,7 @@ service_run(uint32_t i, struct core_state *cs, uint64_t service_mask, cs->service_active_on_lcore[i] = 1; - /* check do we need cmpset, if MT safe or <= 1 core - * mapped, atomic ops are not required. - */ - const int use_atomics = (service_mt_safe(s) == 0) && - (rte_atomic32_read(&s->num_mapped_cores) > 1); - if (use_atomics) { + if (service_mt_safe(s) == 0) { if (!rte_atomic32_cmpset((uint32_t *)&s->execute_lock, 0, 1)) return -EBUSY;