From patchwork Thu Dec 27 06:22:57 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 154549 Delivered-To: patch@linaro.org Received: by 2002:a2e:299d:0:0:0:0:0 with SMTP id p29-v6csp6604503ljp; Wed, 26 Dec 2018 22:23:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN6QQogj94ayz1CjuO2le7BI3dyxLLrehODnzJzduaupJJC7qxfunA8k0Ps5kk5BgdQjK9QC X-Received: by 2002:a5d:6907:: with SMTP id t7mr3581345wru.226.1545891813113; Wed, 26 Dec 2018 22:23:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545891813; cv=none; d=google.com; s=arc-20160816; b=lJal1oOVoppFO58QU2dRben859S9xP5vfNoDfGPpimkbv4vMc6qCK/KmZovuU0CzPE nbu+ehVuaLN5pu0KltfApgSeHOVwGf3n0BWw4UC8j6QeakZzMB20DXMuoQtUFfkX1lco JAUyOrZ49QoQdmsyEFYHQHBvgw/HIbyErains7YplTA9F0sWLpyFzjQAJU1CslsVp0/J fl9IfhTVGK/Mr4ZqF+w2Yy5xiISOB1MeMqoun9ohoXY+vdcapFvRMiLleh6uN1ciDgIp QBkXYWH+jxgXjqH1QY6zj+NTYc5yCSlK8VuEQ5QB7sgEmQuFuSx0UVVAXnOrwSWsE8vl AU7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:mime-version :content-transfer-encoding:spamdiagnosticmetadata :spamdiagnosticoutput:content-language:accept-language:in-reply-to :references:message-id:date:thread-index:thread-topic:cc:to:from :dkim-signature; bh=9tH1Cj2moxYQmathpBY4iIEkUbhdykmvpCfgmba4TwI=; b=z3so//35eod5J4B/IqqOu4cIHU6LLlh02zo/nTXww1Rnx8HVexH4U6qMKSqE7xxwkg r2GhD+k3jZRPR3YI/OxLzkUbpDojqu5HRN8UvKrGq6ZQ4Bj58f60cfCpWlo/VLB/ESsL 4T91dNYNPhJCP2nXj/EA7m3HTGwEyZJKOxAn499Q9fBEBbFtvAi7FHR8RMiganeNcC2q 1tRE9aWT7zO0IaTi+FHKkQmPdp6pwkNtpFjIxkuVnY82fWOTB4tBPHOWFTiCb3SsylPo 2ruRTEIww3OuYEzQrhF3D/otQzjmXPIuPr08hmZtNSYAfalTGmls91I+BMzWAXWc8tqg Yk3A== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=N6FruELJ; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id n63si16459500wmn.178.2018.12.26.22.23.32; Wed, 26 Dec 2018 22:23:33 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; dkim=fail header.i=@nxp.com header.s=selector1 header.b=N6FruELJ; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id AE22A4CAB; Thu, 27 Dec 2018 07:23:01 +0100 (CET) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-eopbgr140077.outbound.protection.outlook.com [40.107.14.77]) by dpdk.org (Postfix) with ESMTP id 67BCF4C8E; Thu, 27 Dec 2018 07:22:58 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9tH1Cj2moxYQmathpBY4iIEkUbhdykmvpCfgmba4TwI=; b=N6FruELJDaBO73AONtEd5hBgg7unIiuTRBYBWktOkJovCl1IMAP3Mf9/0/pDZopLBXgkf0zdzK3/tmvJugjqklIIq6gCItTQLmfhnsGcD5JkcRBWgNehY17lbL2D8Ko+efTYzSW/tYcNLAHjTdraidTZhfFULKkFTHMFY36RLoc= Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com (10.168.65.19) by VI1PR0401MB2382.eurprd04.prod.outlook.com (10.169.134.11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1471.20; Thu, 27 Dec 2018 06:22:57 +0000 Received: from VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::555e:164:f8f0:dbb4]) by VI1PR0401MB2541.eurprd04.prod.outlook.com ([fe80::555e:164:f8f0:dbb4%2]) with mapi id 15.20.1471.019; Thu, 27 Dec 2018 06:22:57 +0000 From: Hemant Agrawal To: "dev@dpdk.org" CC: "ferruh.yigit@intel.com" , Shreyansh Jain , "stable@dpdk.org" Thread-Topic: [PATCH 04/20] net/dpaa2: fix bad check for not-null Thread-Index: AQHUnayb/PWWkdoeG0yoMXAKYHyjBQ== Date: Thu, 27 Dec 2018 06:22:57 +0000 Message-ID: <20181227062233.30781-5-hemant.agrawal@nxp.com> References: <20181227062233.30781-1-hemant.agrawal@nxp.com> In-Reply-To: <20181227062233.30781-1-hemant.agrawal@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [14.143.30.134] x-mailer: git-send-email 2.17.1 x-clientproxiedby: BM1PR01CA0120.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:40::14) To VI1PR0401MB2541.eurprd04.prod.outlook.com (2603:10a6:800:56::19) authentication-results: spf=none (sender IP is ) smtp.mailfrom=hemant.agrawal@nxp.com; x-ms-exchange-messagesentrepresentingtype: 1 x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1; VI1PR0401MB2382; 6:L8vEk5f2UUoQq8XZ2RuKmtVfEC91imoB/RiBH9eJ7M3DiiXY4CY0I//CHc62fmtA1mFRo8sLjtjbjqwnviiSRzqg/1Lt24QCm6+mnBkiO3FhEY9KdOxMsXMCKJgVWu0byJwI5IxiWgu0pUVG3uMdbK04jbkdh0XVLLW7rJ0WhziYAJ8v1YLENYG5dC0lcZtVDNmmp4xquT7ck2NF3UsYE+dhqWyAIdNSM7b86DlKmIYPC9c+noxVfIor9EEikio64xX5CRb1hZ+UPBVYoPHXui8gQrMKz6ssgJeDmWM9ab9YjO8AHWfMXbZF6NFy3H80JPlfEnuvh1MYN/qNY7spmoBieIBB7g6KijxE1imEoeqn6YC3ti3L5lX/3pfjDLzDy79d0A8Pp17+/fugTxGatLsVNFZn8v6B77Z2IWvhptM9EK2Wvh6YYyyo3k1IFiGWbOf2FD6xMfnoE01V1KaJaQ==; 5:x+DhVm1rVTiChZ/SJmryptEEZGo2YDVTM20kd+FFoSQW7sFKUUfFGwFb+s9yyyK7Pit4/RYuodbkZ071q8YB5qQiPaE66ppDfP2dSmU4B3yEcqT09dLs/ki4ZYQcG0o3tOuJqfmWmGc2eZm/qu6GFnOr/44Num9Ey/khFVg8nCk=; 7:fPCb+PWoB7C0P36NOi5aVbE1espI5hyMZvP0WS1G/Gtm8BNnAIoXw5jnQMBT89McmtZjB15lB7rKbf0UwQWCe0tPPMKAZySUr+XC1k1ESZrNojrwMYcw+6B/7dtFbPXdnDDZ2sBIm5ouh4sbmxX7eA== x-ms-office365-filtering-correlation-id: fb78260d-6290-44a4-b39e-08d66bc3bdf7 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: BCL:0; PCL:0; RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(7168020)(4627221)(201703031133081)(201702281549075)(8990200)(5600074)(711020)(4618075)(2017052603328)(7153060)(7193020); SRVR:VI1PR0401MB2382; x-ms-traffictypediagnostic: VI1PR0401MB2382: x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0; PCL:0; RULEID:(8211001083)(3230021)(908002)(999002)(5005026)(6040522)(2401047)(8121501046)(10201501046)(3002001)(93006095)(93001095)(3231475)(944501520)(52105112)(6055026)(6041310)(20161123560045)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123558120)(201708071742011)(7699051)(76991095); SRVR:VI1PR0401MB2382; BCL:0; PCL:0; RULEID:; SRVR:VI1PR0401MB2382; x-forefront-prvs: 0899B47777 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(136003)(396003)(366004)(376002)(39860400002)(346002)(199004)(189003)(5660300001)(1076003)(26005)(76176011)(186003)(71200400001)(256004)(25786009)(105586002)(4326008)(6436002)(305945005)(11346002)(106356001)(446003)(44832011)(476003)(7736002)(55236004)(102836004)(78486014)(486006)(386003)(68736007)(52116002)(86362001)(6506007)(2616005)(71190400001)(66066001)(316002)(54906003)(6116002)(3846002)(2906002)(14454004)(36756003)(99286004)(50226002)(8936002)(1730700003)(81156014)(81166006)(8676002)(6512007)(53936002)(478600001)(97736004)(6486002)(6916009)(5640700003)(2351001)(2501003); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR0401MB2382; H:VI1PR0401MB2541.eurprd04.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; received-spf: None (protection.outlook.com: nxp.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 05qtwwGxUPZi15b13Qy4BR/hCBsM3tqSXd4VpV+CMayxjFmROsr/7r3jfgy0HV+Vz1uF0unG3dSFlQHAL/dAjJU+uMe8tMA1le2sEwr7epnnfW9pn24BDVuyfbYjUOPKYs/wp6uEMCSDceFzOOo/vgWKCMLlrNwavxtjgRUlE1xVdoWZL07HLfI0YM7M8wyDUU+9QWFtRMbOY6hyX/OLyomB+moZPmTUNLYBSwbs+EPG02IMSXrv+nR/cgdpRjFxw9mILph4y1BNwcdde3q0uCt/m3YVOZOPWrHURcCceCU5bouJIqGtMG4m8KkFh/Hx spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb78260d-6290-44a4-b39e-08d66bc3bdf7 X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2018 06:22:57.3488 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2382 Subject: [dpdk-dev] [PATCH 04/20] net/dpaa2: fix bad check for not-null X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" The check !dpaa2->cscn is not correct to check non-null value. Fixes: 5d9a1e4d23fe ("net/dpaa2: enhance queue memory cleanup") Cc: stable@dpdk.org Signed-off-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) -- 2.17.1 diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index fa71807e6..8d4ea1bca 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -311,8 +311,7 @@ dpaa2_free_rx_tx_queues(struct rte_eth_dev *dev) /* cleanup tx queue cscn */ for (i = 0; i < priv->nb_tx_queues; i++) { dpaa2_q = (struct dpaa2_queue *)priv->tx_vq[i]; - if (!dpaa2_q->cscn) - rte_free(dpaa2_q->cscn); + rte_free(dpaa2_q->cscn); } /*free memory for all queues (RX+TX) */ rte_free(priv->rx_vq[0]);