From patchwork Thu May 7 10:46:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 186289 Delivered-To: patch@linaro.org Received: by 2002:a92:8d81:0:0:0:0:0 with SMTP id w1csp3041000ill; Thu, 7 May 2020 03:49:08 -0700 (PDT) X-Google-Smtp-Source: APiQypL/fIL+8NT+vwzkml1V1J6MBQ5kGUYLyUZM7VBHOYSDTUa13vA66az1OpA7NJK0lpqHc+EM X-Received: by 2002:a05:6402:6cb:: with SMTP id n11mr11456292edy.210.1588848546861; Thu, 07 May 2020 03:49:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1588848546; cv=none; d=google.com; s=arc-20160816; b=NBQRNQ5C5KEhRvpqo8BUVmM43GovzyeLsO0VvaWnIJL+rtSCh9kMeYzIljf8/TfvJu Ehk1gj5DCREBHBDp1RV8rJxGKYWQCKM+HfvG3FQyZpAETfbkoNqkOsOqbxbn7MXHSEQ0 RtP3kmEZmXuTrJrqW4T53linXbBPR5Wie7PgGgzR8mQJCaVKz5DeoAJ7L5rdUrJv1wk/ ysirQaXy1sVyr4N5wTFLp5B7uE1OPiI0V7FfNq3RTEfmPEOnyRGpLj4qbeBdyRaaTU+/ NITcbQJGiKMoK438h2kKQ7IOnD1QgQYlfunXB4NW+ZWyQoiXCud5TH98lxHUboFMvbWd xVFg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=/to1Eu13YE64aeh92+9eSUIk7gyZjhEoYDVwpYa7Vhk=; b=fcR/mAvhO7DhZLiTgE/FoBur0uZE2cKgEdxOsZKbaGOKeOUqXG8XqetQ8iDt/nYb6c eqlxdP+KWQRntif+uppoRoI94pqrpknlcNkcnqu5uQaaMwy8Hb21h7eztcYsFBi3kO/H booQ7rFi0t8JLUzjlscOWtm/vCupLk9SCDEdEVw3CWESJSyG1GhZnV3Tu9T8pGVq2HL5 wYjJG/6ZTrc4aLeJf2tN5yuvagoh+R7eas5VO7FSC+0m8KspGOW5u69Kf06g69Gehk9P Uzyk/djZTkKm8vhQcjpuGyxF/1aZbWw3n5gjwqrCZsZjQW1+GuKTSyMDbmI3+LUkPQWA 4kjA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from dpdk.org (dpdk.org. [92.243.14.124]) by mx.google.com with ESMTP id m10si2825579edr.459.2020.05.07.03.49.06; Thu, 07 May 2020 03:49:06 -0700 (PDT) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) client-ip=92.243.14.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 92.243.14.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23C021DBEC; Thu, 7 May 2020 12:49:03 +0200 (CEST) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by dpdk.org (Postfix) with ESMTP id 37CF81DBE1; Thu, 7 May 2020 12:49:00 +0200 (CEST) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id F0D7E2017F7; Thu, 7 May 2020 12:48:59 +0200 (CEST) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id ED0B5200386; Thu, 7 May 2020 12:48:57 +0200 (CEST) Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.133.63]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 0B92740310; Thu, 7 May 2020 18:48:54 +0800 (SGT) From: Hemant Agrawal To: dev@dpdk.org, ferruh.yigit@intel.com Cc: stable@dpdk.org, Apeksha Gupta Date: Thu, 7 May 2020 16:16:37 +0530 Message-Id: <20200507104645.31990-2-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200507104645.31990-1-hemant.agrawal@nxp.com> References: <20200504124118.22877-1-hemant.agrawal@nxp.com> <20200507104645.31990-1-hemant.agrawal@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH v4 1/9] bus/fslmc: fix dereferencing null pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Apeksha Gupta This patch fixees the nxp internal coverity reported null pointer dereferncing issue. Fixes: 6fef517e17cf ("bus/fslmc: add qman HW fq query count API") Cc: stable@dpdk.org Signed-off-by: Apeksha Gupta --- drivers/bus/fslmc/qbman/qbman_debug.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.17.1 diff --git a/drivers/bus/fslmc/qbman/qbman_debug.c b/drivers/bus/fslmc/qbman/qbman_debug.c index 0bb2ce880f..4cd0923acb 100644 --- a/drivers/bus/fslmc/qbman/qbman_debug.c +++ b/drivers/bus/fslmc/qbman/qbman_debug.c @@ -27,19 +27,20 @@ int qbman_fq_query_state(struct qbman_swp *s, uint32_t fqid, struct qbman_fq_query_np_rslt *r) { struct qbman_fq_query_desc *p; + struct qbman_fq_query_np_rslt *var; p = (struct qbman_fq_query_desc *)qbman_swp_mc_start(s); if (!p) return -EBUSY; p->fqid = fqid; - *r = *(struct qbman_fq_query_np_rslt *)qbman_swp_mc_complete(s, p, - QBMAN_FQ_QUERY_NP); - if (!r) { + var = qbman_swp_mc_complete(s, p, QBMAN_FQ_QUERY_NP); + if (!var) { pr_err("qbman: Query FQID %d NP fields failed, no response\n", fqid); return -EIO; } + *r = *var; /* Decode the outcome */ QBMAN_BUG_ON((r->verb & QBMAN_RESPONSE_VERB_MASK) != QBMAN_FQ_QUERY_NP);