From patchwork Wed Feb 24 12:43:05 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 386853 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp343055jap; Wed, 24 Feb 2021 04:45:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJyf+gDHIxl63cQE8jSVAYAHOS1NM0V1NH4usnSwzOsIBkrJ3+9zn2bovACvifDypGly1SHA X-Received: by 2002:a17:906:c0d7:: with SMTP id bn23mr30611606ejb.94.1614170743866; Wed, 24 Feb 2021 04:45:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614170743; cv=none; d=google.com; s=arc-20160816; b=LWbif1LcTvNg91teBbaKG/NpMRfAQSiPpW1o0jZTHCnnDHUSCo52NrjFIFIa1D4d/C xMkUgo3OyQA311vilG9fhqpt+Ho8N6rNuGr41MKGxfW482mX9UQqo+7Oc+Bknd4QagLk Y/9lV9hcvUjabQGO6gah60JksJr5oakPZebJqBZZvgikMJ1YoDLwFuo3+XyIj3d5+p++ QfI61zRn7tr3py3kZ2osM0ROiqALbfxARsrxKgULJ5lfWvQxE0APOJIy0EkTS4UeSyWI yHkWQuTg10Pjad77MDEIlxohxD1wGjmmJ1dwr+mXkI835kxyGaNas8K+XsxsEDrB6uB+ tFug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=CvDZOHzTSVofWQrMuaQ1w9s+PEK7lgireSVID0sHFFQ=; b=FIp153PSNtPwAwGYlRBzRmrXdmU6uGZrAuHoHVcra59kZN2sY2lbxZJYPAnYyxuKgI h0oqWoEWZUMvhQy1LlJhHGfGScG/PfqBt86/2wELidCGsEVVmvpDjXg7dwS8cpQmQdR+ 0CRN+2YYvIBrKWcTJdWCB6mdLt7LfOpGSNYdPfK5VL9aN2d/jbFSEOqN8YqE913ABY0k ldKU+UlR3gg1tLac6H9CCBhgGw1yil4Tt5xf7NwPqdM75Ja57hQWX1wOIHpN9g2Fpzy5 2bPfQzeKymNLLGfMvOzS3w58Qb/CTo6U4LhXH80d3iPZenA4cNrqEk0A0at4E9w4+fku UNfA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from mails.dpdk.org (mails.dpdk.org. [217.70.189.124]) by mx.google.com with ESMTP id v25si874869ejw.423.2021.02.24.04.45.43; Wed, 24 Feb 2021 04:45:43 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) client-ip=217.70.189.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 977BF1608B1; Wed, 24 Feb 2021 13:43:43 +0100 (CET) Received: from inva020.nxp.com (inva020.nxp.com [92.121.34.13]) by mails.dpdk.org (Postfix) with ESMTP id 63695160858 for ; Wed, 24 Feb 2021 13:43:29 +0100 (CET) Received: from inva020.nxp.com (localhost [127.0.0.1]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 3870A1A03AC; Wed, 24 Feb 2021 13:43:29 +0100 (CET) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva020.eu-rdc02.nxp.com (Postfix) with ESMTP id 215061A0395; Wed, 24 Feb 2021 13:43:27 +0100 (CET) Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.133.63]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id 78B25402D6; Wed, 24 Feb 2021 13:43:24 +0100 (CET) From: Hemant Agrawal To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Nipun Gupta Date: Wed, 24 Feb 2021 18:13:05 +0530 Message-Id: <20210224124311.29799-18-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210224124311.29799-1-hemant.agrawal@nxp.com> References: <20210211141620.12482-1-hemant.agrawal@nxp.com> <20210224124311.29799-1-hemant.agrawal@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH v3 17/23] net/dpaa: do not release the cgr ranges X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Nipun Gupta CGR are automatically freed up in the kernel. As we do not cleanup the queues, if we release the CGR here, kernel reports them in use. So have them freed up in the kernel Signed-off-by: Nipun Gupta Acked-by: Hemant Agrawal --- drivers/net/dpaa/dpaa_ethdev.c | 6 ------ 1 file changed, 6 deletions(-) -- 2.17.1 diff --git a/drivers/net/dpaa/dpaa_ethdev.c b/drivers/net/dpaa/dpaa_ethdev.c index c59873dd8a..0996edf9a9 100644 --- a/drivers/net/dpaa/dpaa_ethdev.c +++ b/drivers/net/dpaa/dpaa_ethdev.c @@ -486,9 +486,6 @@ static int dpaa_eth_dev_close(struct rte_eth_dev *dev) if (dpaa_intf->cgr_rx) { for (loop = 0; loop < dpaa_intf->nb_rx_queues; loop++) qman_delete_cgr(&dpaa_intf->cgr_rx[loop]); - - qman_release_cgrid_range(dpaa_intf->cgr_rx[loop].cgrid, - dpaa_intf->nb_rx_queues); } rte_free(dpaa_intf->cgr_rx); @@ -497,9 +494,6 @@ static int dpaa_eth_dev_close(struct rte_eth_dev *dev) if (dpaa_intf->cgr_tx) { for (loop = 0; loop < MAX_DPAA_CORES; loop++) qman_delete_cgr(&dpaa_intf->cgr_tx[loop]); - - qman_release_cgrid_range(dpaa_intf->cgr_tx[loop].cgrid, - MAX_DPAA_CORES); rte_free(dpaa_intf->cgr_tx); dpaa_intf->cgr_tx = NULL; }