From patchwork Wed Feb 24 12:42:49 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hemant Agrawal X-Patchwork-Id: 386838 Delivered-To: patch@linaro.org Received: by 2002:a02:290e:0:0:0:0:0 with SMTP id p14csp341611jap; Wed, 24 Feb 2021 04:43:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJyfoSsznwnY2IAK553tSR51nw8uFB0dgzlbZ8BYM8fYnt+nQi0ZDKjIk00kMRA89XajJ85a X-Received: by 2002:a17:906:28d0:: with SMTP id p16mr29613128ejd.124.1614170605120; Wed, 24 Feb 2021 04:43:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1614170605; cv=none; d=google.com; s=arc-20160816; b=n9wnp4yd/MwhaMHfcYPQpnW+9h/VofT/+op2aJCfW8EI+31Dd9daKtU63pzUQh+cnS CwFfX7t39vd+D+HcAaSqfCTYBpI0kCDwfg174Y0iEDbWbylwjU+gnd8tgvQeZ5Izc1ZK ZsqYbmws9oS0+odIUYxXoxMNj5Wcemxuf6NMtT2/6RxamtkBsrEoUlD2XhB7TIwCfidd 5ZOU4f67WqtOYMoQyNRWM86vGrgV9PBUOMcPEAWeP0YfsjVzRNeO4X6bE901A3p+QW+F SPa06IoBPDT8a7uCAJ17AAj00Kj3DGBxjC7qxJFHztceiCd4vGOnSFHkk5Xr4Mcwjt/0 N+sA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:subject:references:in-reply-to :message-id:date:cc:to:from; bh=F8L/SMApKSfHc25a3edvZWHeUD3vDYEkI1Qew0KM/sY=; b=tLHnHc88VnQrw+2jdsISqQgErRaoIffE13VcL5eA1V8PHdNCqCbgAsgb6Tk8vuw6AF cpuTBzu0aH1PAsU2/qPBY3SpgP18t490OpVyPkT9k52gRoYKl2AXk8VxZ3OePida3h8D +51+A5jnDnY7WZZ8AVTR2qmTqL9TCXIfcD49ae0gDiNLx0GtnISrpx/RENnhRux9x6+4 NZkhwdJkpMUui4dv7Qxx1Js/kkm+vcaZPc7B+eUo1/t4uWZWwn/v9yOYrA4oIhD2DM9K SixiOHlnudIn3wCphWwohYffpz4jHtvBSWTeB96Wd+yzCDr+txgfa2c0Bru9y2GswQpF ownQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Return-Path: Received: from mails.dpdk.org (mails.dpdk.org. [217.70.189.124]) by mx.google.com with ESMTP id g7si1125136edh.31.2021.02.24.04.43.24; Wed, 24 Feb 2021 04:43:25 -0800 (PST) Received-SPF: pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) client-ip=217.70.189.124; Authentication-Results: mx.google.com; spf=pass (google.com: domain of dev-bounces@dpdk.org designates 217.70.189.124 as permitted sender) smtp.mailfrom=dev-bounces@dpdk.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=nxp.com Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8190B160831; Wed, 24 Feb 2021 13:43:21 +0100 (CET) Received: from inva021.nxp.com (inva021.nxp.com [92.121.34.21]) by mails.dpdk.org (Postfix) with ESMTP id 5D8D616082C; Wed, 24 Feb 2021 13:43:20 +0100 (CET) Received: from inva021.nxp.com (localhost [127.0.0.1]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 278BF2005B1; Wed, 24 Feb 2021 13:43:20 +0100 (CET) Received: from invc005.ap-rdc01.nxp.com (invc005.ap-rdc01.nxp.com [165.114.16.14]) by inva021.eu-rdc02.nxp.com (Postfix) with ESMTP id 8F4EF200597; Wed, 24 Feb 2021 13:43:17 +0100 (CET) Received: from bf-netperf1.ap.freescale.net (bf-netperf1.ap.freescale.net [10.232.133.63]) by invc005.ap-rdc01.nxp.com (Postfix) with ESMTP id F0B0F40319; Wed, 24 Feb 2021 13:43:13 +0100 (CET) From: Hemant Agrawal To: dev@dpdk.org Cc: ferruh.yigit@intel.com, stable@dpdk.org, Youri Querry Date: Wed, 24 Feb 2021 18:12:49 +0530 Message-Id: <20210224124311.29799-2-hemant.agrawal@nxp.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20210224124311.29799-1-hemant.agrawal@nxp.com> References: <20210211141620.12482-1-hemant.agrawal@nxp.com> <20210224124311.29799-1-hemant.agrawal@nxp.com> X-Virus-Scanned: ClamAV using ClamSMTP Subject: [dpdk-dev] [PATCH v3 01/23] bus/fslmc: fix to use ci value for qbman 5.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Youri Querry Random portal hangs observed on device with QBMAN 5.0 This fixes few random packet hang issues in event mode. Few things fixed it. 1. Generally, pi == ci, no need for extra checks. 2. The proper initializations in init with ci Fixes: 1b49352f41be ("bus/fslmc: rename portal pi index to consumer index") Cc: stable@dpdk.org Signed-off-by: Youri Querry Acked-by: Hemant Agrawal --- drivers/bus/fslmc/qbman/qbman_portal.c | 14 +++----------- 1 file changed, 3 insertions(+), 11 deletions(-) -- 2.17.1 diff --git a/drivers/bus/fslmc/qbman/qbman_portal.c b/drivers/bus/fslmc/qbman/qbman_portal.c index 77c9d508c4..aedcad9258 100644 --- a/drivers/bus/fslmc/qbman/qbman_portal.c +++ b/drivers/bus/fslmc/qbman/qbman_portal.c @@ -339,17 +339,9 @@ struct qbman_swp *qbman_swp_init(const struct qbman_swp_desc *d) eqcr_pi = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_PI); p->eqcr.pi = eqcr_pi & p->eqcr.pi_ci_mask; p->eqcr.pi_vb = eqcr_pi & QB_VALID_BIT; - if ((p->desc.qman_version & QMAN_REV_MASK) >= QMAN_REV_5000 - && (d->cena_access_mode == qman_cena_fastest_access)) - p->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_PI) - & p->eqcr.pi_ci_mask; - else - p->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_CI) - & p->eqcr.pi_ci_mask; - p->eqcr.available = p->eqcr.pi_ring_size - - qm_cyc_diff(p->eqcr.pi_ring_size, - p->eqcr.ci & (p->eqcr.pi_ci_mask<<1), - p->eqcr.pi & (p->eqcr.pi_ci_mask<<1)); + p->eqcr.ci = qbman_cinh_read(&p->sys, QBMAN_CINH_SWP_EQCR_CI) + & p->eqcr.pi_ci_mask; + p->eqcr.available = p->eqcr.pi_ring_size; portal_idx_map[p->desc.idx] = p; return p;