mbox series

[v3,0/3] drm/omap: Make omapdss API more generic + related patches

Message ID cover.1518001667.git.jsarha@ti.com
Headers show
Series drm/omap: Make omapdss API more generic + related patches | expand

Message

Jyri Sarha Feb. 7, 2018, 2:11 p.m. UTC 
Since v2:
- Simplify dispc_mgr_has_framedone() 
- dispc_hw_to_api_irq() and dispc_api_to_hw_irq() use new dispc_irq_bits[]
- rename dispc_ops read_irqstatus() to read_and_clear_irqstatus() and remove
  clearmask
- precalculate priv->irq_uf_mask in omap_drm_irq_install() and use it in
  omap_irq_fifo_underflow()

Here is the v2 round:
https://lists.freedesktop.org/archives/dri-devel/2018-January/161353.html

Since RFC:

This the v2 rouns of a this RFC patch:
https://patchwork.kernel.org/patch/10066245/

The first patch is a simple fix that should be applied in any case.

I did not split the mgr_has_framedone() callback as a separate patch. It
quite literally replaces the mgr_get_framedone_irq() and makes no
sense without the "drm/omap: Make omapdss API more generic"-patch.

Best regards,
  Jyri

Jyri Sarha (3):
  drm/omap: Fail probe if irq registration fails
  drm/omap: Add get_ovl_name() and get_mgr_name() to dispc_ops
  drm/omap: Make omapdss API more generic

 drivers/gpu/drm/omapdrm/dss/dispc.c   | 113 ++++++++++++++++++++++++------
 drivers/gpu/drm/omapdrm/dss/dispc.h   |  33 +++++++++
 drivers/gpu/drm/omapdrm/dss/omapdss.h |  67 ++++++++----------
 drivers/gpu/drm/omapdrm/omap_crtc.c   |  27 +++-----
 drivers/gpu/drm/omapdrm/omap_crtc.h   |   2 +-
 drivers/gpu/drm/omapdrm/omap_drv.c    |   4 +-
 drivers/gpu/drm/omapdrm/omap_drv.h    |   3 +-
 drivers/gpu/drm/omapdrm/omap_irq.c    | 125 +++++++++++++++-------------------
 drivers/gpu/drm/omapdrm/omap_irq.h    |   2 +-
 drivers/gpu/drm/omapdrm/omap_plane.c  |  18 ++---
 drivers/gpu/drm/omapdrm/omap_plane.h  |   1 +
 11 files changed, 237 insertions(+), 158 deletions(-)

Comments

Tomi Valkeinen Feb. 8, 2018, 8:57 a.m. UTC | #1 
On 07/02/18 16:11, Jyri Sarha wrote:
> Since v2:
> - Simplify dispc_mgr_has_framedone() 
> - dispc_hw_to_api_irq() and dispc_api_to_hw_irq() use new dispc_irq_bits[]
> - rename dispc_ops read_irqstatus() to read_and_clear_irqstatus() and remove
>   clearmask
> - precalculate priv->irq_uf_mask in omap_drm_irq_install() and use it in
>   omap_irq_fifo_underflow()

Can you run these through checkpatch? There was at least one issue that
needs to be fixed:

WARNING: static const char * array should probably be static const char
* const

Other than the small comments I sent, I think it looks good.

Laurent, do you have any objections?

I think we probably will change the design later on how the irqs are
handled (possibly move the irq handling code away from the common
parts), but I think this cleans up things nicely for the time being.

 Tomi