From patchwork Wed Aug 10 13:09:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rob Clark X-Patchwork-Id: 3371 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id D64C323F41 for ; Wed, 10 Aug 2011 13:09:33 +0000 (UTC) Received: from mail-qw0-f52.google.com (mail-qw0-f52.google.com [209.85.216.52]) by fiordland.canonical.com (Postfix) with ESMTP id A5E01A186BC for ; Wed, 10 Aug 2011 13:09:33 +0000 (UTC) Received: by qwb8 with SMTP id 8so778930qwb.11 for ; Wed, 10 Aug 2011 06:09:33 -0700 (PDT) Received: by 10.229.42.10 with SMTP id q10mr3493729qce.45.1312981773012; Wed, 10 Aug 2011 06:09:33 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.229.190.71 with SMTP id dh7cs80609qcb; Wed, 10 Aug 2011 06:09:32 -0700 (PDT) Received: by 10.236.152.40 with SMTP id c28mr526569yhk.228.1312981772578; Wed, 10 Aug 2011 06:09:32 -0700 (PDT) Received: from mail-yi0-f50.google.com (mail-yi0-f50.google.com [209.85.218.50]) by mx.google.com with ESMTPS id j1si2339123yhn.18.2011.08.10.06.09.32 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Aug 2011 06:09:32 -0700 (PDT) Received-SPF: pass (google.com: domain of robdclark@gmail.com designates 209.85.218.50 as permitted sender) client-ip=209.85.218.50; Authentication-Results: mx.google.com; spf=pass (google.com: domain of robdclark@gmail.com designates 209.85.218.50 as permitted sender) smtp.mail=robdclark@gmail.com; dkim=pass (test mode) header.i=@gmail.com Received: by yib18 with SMTP id 18so705568yib.37 for ; Wed, 10 Aug 2011 06:09:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=sender:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=6CNU5ov3CWQ8XD118yHmxRDHaV4bVXUoqpHSjYG+nok=; b=R9VjnuhxWloMGIYPSKqzhEyU6afZoSHwdpzutbaA04T0ZimSGcPNX+lWc5iXQjxUtk AWNMxY8ha2li8JWpCwGqIQ5jQDbalvMpvTm2QTxbcVLLWd8q8qU4P/lBmE/imCjjcQo/ 4JjDsmgQ/ynUxNxHkcQFAebY/5h7Bd8j2Yk4A= Received: by 10.150.244.7 with SMTP id r7mr229790ybh.183.1312981772360; Wed, 10 Aug 2011 06:09:32 -0700 (PDT) Received: from localhost (dragon.ti.com [192.94.94.33]) by mx.google.com with ESMTPS id v10sm2815775ybm.13.2011.08.10.06.09.30 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 10 Aug 2011 06:09:31 -0700 (PDT) Sender: Rob Clark From: Rob Clark To: dri-devel@lists.freedesktop.org Cc: patches@linaro.org, Rob Clark , Alan Cox Subject: [PATCH 3/3] drm/gma500: use common functions for mmap offset creation Date: Wed, 10 Aug 2011 08:09:09 -0500 Message-Id: <1312981749-16106-3-git-send-email-rob@ti.com> X-Mailer: git-send-email 1.7.5.4 In-Reply-To: <1312981749-16106-1-git-send-email-rob@ti.com> References: <1312981749-16106-1-git-send-email-rob@ti.com> Signed-off-by: Rob Clark Signed-off-by: Alan Cox --- drivers/staging/gma500/psb_gem.c | 63 +------------------------------------ 1 files changed, 2 insertions(+), 61 deletions(-) diff --git a/drivers/staging/gma500/psb_gem.c b/drivers/staging/gma500/psb_gem.c index 76ff7ba..3a397f5 100644 --- a/drivers/staging/gma500/psb_gem.c +++ b/drivers/staging/gma500/psb_gem.c @@ -42,13 +42,7 @@ void psb_gem_free_object(struct drm_gem_object *obj) struct gtt_range *gtt = container_of(obj, struct gtt_range, gem); psb_gtt_free_range(obj->dev, gtt); if (obj->map_list.map) { - /* Do things GEM should do for us */ - struct drm_gem_mm *mm = obj->dev->mm_private; - struct drm_map_list *list = &obj->map_list; - drm_ht_remove_item(&mm->offset_hash, &list->hash); - drm_mm_put_block(list->file_offset_node); - kfree(list->map); - list->map = NULL; + drm_gem_free_mmap_offset(obj); } drm_gem_object_release(obj); } @@ -60,59 +54,6 @@ int psb_gem_get_aperture(struct drm_device *dev, void *data, } /** - * psb_gem_create_mmap_offset - invent an mmap offset - * @obj: our object - * - * This is basically doing by hand a pile of ugly crap which should - * be done automatically by the GEM library code but isn't - */ -static int psb_gem_create_mmap_offset(struct drm_gem_object *obj) -{ - struct drm_device *dev = obj->dev; - struct drm_gem_mm *mm = dev->mm_private; - struct drm_map_list *list; - struct drm_local_map *map; - int ret; - - list = &obj->map_list; - list->map = kzalloc(sizeof(struct drm_map_list), GFP_KERNEL); - if (list->map == NULL) - return -ENOMEM; - map = list->map; - map->type = _DRM_GEM; - map->size = obj->size; - map->handle =obj; - - list->file_offset_node = drm_mm_search_free(&mm->offset_manager, - obj->size / PAGE_SIZE, 0, 0); - if (!list->file_offset_node) { - DRM_ERROR("failed to allocate offset for bo %d\n", obj->name); - ret = -ENOSPC; - goto free_it; - } - list->file_offset_node = drm_mm_get_block(list->file_offset_node, - obj->size / PAGE_SIZE, 0); - if (!list->file_offset_node) { - ret = -ENOMEM; - goto free_it; - } - list->hash.key = list->file_offset_node->start; - ret = drm_ht_insert_item(&mm->offset_hash, &list->hash); - if (ret) { - DRM_ERROR("failed to add to map hash\n"); - goto free_mm; - } - return 0; - -free_mm: - drm_mm_put_block(list->file_offset_node); -free_it: - kfree(list->map); - list->map = NULL; - return ret; -} - -/** * psb_gem_dumb_map_gtt - buffer mapping for dumb interface * @file: our drm client file * @dev: drm device @@ -142,7 +83,7 @@ int psb_gem_dumb_map_gtt(struct drm_file *file, struct drm_device *dev, /* Make it mmapable */ if (!obj->map_list.map) { - ret = psb_gem_create_mmap_offset(obj); + ret = drm_gem_create_mmap_offset(obj); if (ret) goto out; }