From patchwork Mon Aug 6 06:46:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 10498 Return-Path: X-Original-To: patchwork@peony.canonical.com Delivered-To: patchwork@peony.canonical.com Received: from fiordland.canonical.com (fiordland.canonical.com [91.189.94.145]) by peony.canonical.com (Postfix) with ESMTP id 8A1DF23F3F for ; Mon, 6 Aug 2012 06:47:56 +0000 (UTC) Received: from mail-gg0-f180.google.com (mail-gg0-f180.google.com [209.85.161.180]) by fiordland.canonical.com (Postfix) with ESMTP id 59817A18CE6 for ; Mon, 6 Aug 2012 06:47:56 +0000 (UTC) Received: by mail-gg0-f180.google.com with SMTP id f1so2178989ggn.11 for ; Sun, 05 Aug 2012 23:47:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-forwarded-to:x-forwarded-for:delivered-to:received-spf:from:to:cc :subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=vn1A0g86gp/MP00dNn7mG/+Qi7FToJn+XtvREt+zpAg=; b=KsfAsMdWLZvGrKtibiSzOk3PuyAsAGK5Fu5IDQlJuROZXSUkIkzH22Ofl0aX39Kedj kUy20+xfA+DqZJWnAdulTlbVBGqj3RkvtadY1uYZayjbcKHEVY9UnwR4heqwftu015Rb ZrjGDEHZTMCBRuCcHF/VNmFRAz733J9EGFBYr4Qh7u7JiBVUscmgw0KVBVzUKilJ9cdP 6zR4rlQdXkGwrb2ZdDVOGRgFLl1PjdJbs/RemGB/bFSx/alaM7Bj9PaUFXqdlHIbGGyK qLobHnTk8ftmfmcL7MrbWqhqLxV74DmQj5OoXCSXWhQxSQ++6Dyji4K4+q2OTp97Jv/v rhXQ== Received: by 10.50.219.194 with SMTP id pq2mr4461226igc.25.1344235675870; Sun, 05 Aug 2012 23:47:55 -0700 (PDT) X-Forwarded-To: linaro-patchwork@canonical.com X-Forwarded-For: patch@linaro.org linaro-patchwork@canonical.com Delivered-To: patches@linaro.org Received: by 10.50.87.40 with SMTP id u8csp424401igz; Sun, 5 Aug 2012 23:47:55 -0700 (PDT) Received: by 10.66.87.138 with SMTP id ay10mr15981143pab.38.1344235675285; Sun, 05 Aug 2012 23:47:55 -0700 (PDT) Received: from mail-pb0-f50.google.com (mail-pb0-f50.google.com [209.85.160.50]) by mx.google.com with ESMTPS id go9si19025681pbc.157.2012.08.05.23.47.55 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Aug 2012 23:47:55 -0700 (PDT) Received-SPF: neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) client-ip=209.85.160.50; Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.160.50 is neither permitted nor denied by best guess record for domain of sachin.kamat@linaro.org) smtp.mail=sachin.kamat@linaro.org Received: by mail-pb0-f50.google.com with SMTP id md12so3840460pbc.37 for ; Sun, 05 Aug 2012 23:47:55 -0700 (PDT) Received: by 10.68.225.231 with SMTP id rn7mr16468657pbc.13.1344235675045; Sun, 05 Aug 2012 23:47:55 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ql6sm8331600pbc.61.2012.08.05.23.47.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 05 Aug 2012 23:47:54 -0700 (PDT) From: Sachin Kamat To: dri-devel@lists.freedesktop.org Cc: inki.dae@samsung.com, airlied@linux.ie, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/5] drm/exynos: Remove redundant check in exynos_drm_fimd.c file Date: Mon, 6 Aug 2012 12:16:17 +0530 Message-Id: <1344235580-3030-3-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> References: <1344235580-3030-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlXjE7cIYqQRA2gB0eSuOWQhXtS11gIEJ/JWyaQN2rDGGYFImLoBO4KXLvRdNT3fs6srkG4 devm_request_and_ioremap function checks the validity of the pointer returned by platform_get_resource. Hence an additional check in the probe function is not necessary. Signed-off-by: Sachin Kamat --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 5 ----- 1 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fimd.c b/drivers/gpu/drm/exynos/exynos_drm_fimd.c index a68d2b3..b19cd93 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fimd.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fimd.c @@ -831,11 +831,6 @@ static int __devinit fimd_probe(struct platform_device *pdev) } res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(dev, "failed to find registers\n"); - ret = -ENOENT; - goto err_clk; - } ctx->regs = devm_request_and_ioremap(&pdev->dev, res); if (!ctx->regs) {